[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

2022-11-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] [master] Add a rebalance request/response and provide a tool, refact master's rebalance

2022-05-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 ) Change subject: [master] Add a rebalance request/response and provide a tool, refact master's rebalance .. Patch Set 14: (3 comments)

[kudu-CR] [tools] update schema if needed when rebuild master

2022-05-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18

[kudu-CR] [threadpool] KUDU-3364 Add TimerThread for thread pool

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18447 ) Change subject: [threadpool] KUDU-3364 Add TimerThread for thread pool .. Patch Set 13: (13 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. Patch Set 28: Thanks for addressing all the feedback! -- To

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. [java] Fix a scan bug which will read repetitive rows.

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. Patch Set 27: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] KUDU-1644: Simplify InList predicate values based on rowset PK bounds

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18434 ) Change subject: KUDU-1644: Simplify InList predicate values based on rowset PK bounds .. Patch Set 2: Code-Review+1 (2 comments) Would

[kudu-CR] [tools] use thread pool for 'kudu local replica copy from local'

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18448 ) Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local' .. Patch Set 8: Code-Review+2 Thanks for the improvemen

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-05-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. Patch Set 26: Code-Review+1 (1 comment) Basically LGTM, but w

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. Patch Set 24: (5 comments) Sorry for the delay! Looking bette

[kudu-CR] KUDU-1644: Simplify InList predicate values based on rowset PK bounds

2022-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18434 ) Change subject: KUDU-1644: Simplify InList predicate values based on rowset PK bounds .. Patch Set 2: (2 comments) http://gerrit.cloud

[kudu-CR] wip KUDU-3357

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18478 Change subject: wip KUDU-3357 .. wip KUDU-3357 - RPC advertised addresses are now exposed through a different channel than the 'rpc_add

[kudu-CR] util: pull jwt code from Impala

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18467 Change subject: util: pull jwt code from Impala .. util: pull jwt code from Impala Change-Id: Ib546762aa7ff53009f32688c30c5642ee4df494b -

[kudu-CR] jwt: Java client usage of JWTs

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18477 Change subject: jwt: Java client usage of JWTs .. jwt: Java client usage of JWTs WIP: - this very barely plumbs JWTs into the Java-side n

[kudu-CR] server: link in kudu jwt util

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18470 Change subject: server: link in kudu_jwt_util .. server: link in kudu_jwt_util Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a --- M

[kudu-CR] jwt: introduce MiniOidc

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18473 Change subject: jwt: introduce MiniOidc .. jwt: introduce MiniOidc This patch takes some existing test utilities and encapsulates them in

[kudu-CR] jwt: plumb JWT into mini cluster

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18475 Change subject: jwt: plumb JWT into mini cluster .. jwt: plumb JWT into mini cluster This patch adds options to ExternalMiniCluster to st

[kudu-CR] jwt: add test for fetching JWKS via URL

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18468 Change subject: jwt: add test for fetching JWKS via URL .. jwt: add test for fetching JWKS via URL Change-Id: Ief272c813b62e789d747a88e1f

[kudu-CR] jwt: determine discovery endpoint from token

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18472 Change subject: jwt: determine discovery endpoint from token .. jwt: determine discovery endpoint from token This patch introduces a JWT

[kudu-CR] rpc: plumb JWTs into the RPC layer

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18469 Change subject: rpc: plumb JWTs into the RPC layer .. rpc: plumb JWTs into the RPC layer This patch plumbs JWT verification into our C++

[kudu-CR] jwt: add control points for test binaries

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18476 Change subject: jwt: add control points for test binaries .. jwt: add control points for test binaries This hooks the configurations of t

[kudu-CR] jwt: expose MiniOidc to Kudu test binary

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18474 Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8

[kudu-CR] plumb JWT authentication into clients

2022-05-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18471 Change subject: plumb JWT authentication into clients .. plumb JWT authentication into clients Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439

[kudu-CR] [tools] use thread pool for 'kudu local replica copy from local'

2022-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18448 ) Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local' .. Patch Set 5: (7 comments) http://gerrit.cloudera.or

[kudu-CR] [client] fix toggling fault-tolerance for a scanner

2022-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.or

[kudu-CR] [client] fix toggling fault-tolerance for a scanner

2022-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/184

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

2022-04-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 ) Change subject: [java] Fix a scan bug which will read repetitive rows. .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [test] avoid coredump in socket-test when failing

2022-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18425 ) Change subject: [test] avoid coredump in socket-test when failing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR](gh-pages) Add .asf.yaml

2022-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 ) Change subject: Add .asf.yaml .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18410/1//COMMIT_MSG Commit

[kudu-CR] [tool] Add tool to copy replica from local filesystem

2022-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 ) Change subject: [tool] Add tool to copy replica from local filesystem .. Patch Set 17: Thanks for the contribution! -- To view, visit

[kudu-CR] [tool] Add tool to copy replica from local filesystem

2022-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18374 ) Change subject: [tool] Add tool to copy replica from local filesystem .. [tool] Add tool to copy replica from local filesystem A

[kudu-CR] [tool] Add tool to copy replica from local filesystem

2022-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 ) Change subject: [tool] Add tool to copy replica from local filesystem .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [tool] Add tool to copy replica from local filesystem

2022-04-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 ) Change subject: [tool] Add tool to copy replica from local filesystem .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR](gh-pages) Update website for 1.16.0 release

2022-04-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18406 ) Change subject: Update website for 1.16.0 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18406

[kudu-CR] [tool] Add tool to copy replica from local filesystem

2022-04-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 ) Change subject: [tool] Add tool to copy replica from local filesystem .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command

2022-04-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18394 ) Change subject: [cmake_modules] add '-o /dev/null' to the linker command .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [tools] range rebalancing for 'kudu cluster rebalance'

2022-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 ) Change subject: [tools] range rebalancing for 'kudu cluster rebalance' .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera

[kudu-CR] [tools] range rebalancing for 'kudu cluster rebalance'

2022-04-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 ) Change subject: [tools] range rebalancing for 'kudu cluster rebalance' .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tools] range rebalancing for 'kudu cluster rebalance'

2022-04-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 ) Change subject: [tools] range rebalancing for 'kudu cluster rebalance' .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tools] range rebalancing for 'kudu cluster rebalance'

2022-04-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 ) Change subject: [tools] range rebalancing for 'kudu cluster rebalance' .. Patch Set 4: Code-Review+1 (2 comments) Overall this looks go

[kudu-CR] [tools] add beginning of the key range into TabletSummary

2022-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18356 ) Change subject: [tools] add beginning of the key range into TabletSummary .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] [tools] add beginning of the key range into TabletSummary

2022-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18356 ) Change subject: [tools] add beginning of the key range into TabletSummary .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloud

[kudu-CR] [docs] add notes on running chronyd in local reference mode

2022-03-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18344 ) Change subject: [docs] add notes on running chronyd in local reference mode .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2022-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-3318 [LBM] Runtime compact log container metadata

2022-03-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 ) Change subject: KUDU-3318 [LBM] Runtime compact log container metadata .. Patch Set 12: Thanks for the contribution! -- To view, visit

[kudu-CR] KUDU-3318 [LBM] Runtime compact log container metadata

2022-03-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 ) Change subject: KUDU-3318 [LBM] Runtime compact log container metadata .. Patch Set 12: Verified+1 Code-Review+2 -- To view, visit http

[kudu-CR] KUDU-3318 [LBM] Runtime compact log container metadata

2022-03-22 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3318 [LBM] Runtime compact log container metadata .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17871 To unsubsc

[kudu-CR] [docs] add notes on running chronyd in local reference mode

2022-03-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18344 ) Change subject: [docs] add notes on running chronyd in local reference mode .. Patch Set 1: Code-Review+1 (5 comments) http://gerrit.cl

[kudu-CR] KUDU-3318 [LBM] Runtime compact log container metadata

2022-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 ) Change subject: KUDU-3318 [LBM] Runtime compact log container metadata .. Patch Set 11: Code-Review+2 (4 comments) Thanks for revving t

[kudu-CR](branch-1.16.x) Bump versions in examples to 1.16.0

2022-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18335 ) Change subject: Bump versions in examples to 1.16.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/183

[kudu-CR] [tools] KUDU-3333 Include Table Counts in kudu hms Dryrun

2022-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18280 ) Change subject: [tools] KUDU- Include Table Counts in kudu hms Dryrun .. [tools] KUDU- Include Table Counts in kudu hms D

[kudu-CR] [write throttling-itest] relax threshold to avoid flakiness

2022-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18320 ) Change subject: [write_throttling-itest] relax threshold to avoid flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [tools] run intra-location rebalancing in parallel

2022-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18308 ) Change subject: [tools] run intra-location rebalancing in parallel .. Patch Set 2: Code-Review+2 LGTM. For posterity, it's also worth no

[kudu-CR] [tools] KUDU-3333 Include Table Counts in kudu hms Dryrun

2022-03-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18280 ) Change subject: [tools] KUDU- Include Table Counts in kudu hms Dryrun .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] [tool] Fix rebuild master tool's help infomation

2022-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 ) Change subject: [tool] Fix rebuild master tool's help infomation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] [tool] Fix rebuild master tool's help infomation

2022-03-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18319 ) Change subject: [tool] Fix rebuild master tool's help infomation .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] [tools] KUDU-3333 Table Counts in kudu hms dryrun

2022-03-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18280 ) Change subject: [tools] KUDU- Table Counts in kudu hms dryrun .. Patch Set 1: Code-Review+1 We chatted about this a bit offline. Wou

[kudu-CR] [tablet] add tablet id into trace of a slow write op

2022-03-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18315 ) Change subject: [tablet] add tablet_id into trace of a slow write op .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [tools] run intra-location rebalancing in parallel

2022-03-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18308 ) Change subject: [tools] run intra-location rebalancing in parallel .. Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.or

[kudu-CR] [tools] Support copying unpartitioned table

2022-03-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18318 ) Change subject: [tools] Support copying unpartitioned table .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To view, visit ht

[kudu-CR] [tablet] output more info for long row lock waits

2022-03-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18300 ) Change subject: [tablet] output more info for long row lock waits .. Patch Set 1: Code-Review+2 Thanks for addressing this! -- To view

[kudu-CR] [tools] correct rebalancer's initial status message

2022-03-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18297 ) Change subject: [tools] correct rebalancer's initial status message .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. Patch Set 13: Thanks for the contribution!

[kudu-CR] [thirdparty] build curl without brotli

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18288 ) Change subject: [thirdparty] build curl without brotli .. Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > > Curious, why was this

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. KUDU-3197 [tserver] optimal Schema's

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. Patch Set 12: Code-Review+2 -- To view, vis

[kudu-CR] [thirdparty] build curl without brotli

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18288 ) Change subject: [thirdparty] build curl without brotli .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] [thirdparty] build curl without brotli

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18288 ) Change subject: [thirdparty] build curl without brotli .. Patch Set 2: > Patch Set 2: > > > Curious, why was this problematic before? Or

[kudu-CR] [thirdparty] build curl without brotli

2022-03-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18288 ) Change subject: [thirdparty] build curl without brotli .. Patch Set 2: Code-Review+1 Curious, why was this problematic before? Or is thi

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-03-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/182

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. Patch Set 8: Code-Review+1 (2 comments) htt

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/18275/3/docs/relea

[kudu-CR] [security] avoid allocating string in SimpleAcl::UserAllowed()

2022-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18283 ) Change subject: [security] avoid allocating string in SimpleAcl::UserAllowed() .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.

[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors

2022-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 ) Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors .. Patch Set 2: Code-Review+2 -- To view, visit http://ge

[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors

2022-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 ) Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.c

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/1827

[kudu-CR](branch-1.16.x) [docs] add blurb about automatic master addition

2022-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18279 ) Change subject: [docs] add blurb about automatic master addition .. [docs] add blurb about automatic master addition The steps a

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18275/3/docs/releas

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18275/3/docs/releas

[kudu-CR] [docs] add blurb about automatic master addition

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18278 ) Change subject: [docs] add blurb about automatic master addition .. Patch Set 2: Done. Thanks for the review! -- To view, visit http:/

[kudu-CR](branch-1.16.x) [docs] add blurb about automatic master addition

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18279 Change subject: [docs] add blurb about automatic master addition .. [docs] add blurb about automatic master addition The steps are update

[kudu-CR] [docs] add blurb about automatic master addition

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18278 ) Change subject: [docs] add blurb about automatic master addition .. [docs] add blurb about automatic master addition The steps a

[kudu-CR] [docs] add blurb about automatic master addition

2022-02-25 Thread Andrew Wong (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18278 to review the following change. Change subject: [docs] add blurb about automatic master addition .. [docs] add blurb

[kudu-CR] [security] handle a few unexpected authn token conditions

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18271 ) Change subject: [security] handle a few unexpected authn token conditions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0

2022-02-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/18275/3/docs/relea

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-02-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. Patch Set 5: (5 comments) Sorry for the del

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18269 ) Change subject: [tests] harmonize assertions on the expected status .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...

2022-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18260 ) Change subject: [tool] fix a command bug, cmd: kudu wal dump ... .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] [webserver-test] unify generation of the server's URL

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18254 ) Change subject: [webserver-test] unify generation of the server's URL .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] [webserver] add HSTS header for HTTPS responses

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add HSTS header for HTTPS responses .. Patch Set 2: Code-Review+1 (3 comments) Thanks for addressing this!

[kudu-CR] [util] harmonize random util

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18248 ) Change subject: [util] harmonize random_util .. Patch Set 2: > Patch Set 1: Verified+1 > > For some reason, IWYU wants "kudu/util/int128

[kudu-CR] [util] harmonize random util

2022-02-17 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18248 to look at the new patch set (#2). Change subject: [util] harmonize random_util .. [util] harmonize

[kudu-CR] [util] harmonize random util

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18248 Change subject: [util] harmonize random_util .. [util] harmonize random_util Functions defined in int128_util.h caused ambiguous overload

[kudu-CR] [util] harmonize logging.h

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18247 Change subject: [util] harmonize logging.h .. [util] harmonize logging.h This adds the ::kudu namespace to logging::LogThrottler, to matc

[kudu-CR] [security] harmonize tls handshake.cc

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18246 Change subject: [security] harmonize tls_handshake.cc .. [security] harmonize tls_handshake.cc The first parameter of Socket.Write() is o

[kudu-CR] [security] harmonize updates to mini kdc

2022-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18245 Change subject: [security] harmonize updates to mini_kdc .. [security] harmonize updates to mini_kdc Impala recently rebased their Kudu l

[kudu-CR] [master] fix rare crash on master shutdown

2022-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18239 ) Change subject: [master] fix rare crash on master shutdown .. Patch Set 1: Code-Review+2 Thank you for fixing this! -- To view, visit

[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()

2022-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18238 ) Change subject: [tserver] avoid copying Schema in SplitKeyRange() .. Patch Set 1: Verified+1 Code-Review+2 The test failures seem unrela

[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()

2022-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [tserver] avoid copying Schema in SplitKeyRange() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18238 To unsubscribe,

  1   2   3   4   5   6   7   8   9   10   >