[kudu-CR] rpc: hook up a callback for libev fatal errors

2017-08-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: rpc: hook up a callback for libev fatal errors .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7633 To unsubscribe, visit http:

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

2017-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch .. Patch Set 2: > Thanks for fixing this, MJ. My bad for missing it NP at all, thanks for the pr

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

2017-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7473 Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch .. KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cma

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6623/4/src/kudu/common/wire_protocol.cc File

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6623/4/src/kudu/common/wire_protocol.cc File

[kudu-CR] WIP: Expose a way to set "advanced" non-types scan options

2017-04-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Expose a way to set "advanced" non-types scan options .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6624/4/src/kudu/client/scan_configur

[kudu-CR] WIP: Expose a way to set "advanced" non-types scan options

2017-04-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Expose a way to set "advanced" non-types scan options .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6624/4/src/kudu/client/scan_configu

[kudu-CR] java: add a stress test for short-lived clients

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: java: add a stress test for short-lived clients .. Patch Set 1: Code-Review+1 nice -- To view, visit http://gerrit.cloudera.org:8080/6615 To unsubscribe, visi

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/9/src/kudu/client/scan_batch.h File src/kud

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: Adar, did you have any more feedback? We'll wanna start consuming this API pretty soon. -- To vi

[kudu-CR] KUDU-1962. Fix NPE when master returns SERVER TOO BUSY

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1962. Fix NPE when master returns SERVER_TOO_BUSY .. Patch Set 1: (1 comment) Todd, thanks for putting a fix together quickly http://gerrit.cloudera.org:

[kudu-CR] Change logging for OpenSSL init checking to WARNING from DFATAL

2017-02-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: Change logging for OpenSSL init checking to WARNING from DFATAL .. Change logging for OpenSSL init checking to WARNING from DFATAL Crashing the client process is

[kudu-CR] Change checking for existing OpenSSL init logs at INFO not DFATAL

2017-02-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Change checking for existing OpenSSL init logs at INFO not DFATAL .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6084/1/src/kudu/security/ope

[kudu-CR] Change checking for existing OpenSSL init logs at INFO not DFATAL

2017-02-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6084 Change subject: Change checking for existing OpenSSL init logs at INFO not DFATAL .. Change checking for existing OpenSSL init logs at

[kudu-CR] KUDU-1881: Deserializing scan token should check nullability of column

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1881: Deserializing scan token should check nullability of column .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6040 To

[kudu-CR] KUDU-1738. Allow users of the client to disable OpenSSL initialization

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization .. Patch Set 4: (1 comment) I think this API should work, though Impala will have to ma

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-14 Thread Matthew Jacobs (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5986 to look at the new patch set (#5). Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. KUD

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5986 to look at the new patch set (#4). Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. KUDU-1870: Fix B

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh File thirdp

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5986 to look at the new patch set (#3). Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. KUDU-1870: Fix B

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh File thirdp

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5986 to look at the new patch set (#2). Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. KUDU-1870: Fix B

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh File thirdp

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc File src

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh File thirdp

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: If it's possible to avoid the extra flag, that would be awesome, it makes it harder to understa

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 1: thanks, yeah, I took a look and figured it was unrelated, also looked at the build log to see the

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5986 Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. KUDU-1870: Fix Boost build to respect CC/CXX Boost doesn't respect the

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc File src

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (3 comments) thanks! http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/common/timestamp.cc F

[kudu-CR] thirdparty: patch cmake on SLES 12 SP0 to avoid hanging

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake on SLES 12 SP0 to avoid hanging .. Patch Set 2: Code-Review+2 Thanks, Adar -- To view, visit http://gerrit.cloudera.org:8080/5857 To u

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > > > This should only affect the cmake build itself, i.e. > thir

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > > This should only affect the cmake build itself, i.e. thirdpart

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: This should only affect the cmake build itself, i.e. thirdparty.

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: this happens somewhat regularly, maybe 25% of the time when we bui

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: @Todd, why does this add 5s to rebuild? is thirdparty always rebui

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5733/3/docs/kudu_impala_integration.ado

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5775/1/src/kudu/client/client.h File src/kudu/cli

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5733/2/docs/kudu_impala_integration.adoc Fil

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc Fi

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc Fi

[kudu-CR] KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging

2016-12-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging .. Patch Set 1: Casting a non-binding vote for inclusion in 1.2 :) -- To view, visit ht

[kudu-CR] KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging

2016-12-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5443 To

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 1: (3 comments) Thanks! Unit tests? http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/clie

[kudu-CR] KUDU-1749. Allow callers to disable SASL initialization

2016-11-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5120/1//COMMIT_MSG Commit Message: PS1

[kudu-CR] KUDU-1749. Allow callers to disable SASL initialization

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization .. Patch Set 1: (1 comment) Thanks, Todd! http://gerrit.cloudera.org:8080/#/c/5120/1//COMMIT_MSG Commi

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: Alexey, thanks for doing this. As we discussed, one of the issues Impala faces is that the er

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File src

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4173 To unsubscribe, visit

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1, L

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1, L

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc: PS1,

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc: PS1,

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc: PS1,