[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-10-31 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#50). Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata .

[kudu-CR] [clock] KUDU-3521 fix crash when clock is synchronized by PTPd

2023-10-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20626 ) Change subject: [clock] KUDU-3521 fix crash when clock is synchronized by PTPd .. Patch Set 2: Code-Review+2 LGTM -- To view, visit h

[kudu-CR] Minor refactoring on kudu-tool-test

2023-10-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactoring on kudu-tool-test .. Minor refactoring on kudu-tool-test This patch refactors the code in kud

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-10-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-10-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 17: Code-Review-1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-10-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/20282/

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. [KUDU-3447] Limit tablets copying speed Copying tablets from one clu

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-10-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org

[kudu-CR] Minor refactoring on kudu-tool-test

2023-10-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Minor refactoring on kudu-tool-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20597 To unsubscribe, visit http:/

[kudu-CR] Minor refactoring on kudu-tool-test

2023-10-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactoring on kudu-tool-test .. Patch Set 4: Verified+1 The failed tests are not related: DDLDuringRebalancingTe

[kudu-CR] Minor refactoring on kudu-tool-test

2023-10-28 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20597 to look at the new patch set (#4). Change subject: Minor refactoring on kudu-tool-test .

[kudu-CR] Minor refactoring on kudu-tool-test

2023-10-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactoring on kudu-tool-test .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/20597/3//COMMIT_M

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 23: Verified+1 Code-Review+2 The failed test is not related: Leade

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [KUDU-3447] Limit tablets copying speed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit ht

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 23: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/19479/22/src/

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20621 ) Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch fo

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [thirdparty] Fix the curl missing patch .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20621 To unsubscribe, visit ht

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20621 ) Change subject: [thirdparty] Fix the curl missing patch .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20621 to review the following change. Change subject: [thirdparty] Fix the curl missing patch .. [thirdpart

[kudu-CR] [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20620 ) Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch fo

[kudu-CR] [thirdparty] Fix the curl missing patch

2023-10-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20620 Change subject: [thirdparty] Fix the curl missing patch .. [thirdparty] Fix the curl missing patch This is a follow-up patch for commit:

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactors on kudu-tool-test .. Patch Set 3: Verified+1 The failed test is not related: CatalogManagerTskITest.Lea

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Minor refactors on kudu-tool-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20597 To unsubscribe, visit http://g

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [KUDU-3447] Limit tablets copying speed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit ht

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 20: Verified+1 Code-Review+2 The failed tests are not related: Cli

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-10-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 49: > Patch Set 47: > > (1 comment) Done, see https

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-10-21 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#49). Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata .

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20592 ) Change subject: refactor: move SetEncryptionFlags to constructors .. refactor: move SetEncryptionFlags to constructors SetEncry

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-19 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20597 to look at the new patch set (#3). Change subject: Minor refactors on kudu-tool-test .. Minor refactors on kudu-too

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 20: Verified+1 Code-Review+2 -- To view, v

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19949 T

[kudu-CR] WIP Make --encrypt data at rest configurable for kudu-tool-test

2023-10-19 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20597 to look at the new patch set (#2). Change subject: WIP Make --encrypt_data_at_rest configurable for kudu-tool-test .

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: refactor: move SetEncryptionFlags to constructors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20592 To unsubscribe

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20592 ) Change subject: refactor: move SetEncryptionFlags to constructors .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20592 ) Change subject: refactor: move SetEncryptionFlags to constructors .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/205

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-19 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20592 to look at the new patch set (#2). Change subject: refactor: move SetEncryptionFlags to constructors ..

[kudu-CR] WIP Make --encrypt data at rest configurable for kudu-tool-test

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20597 Change subject: WIP Make --encrypt_data_at_rest configurable for kudu-tool-test .. WIP Make --encrypt_data_at_rest configurable for kudu-

[kudu-CR] Small refactor to use DirManager::WaitOnClosures()

2023-10-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20596 Change subject: Small refactor to use DirManager::WaitOnClosures() .. Small refactor to use DirManager::WaitOnClosures() Change-Id: Ib2f

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 18: Code-Review+1 (1 comment) http://gerri

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20592 ) Change subject: refactor: move SetEncryptionFlags to constructors .. Patch Set 1: Verified+1 The failed test CatalogManagerTskITest.Lea

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: refactor: move SetEncryptionFlags to constructors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20592 To unsubscribe

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20592 Change subject: refactor: move SetEncryptionFlags to constructors .. refactor: move SetEncryptionFlags to constructors SetEncryptionFlag

[kudu-CR] KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20582 ) Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 18: Code-Review+1 The failed test is related. -- To view, visit

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: Code-Review+1 (6 comments) http://gerr

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-10-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#48). Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata .

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. KUDU-3371 [fs] make LBMCorruptor a base class This patch has n

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, vi

[kudu-CR](branch-1.17.x) [thirdparty] bump curl version up to 8.4.0

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20586 ) Change subject: [thirdparty] bump curl version up to 8.4.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [ranger] disable Tomcat's shutdown port

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20583 ) Change subject: [ranger] disable Tomcat's shutdown port .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [thirdparty] bump curl version up to 8.4.0

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20575 ) Change subject: [thirdparty] bump curl version up to 8.4.0 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20575/3/thi

[kudu-CR] [thirdparty] bump curl version up to 8.4.0

2023-10-17 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20575 to look at the new patch set (#4). Change subject: [thirdparty] bump curl version up to 8.4.0 .. [th

[kudu-CR] [ranger] disable Tomcat's shutdown port

2023-10-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20583 ) Change subject: [ranger] disable Tomcat's shutdown port .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/19479/17/src/

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/20504/2

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-16 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20504 to look at the new patch set (#6). Change subject: KUDU-3371 [fs] make LBMCorruptor a base class ...

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Removed Code-Review+2 by Yingchun Lai -- To view, visit http://gerrit.cloudera.org:8080/19949 To

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: Code-Review+2 -- To view, visit http:/

[kudu-CR] [thirdparty] bump curl version up to 8.4.0

2023-10-15 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20575 to look at the new patch set (#3). Change subject: [thirdparty] bump curl version up to 8.4.0 .. [th

[kudu-CR] [thirdparty] bump curl version up to 8.4.0

2023-10-15 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20575 to look at the new patch set (#2). Change subject: [thirdparty] bump curl version up to 8.4.0 .. [th

[kudu-CR](branch-1.17.x) [CMakeLists] clean-up ARCH NAME conditions for x86 64

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20570 ) Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR](branch-1.17.x) [util] clean up libunwind headers for aarch64

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20572 ) Change subject: [util] clean up libunwind headers for aarch64 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR](branch-1.17.x) [gutil] fix ASAN warning in CountOnes()

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20573 ) Change subject: [gutil] fix ASAN warning in CountOnes() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR](branch-1.17.x) [util] redirect stderr to /dev/null during AVX2 detection

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20571 ) Change subject: [util] redirect stderr to /dev/null during AVX2 detection .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR](branch-1.17.x) [arm64] implement with native NEON instructions

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20576 ) Change subject: [arm64] implement with native NEON instructions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR](branch-1.17.x) [thirdparty] build gperftools with libunwind support

2023-10-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20569 ) Change subject: [thirdparty] build gperftools with libunwind support .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] [thirdparty] bump curl version up to 8.4.0

2023-10-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20575 Change subject: [thirdparty] bump curl version up to 8.4.0 .. [thirdparty] bump curl version up to 8.4.0 Change-Id: I7ba976899bb23d95bff

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/19479/17/src

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, vi

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, vis

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, vis

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20504 to look at the new patch set (#5). Change subject: KUDU-3371 [fs] make LBMCorruptor a base class ...

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20504/3/

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-12 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20504 to look at the new patch set (#4). Change subject: KUDU-3371 [fs] make LBMCorruptor a base class ...

[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE

2023-10-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 5: Code-Review+2 Thanks for the contribution! -- To vie

[kudu-CR] [server]KUDU-3513 Decrease default value of —log container preallocate bytes

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20489 ) Change subject: [server]KUDU-3513 Decrease default value of —log_container_preallocate_bytes .. Patch Set 1: (1 comment) http://gerri

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/20282/1

[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [CMakeLists] clean-up ARCH NAME conditions for x86 64

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20552 ) Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, vi

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20504/2

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-10-10 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Alexey Serbin, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20504 to look at the new patch set (#3). Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-09-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/20282/

[kudu-CR] [master] fix mistake in status message for SOFT DELETED tables

2023-09-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20502 ) Change subject: [master] fix mistake in status message for SOFT_DELETED tables .. Patch Set 1: Code-Review+2 -- To view, visit http://

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-09-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 ) Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. Patch Set 2: > Patch Set 1: > > (6 comments) Done -- To view, visit

[kudu-CR] KUDU-3371 [fs] make LBMCorruptor a base class

2023-09-23 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20504 to look at the new patch set (#2). Change subject: KUDU-3371 [fs] make LBMCorruptor a base class .. KUDU-

[kudu-CR] WIP KUDU-3371 [fs] make LBMCorruptor a base class

2023-09-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20504 Change subject: WIP KUDU-3371 [fs] make LBMCorruptor a base class .. WIP KUDU-3371 [fs] make LBMCorruptor a base class Change-Id: I5a1f2

[kudu-CR] [multi-tenancy] add tenancy metadata on master

2023-09-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20343 ) Change subject: [multi-tenancy] add tenancy metadata on master .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-3498 Scanner keeps alive in periodically

2023-09-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 ) Change subject: KUDU-3498 Scanner keeps alive in periodically .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/20282/6

[kudu-CR] [multi-tenancy] add tenancy metadata on master

2023-09-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20343 ) Change subject: [multi-tenancy] add tenancy metadata on master .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] [rpc] detect HTTP client on RPC port

2023-09-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20493 ) Change subject: [rpc] detect HTTP client on RPC port .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-09-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/19479/9/src/k

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-09-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19479/5//COMM

[kudu-CR] [examples] Bump up Kudu version to 1.17.0 for examples

2023-09-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20479 ) Change subject: [examples] Bump up Kudu version to 1.17.0 for examples .. Patch Set 2: > Patch Set 1: > > Did you verify that the examp

[kudu-CR] [docs] Add 1.17.0 release notes to previous release notes

2023-09-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20480 ) Change subject: [docs] Add 1.17.0 release notes to previous release notes .. [docs] Add 1.17.0 release notes to previous release

<    1   2   3   4   5   6   7   8   9   10   >