[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro to LOG and return on a non-OK status We often see the following pattern: Status

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4927 To unsubscribe, visit

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4927/5//COMMIT_MSG Commit Message:

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#6). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4927/5//COMMIT_MSG Commit Message: PS5, Line

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#5). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#3). Change subject: Add a macro to LOG and return on a non-OK status .. Add a

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG Commit Message: >

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG Commit Message: Nit: if