[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-24 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Abandoned Todd and I discussed this offline. Given the impact of FS_IOC_FIEMAP, I ended up i

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 7: > If we're considering just unpunched holes, then yes. But, if the con

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 7: > > Right, we talked about this before. Assuming an "expensive > repai

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 7: > Right, we talked about this before. Assuming an "expensive repair" t

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#7). Change subject: log block manager: use extent maps to decide whether to truncate containers ..

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 6: > Yea, I think it's quite reasonable to only do so in a "fs check > --

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 6: Yea, I think it's quite reasonable to only do so in a "fs check --repa

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 6: > Have you done any tests of how this affects startup time, > particul

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 6: Have you done any tests of how this affects startup time, particularly

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-13 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#6). Change subject: log block manager: use extent maps to decide whether to truncate containers ...

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6585/3/src/ku

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-10 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#4). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6585/3/src/kudu/fs/lo

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6585/3/src/k

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#3). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#2). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-06 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6585 to review the following change. Change subject: log block manager: use extent maps to decide whether to truncate containers .