---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36879/#review93253
---
Patch looks great!
Reviews applied: [36879]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review93254
---
First pass over non-test code. Looks good. I'll give it a closer
On July 27, 2015, 8:13 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/http.cpp, line 927
https://reviews.apache.org/r/36847/diff/1/?file=1022344#file1022344line927
This todo looks inconsistent with the way `GET` handler is written.
Let's create a clean-up JIRA ticket.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 9:49 a.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36883/#review93269
---
Patch looks great!
Reviews applied: [36883]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review93265
---
I think the checklist could benefit from some organization, at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36883/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36883/#review93266
---
Ship it!
Ship It!
- Joerg Schad
On July 28, 2015, 9:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/#review93252
---
3rdparty/libprocess/include/process/process.hpp (line 382)
:10.0.77.243,
id:20150728-165830-4081909770-5050-64014,
ip:4081909770,
pid:master@10.0.77.243:5050,
port:5050,
version:0.24.0
}
```
Not sure why Reviewbot failed, but the tests all passed:
```
[--] Global test environment tear-down
[==] 684 tests from 97 test cases ran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---
(Updated July 29, 2015, 1:01 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/#review93364
---
Ship it!
Ship It!
- Jie Yu
On July 28, 2015, 10:45 p.m., Ben
On July 29, 2015, 12:25 a.m., Marco Massenzio wrote:
Ship It!
as they say, hindsight is 20/20 :)
Thanks for the deep investigative work!
- Marco
---
This is an automatically generated e-mail. To reply, visit:
:{
hostname:10.0.77.243,
ip:10.0.77.243,
port:5050
},
hostname:10.0.77.243,
id:20150728-165830-4081909770-5050-64014,
ip:4081909770,
pid:master@10.0.77.243:5050,
port:5050,
version:0.24.0
}
```
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/
---
Review request for mesos and Marco Massenzio.
Bugs: MESOS-3168
On July 28, 2015, 9:12 p.m., Vinod Kone wrote:
Found the bug. https://issues.apache.org/jira/browse/MESOS-3168
I'll prep a fix for it to unblock you.
Sweet! Thanks!
- Marco
---
This is an automatically generated e-mail. To
:10.0.77.243,
id:20150728-165830-4081909770-5050-64014,
ip:4081909770,
pid:master@10.0.77.243:5050,
port:5050,
version:0.24.0
}
```
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/#review93371
---
Ship it!
Ship It!
- Marco Massenzio
On July 29, 2015, 12:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93271
---
Patch looks great!
Reviews applied: [36847]
All tests passed.
-
On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote:
Also, I think we need a doppelgänger for the method in the `streaming`
namespace.
Are you sure? For delete we are not streaming any data...
- Joerg
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36883/#review93283
---
Ship it!
Ship It!
- Till Toenshoff
On July 28, 2015, 9:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 12:39 p.m.)
Review request for mesos and Alexander
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 507
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line507
The code until this line is basically request validation and
authorization. Though it's not how we do it now, do you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93297
---
Ship it!
Ship It!
- Jan Schlicht
On July 28, 2015, 3:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 1:13 p.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
---
(Updated July 28, 2015, 1:48 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 28, 2015, 4:04 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93288
---
src/tests/fetcher_cache_tests.cpp (line 368)
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 1325-1332
https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325
Why do we need to recover resources for unreserve?
Michael Park wrote:
If reserved resources are offered, we
On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, line 749
https://reviews.apache.org/r/35702/diff/6/?file=989449#file989449line749
I think reserve is too abstract and may collide with future actions
(think quota). How about `/dynamic/reserve`?
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 1291
https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1291
As in https://reviews.apache.org/r/35702/, I suggest we extract
validation into a separate function.
Michael Park
On July 2, 2015, 3:39 p.m., Alexander Rukletsov wrote:
A high level question: do operators have the possibility to get a list of
all dynamic reservations? I think about a situation, when a framework made
some reservations and then quit, an operator wants to clean up those
On July 8, 2015, 5:59 p.m., Alexander Rukletsov wrote:
include/mesos/master/allocator.hpp, lines 133-135
https://reviews.apache.org/r/35947/diff/1/?file=993649#file993649line133
And we introduce a libprocess dependency into `Allocator` interface. I
think it's a prominent step,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93295
---
Patch looks great!
Reviews applied: [36889]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93294
---
src/master/http.cpp (line 242)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587/
---
(Updated July 28, 2015, 9:38 a.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93385
---
LGTM minus some nit comments.
src/tests/master_tests.cpp (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587/
---
(Updated July 28, 2015, 10:49 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587/
---
(Updated July 28, 2015, 10:49 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93298
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93299
---
Bad patch!
Reviews applied: [36847]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 4:14 p.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93300
---
Patch looks great!
Reviews applied: [36773]
All tests passed.
-
On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote:
Also, I think we need a doppelgänger for the method in the `streaming`
namespace.
Joerg Schad wrote:
Are you sure? For delete we are not streaming any data...
I think we do it implicitly anyway (see
On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 447
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line447
Not directly related to endpoints, but to dynamic reservations in
general. Do you think it makes sense to bookkeep
On July 28, 2015, 11:42 a.m., Joerg Schad wrote:
docs/fetcher-cache-internals.md, line 107
https://reviews.apache.org/r/36773/diff/3/?file=1022381#file1022381line107
removes the *most* recently used first
Sorry meant something along the lines: Cache eviction removes the cache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 28, 2015, 2:16 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
---
(Updated July 28, 2015, 12:52 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93272
---
docs/fetcher-cache-internals.md (line 107)
On July 28, 2015, 1:42 p.m., Joerg Schad wrote:
src/slave/containerizer/fetcher.cpp, line 987
https://reviews.apache.org/r/36773/diff/3/?file=1022383#file1022383line987
Should we put a comment above the function saying that it is LRU based?
Yes, we should!
On July 28, 2015, 1:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93287
---
Patch looks great!
Reviews applied: [36773]
All tests passed.
-
in ZK that the data was correct JSON:
```
{
address:{
hostname:10.0.77.243,
ip:10.0.77.243,
port:5050
},
hostname:10.0.77.243,
id:20150728-165830-4081909770-5050-64014,
ip:4081909770,
pid:master@10.0.77.243:5050,
port:5050,
version:0.24.0
}
```
Not sure
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 3:41 a.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93386
---
Bad patch!
Reviews applied: [36810, 36811]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36868/#review93388
---
Why wasn't [r36869](https://reviews.apache.org/r/36869) just
:10.0.77.243,
port:5050
},
hostname:10.0.77.243,
id:20150728-165830-4081909770-5050-64014,
ip:4081909770,
pid:master@10.0.77.243:5050,
port:5050,
version:0.24.0
}
```
Not sure why Reviewbot failed, but the tests all passed:
```
[--] Global test environment tear-down
[==] 684
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---
(Updated July 29, 2015, 5:19 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 28, 2015, 4:41 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/#review93316
---
Ship it!
Please do a rebase. The patch does not apply.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 4:26 p.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36755/#review93313
---
Ship it!
Ship It!
- Jie Yu
On July 28, 2015, 12:02 a.m., Kapil
On July 27, 2015, 11:38 p.m., Ben Mahler wrote:
src/master/master.cpp, line 1850
https://reviews.apache.org/r/32961/diff/4/?file=927192#file927192line1850
Anand discovered that we shouldn't be calling this in the
FrameworkErrorMessage case below, where we drop the message. Looks
On July 28, 2015, 5:58 a.m., Adam B wrote:
Did you test this with java enabled as well? What about without
`--with-protobuf=`? All four combinations still need to compile pass the
unit tests.
I only run it with --disable-java and --with_protobuf, let me test other 3
combinations.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36891/
---
(Updated July 28, 2015, 4:42 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93311
---
Patch looks great!
Reviews applied: [36889]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36810/#review93317
---
Patch looks great!
Reviews applied: [36810]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93307
---
Ship it!
Ship It!
- Alexander Rukletsov
On July 28, 2015, 4:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated July 28, 2015, 4:45 p.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/
---
(Updated July 28, 2015, 1:39 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36891/
---
Review request for mesos.
Repository: mesos
Description
---
Don't check
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/#review93314
---
Ship it!
Ship It!
- Jie Yu
On July 28, 2015, 12:02 a.m., Kapil
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 515-516
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line515
It looks like we actually have the role, but it's buried in resources.
Do you envision having resources collection
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/
---
(Updated July 28, 2015, 1:41 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/
---
(Updated July 28, 2015, 11:02 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36892/#review93325
---
Ship it!
Ship It!
- Timothy Chen
On July 28, 2015, 6:46 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93326
---
Patch looks great!
Reviews applied: [36847]
All tests passed.
-
On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 447
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line447
Not directly related to endpoints, but to dynamic reservations in
general. Do you think it makes sense to bookkeep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93320
---
Bad patch!
Reviews applied: [36891]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review93327
---
Ship it!
- Timothy Chen
On July 27, 2015, 1:56 p.m., Jojy
On July 28, 2015, 3:17 a.m., Adam B wrote:
docs/committer-candidate-checklist.md, line 9
https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line9
I'm not convinced these `input type=text/` will actually show up on
the website, or even github.
Let's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36892/
---
Review request for mesos, Kapil Arya, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review93330
---
Patch looks great!
Reviews applied: [36197]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review93329
---
I notice there are no new tests added for this, can you add a test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/#review93331
---
Ship it!
src/master/master.cpp (line 4841)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
---
Great first patch. Thanks for updating FrameworkInfo on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated July 28, 2015, 9:03 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/
---
(Updated July 28, 2015, 9:06 p.m.)
Review request for mesos, Adam B, Benjamin
On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, line 749
https://reviews.apache.org/r/35702/diff/6/?file=989449#file989449line749
I think reserve is too abstract and may collide with future actions
(think quota). How about `/dynamic/reserve`?
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 1325-1332
https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325
Why do we need to recover resources for unreserve?
Michael Park wrote:
If reserved resources are offered, we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93347
---
Found the bug. https://issues.apache.org/jira/browse/MESOS-3168
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/
---
Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/#review93367
---
Patch looks great!
Reviews applied: [36898]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93339
---
Ship it!
make check with libev and libevent on OSX
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36820/#review93355
---
Ship it!
Ship It!
- Michael Park
On July 26, 2015, 4:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36820/#review93356
---
Ship it!
Ship It!
- Adam B
On July 26, 2015, 9:51 a.m., Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35361/#review93360
---
Ship it!
Thanks a lot Michael! Sorry this slipped through the
96 matches
Mail list logo
