---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review95410
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 13, 2015, 9:19 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/#review95412
---
Patch looks great!
Reviews applied: [37475]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated Aug. 14, 2015, 11:29 a.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95411
---
Ship it!
src/tests/fault_tolerance_tests.cpp (line 1834)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/#review95396
---
Patch looks great!
Reviews applied: [37423, 37424, 37417, 37416,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/#review95393
---
Patch looks great!
Reviews applied: [37414]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37471/#review95392
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 14, 2015, 5:54 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
---
(Updated Aug. 14, 2015, 8:17 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
---
(Updated Aug. 14, 2015, 8:20 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/#review95405
---
Patch looks great!
Reviews applied: [37415]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 14, 2015, 2:43 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-3261
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37488/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37490/
---
(Updated Aug. 14, 2015, 8:05 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/
---
(Updated Aug. 14, 2015, 8:23 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37488/#review95464
---
Patch looks great!
Reviews applied: [37488]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37490/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-3254
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37491/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3263
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 14, 2015, 5:28 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37487/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3262
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37382/#review95455
---
src/slave/containerizer/provisioners/backend.hpp (line 49)
On Aug. 14, 2015, 12:12 p.m., James DeFelice wrote:
failing unit test from mesos built bot seems completely unrelated (evil
agent!):
```
../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure
Value of: response.get().status
Actual: 202 Accepted
Expected:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37382/
---
(Updated Aug. 14, 2015, 10:51 a.m.)
Review request for mesos, Lily Chen, Ian
On Aug. 12, 2015, 1:45 a.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/backend.hpp, line 48
https://reviews.apache.org/r/37382/diff/1/?file=1038090#file1038090line48
Should we just use Path here?
Path is still hard to use in an interface particularly when it comes to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/#review95459
---
Ship it!
Per Greg, the underlying issue will be tracked here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/#review95460
---
Ship it!
Per Greg, the underlying issue will be tracked here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95457
---
Patch looks great!
Reviews applied: [37426, 37427]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/#review95435
---
Bad patch!
Reviews applied: [37479]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/#review95448
---
Ship it!
I'll fix these up and commit.
src/slave/main.cpp (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/#review95490
---
Patch looks great!
Reviews applied: [37489]
All tests passed.
-
On Aug. 14, 2015, 6:15 p.m., Jie Yu wrote:
src/slave/containerizer/provisioners/backend.hpp, lines 55-57
https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55
Hum, what do yo mean here?
I think the backend should be container aware. I.e., we should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37490/
---
(Updated Aug. 14, 2015, 10 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37491/#review95485
---
Patch looks great!
Reviews applied: [37491]
All tests passed.
-
On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote:
src/slave/containerizer/provisioners/backend.hpp, lines 55-57
https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55
Hum, what do yo mean here?
I think the backend should be container aware. I.e., we should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37490/#review95480
---
Patch looks great!
Reviews applied: [37490]
All tests passed.
-
On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote:
[mmm turns out that it matters WHICH boxes you put your general comments in :)
- copied here, as they make sense *before* the nitpicking that follows]
Again, sorry it's taken so long to get round to doing this review and s
many
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3267
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/
---
Review request for mesos, Joris Van Remoortere and Till Toenshoff.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37382/#review95471
---
Patch looks great!
Reviews applied: [37382]
All tests passed.
-
On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote:
src/slave/containerizer/provisioners/backend.hpp, lines 55-57
https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55
Hum, what do yo mean here?
I think the backend should be container aware. I.e., we should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review95473
---
src/examples/java/TestPersistentVolumeFramework.java (line 34)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---
(Updated Aug. 15, 2015, 12:46 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---
Review request for mesos.
Repository: mesos
Description
---
Docker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/#review95494
---
Ship it!
LGTM
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36125/#review95501
---
After @vinodkone (correct) comments, there has been no activity on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36127/#review95500
---
Is this patch still needed? both this and the associated Jira have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
---
(Updated Aug. 15, 2015, 2:02 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
---
(Updated Aug. 15, 2015, 12:41 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---
(Updated Aug. 15, 2015, 12:54 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---
(Updated Aug. 15, 2015, 12:55 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/
---
(Updated Aug. 15, 2015, 1:27 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37246/
---
(Updated Aug. 15, 2015, 12:44 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/#review95504
---
Patch looks great!
Reviews applied: [37493]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/
---
(Updated Aug. 15, 2015, 2:13 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/#review95505
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2015, 2:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---
Review request for mesos.
Repository: mesos
Description
---
Move docker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/#review95498
---
This has not been touched in more than a month.
Should it be
On Aug. 14, 2015, 12:21 p.m., Guangya Liu wrote:
Code looks good, but pls check what is wrong with the build
Solved! There is an issue in the apply-review.sh. The script crashes because my
name has é. After I changed my name in the review board the script runs fine
- Jose Guilherme
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/#review95508
---
Patch looks great!
Reviews applied: [37479]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---
(Updated Aug. 15, 2015, 12:38 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---
(Updated Aug. 15, 2015, 12:39 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---
(Updated Aug. 15, 2015, 12:39 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---
(Updated Aug. 15, 2015, 12:40 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/#review95495
---
Patch looks great!
Reviews applied: [37494]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/
---
(Updated 八月 15, 2015, 1:44 a.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review95503
---
what's the status of this one? Should it be closed/discarded?
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95408
---
Ship it!
These mini issues can easily be fixed while committing.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95409
---
src/master/http.cpp (line 239)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95417
---
failing unit test from mesos built bot seems completely unrelated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37468/#review95418
---
Code looks good, but pls check what is wrong with the build
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37445/#review95419
---
Ship it!
Ship It!
- Guangya Liu
On 八月 13, 2015, 9:58 p.m., Neil
On Aug. 14, 2015, 1:49 p.m., Alexander Rojas wrote:
src/tests/fault_tolerance_tests.cpp, line 1834
https://reviews.apache.org/r/37443/diff/4/?file=1039554#file1039554line1834
Line length is 81 characters.
James DeFelice wrote:
assuming that 80 is the limit? is there a common
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated Aug. 14, 2015, 11:58 a.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/
---
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/#review95407
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 14, 2015, 10:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/
---
(Updated Aug. 14, 2015, 10:34 a.m.)
Review request for mesos and Benjamin
77 matches
Mail list logo
