Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/ --- (Updated Oct. 22, 2015, 10:48 a.m.) Review request for mesos, Artem

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review103637 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 31 > > > > > > Just so I catch it before it comes up: this is new code that

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103613 --- src/master/master.hpp (lines 883 - 884)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On 十月 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 839 > > > > > > what about "return quotaHandler.create(request)" > > Joerg Schad wrote: > Wanted to make names consistent. >

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review103546 --- Patch looks great! Reviews applied: [39005, 39006] All tests

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/ --- (Updated Oct. 22, 2015, 7:47 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 22, 2015, 7:51 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

> On Oct. 21, 2015, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/src/io.cpp, line 27 > > > > > > This should at the very end of stout includes. Let's keep lexicographical sort with an ASCII code page (which

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Oct. 22, 2015, 7:50 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 839 > > > > > > what about "return quotaHandler.create(request)" > > Joerg Schad wrote: > Wanted to make names consistent. >

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 21, 2015, 10:23 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 41 > > > > > > Can we fix the #include order as mentioned in the followup RR? Let's keep

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 22, 2015, 7:46 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote: > > Can you also sync this with the V1 API? (If so, I'll remove that section > > from this: https://reviews.apache.org/r/39502 ). > > Connor Doyle wrote: > Yes, I will update the v1 proto file as well. Thanks for the reminder. Updated.

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103611 --- Bad patch! Reviews applied: [39531] Failed command:

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103607 --- Bad patch! Reviews applied: [39531] Failed command:

Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Oct. 22, 2015, 6:24 p.m.) Review request for mesos, Artem

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/#review103636 ---

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103644 --- Patch looks great! Reviews applied: [39531, 39502] All tests

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/ --- (Updated Oct. 22, 2015, 5:40 p.m.) Review request for mesos, Artem

Review Request 39559: Windows: Implemented `os::mkdtemp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

> On Oct. 22, 2015, 4:59 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp, lines 17-21 > > > > > > Nit: Can you flip the `#ifndef`? No need to negate the conditional if > >

Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3733

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 22, 2015, 2:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review103556 --- Patch looks great! Reviews applied: [39005, 39008] All tests

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103650 --- include/mesos/mesos.proto (lines 1395 - 1409)

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review103655 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (line

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- (Updated Oct. 22, 2015, 8:46 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review103653 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 22, 2015, 8:48 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39421: Add agent version to /master/slaves endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39421/#review103661 --- Ship it! src/master/http.cpp (line 298)

Re: Review Request 39569: Added output operator for Executor struct in agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39569/#review103672 --- src/slave/slave.cpp (line 1974)

Review Request 39569: Added output operator for Executor struct in agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39569/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103660 --- src/tests/scheduler_tests.cpp (line 1001)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103656 --- support/apply-reviews.py (line 25)

Re: Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/#review103664 --- src/master/http.cpp (line 534)

Re: Review Request 39569: Added output operator for Executor struct in agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39569/ --- (Updated Oct. 22, 2015, 11:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39421: Add agent version to /master/slaves endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39421/ --- (Updated Oct. 23, 2015, 12:17 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39421: Add agent version to /master/slaves endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39421/#review103703 --- Patch looks great! Reviews applied: [39421] All tests passed. -

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 11:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39385: Fixed link conversion regexp in website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/ --- (Updated Oct. 22, 2015, 11:03 p.m.) Review request for mesos, Adam B and Dave

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-180 > > > > > > Dumb question -- could we have used `JSON::Protobuf()` instead? Hey Kapil, I'll try it out. - Connor

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 11:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39385: Fixed link conversion regexp in website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/#review103692 --- Patch looks great! Reviews applied: [39385] All tests passed. -

Re: Review Request 39569: Added output operator for Executor struct in agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39569/#review103693 --- Ship it! Will land this shortly. src/slave/slave.hpp (line 698)

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 23, 2015, 1:39 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 11:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-180 > > > > > > Dumb question -- could we have used `JSON::Protobuf()` instead? > > Connor Doyle wrote: > Hey Kapil, I'll try

Re: Review Request 39569: Added output operator for Executor struct in agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39569/ --- (Updated Oct. 22, 2015, 11:26 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > include/mesos/mesos.proto, lines 1395-1409 > > > > > > I should have noticed it earlier, but does it make sense to make > > IPAddress a top level message? Nik?

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103690 --- Wow! Awesome documentation work! A few suggestions below. Mainly:

Re: Review Request 39538: Windows: Moved `os::touch` to its own file, `stout/os/touch.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39538/#review103698 --- Ship it! Confirmed that touch logic did not change. - Joseph Wu

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- (Updated Oct. 23, 2015, 1:34 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote: > > Curious if we want to scope these for the whole files? Might be a bit hard > > to scope this correctly over time. True that - also I noticed that I can totally not include the clang specific pragma as clang does pick up the GCC specifics

Review Request 39474: Make the Command Scheduler use the HTTP Scheduler Library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/ --- Review request for mesos. Repository: mesos Description --- WIP: Make

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/ --- (Updated Oct. 22, 2015, 10:02 a.m.) Review request for mesos and Michael Park.

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103539 --- src/master/master.hpp (line 878)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103583 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999,

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103587 --- src/master/quota_handler.cpp (line 162)

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103710 --- src/tests/scheduler_tests.cpp (lines 999 - 1008)

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/ --- (Updated Oct. 23, 2015, 4:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/ --- (Updated Oct. 23, 2015, 4:25 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/ --- (Updated Oct. 23, 2015, 2:01 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated Oct. 23, 2015, 2:32 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/#review103706 --- Patch looks great! Reviews applied: [39432] All tests passed. -

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103711 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Re: Review Request 39548: SchedulerTest.Suppress is flaky

> On 十月 23, 2015, 3:53 a.m., Anand Mazumdar wrote: > > src/tests/scheduler_tests.cpp, lines 999-1008 > > > > > > Wondering, why did you change order here i.e. move this piece of code > > up ? > > > > Now,

Re: Review Request 39474: Make the Command Scheduler use the HTTP Scheduler Library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review103565 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Oct. 22, 2015, 2:57 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 22, 2015, 3:01 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review103572 --- Patch looks great! Reviews applied: [39230] All tests passed. -

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103566 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Oct. 22, 2015, 2:57 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39548: SchedulerTest.Suppress is flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated 十月 23, 2015, 5:29 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review103718 --- Patch looks great! Reviews applied: [38416, 38779] All tests

Re: Review Request 39285: Added Quota Request Validation.

> On Oct. 22, 2015, 10:57 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 64-66 > > > > > > This is an API change which contradicts the API described in the design > > doc and differs from,

Re: Review Request 39008: Used thread-safe replacement for strerror.

> On Oct. 21, 2015, 10:22 p.m., Kapil Arya wrote: > > src/launcher/executor.cpp, line 49 > > > > > > This file should go at the end of the stout includes ... don't we put > > stout/XX.hpp before stout/DIR/XX.hpp?

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 22, 2015, 7:52 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39285: Added Quota Request Validation.

> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 878 > > > > > > s/Check/Checks > > s/Request/request > > > > Do we capitalize "quota"? I did, will adjust to

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/#review103599 --- Ship it! Confirmed that logic of `utime` did not change.

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote: > > Can you also sync this with the V1 API? (If so, I'll remove that section > > from this: https://reviews.apache.org/r/39502 ). Yes, I will update the v1 proto file as well. Thanks for the reminder. - Connor