Re: Review Request 42616: libprocess: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42616/ --- (Updated Feb. 1, 2016, 7:41 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Feb. 1, 2016, 7:40 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43034: libprocess: Added EXPECT_NO_FUTURE_DISPATCHES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43034/#review117257 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 31, 2016,

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 9:11 a.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/#review117256 --- Bad patch! Reviews applied: [42615] Failed command:

Re: Review Request 42797: Fix expire CERN GPG key link.

> On Feb. 1, 2016, 8:12 a.m., Benjamin Bannier wrote: > > docs/getting-started.md, lines 87-90 > > > > > > While this appears to work, it seems weird to import the repo from > > `linuxsoft.cern.ch`, and the key from

Re: Review Request 43056: Edited comments in 'verify_reviews.py' for grammar and style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/#review117247 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 43056: Edited comments in 'verify_reviews.py' for grammar and style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/ --- Review request for mesos. Repository: mesos Description --- Edited

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 43056: Edited comments in 'verify_reviews.py' for grammar and style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/ --- (Updated Feb. 1, 2016, 10:10 p.m.) Review request for mesos. Repository:

Re: Review Request 42974: Removed unused variable in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42974/ --- (Updated Feb. 1, 2016, 10:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

> On Feb. 1, 2016, 9:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 454-455 > > > > > > In fact, i think we should add a helper in src/linux/cgroup.hpp (like > > we

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117230 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/ --- Review request for mesos, Bernd Mathiske and Thomas Rampelberg. Bugs:

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

> On Feb. 1, 2016, 9:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 454-455 > > > > > > In fact, i think we should add a helper in src/linux/cgroup.hpp (like > > we

Re: Review Request 43065: Fixed a leak of a `ZooKeeperMasterContender` in a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43065/#review117296 --- Patch looks great! Reviews applied: [43033, 43065] Passed

Re: Review Request 42616: Cleaned up usage of namespace-qualified identifiers in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42616/ --- (Updated Feb. 1, 2016, 10:07 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42997: [6 of 7] Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42997/#review117283 --- src/master/master.cpp (line 5452)

Re: Review Request 42615: Cleaned up usage of namespace-qualified identifiers in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/ --- (Updated Feb. 1, 2016, 10:07 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42971: Marked an unused function parameter appropriately in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42971/ --- (Updated Feb. 1, 2016, 10:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42972: Fixed a typo (unintended inequality between pointer value and 0) in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/ --- (Updated Feb. 1, 2016, 10:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 499-503 > > > > > > You should do this after the cgroup has been destroyed. Makes sense. Planning

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Feb. 1, 2016, 9:40 p.m.) Review request for mesos and Joris Van

Re: Review Request 42617: Cleaned up usage of namespace-qualified identifiers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Feb. 1, 2016, 10:07 p.m.) Review request for mesos and Michael Park.

Review Request 43065: Fixed a leak of a `ZooKeeperMasterContender` in a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43065/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 43056: Fixed typo in 'verify_reviews.py'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/ --- (Updated Feb. 1, 2016, 10:11 p.m.) Review request for mesos. Summary

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review117304 --- Patch looks great! Reviews applied: [43033, 43065, 43034, 43035]

Re: Review Request 42997: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42997/ --- (Updated Feb. 2, 2016, 12:39 a.m.) Review request for mesos and Adam B.

Re: Review Request 42995: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42995/ --- (Updated Feb. 2, 2016, 12:38 a.m.) Review request for mesos and Adam B.

Re: Review Request 42994: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42994/ --- (Updated Feb. 2, 2016, 12:38 a.m.) Review request for mesos and Adam B.

Re: Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

> On Jan. 30, 2016, 10:30 a.m., Guangya Liu wrote: > > src/tests/persistent_shared_volume_framework_test.sh, line 1 > > > > > > Seems this file does not have execute permssion Seems like it does. -rwxr-xr-x 1

Re: Review Request 42998: Added docs for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/ --- (Updated Feb. 2, 2016, 12:39 a.m.) Review request for mesos and Adam B.

Re: Review Request 42996: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42996/ --- (Updated Feb. 2, 2016, 12:38 a.m.) Review request for mesos and Adam B.

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/#review117347 --- Bad patch! Reviews applied: [43072] Failed command:

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

> On Jan. 30, 2016, 4:02 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 899 > > > > > > Do we also need to check contain here? > > > > I think that the unsharable should be failed if the

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

> On Feb. 1, 2016, 3:46 a.m., Guangya Liu wrote: > > src/master/master.cpp, lines 5444-5445 > > > > > > move this comments to 5452 To avoid rebase issues, I will fix this as a part of

Re: Review Request 42993: Support for multiple frameworks sharing the same resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/ --- (Updated Feb. 2, 2016, 12:37 a.m.) Review request for mesos and Adam B.

Re: Review Request 42974: Removed unused variable in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42974/#review117336 --- Bad patch! Reviews applied: [42971, 42972] Failed command:

Re: Review Request 43056: Fixed typo in 'verify_reviews.py'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/#review117344 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 2, 2016, 12:36 a.m.) Review request for mesos and Adam B.

Re: Review Request 42972: Fixed a minor bug in stout's Flags package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/ --- (Updated Feb. 2, 2016, 1:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117225 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Jan. 31, 2016, 4 p.m., haosdent huang wrote: > > src/tests/containerizer/docker_tests.cpp, line 122 > > > > > > Do you need verify this in inspect result? Will you please tell a little bit more about this? Do

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/#review117198 --- Patch looks great! Reviews applied: [43041] Passed command:

Re: Review Request 42797: Fix expire CERN GPG key link.

> On Feb. 1, 2016, 4:12 p.m., Benjamin Bannier wrote: > > docs/getting-started.md, lines 87-90 > > > > > > While this appears to work, it seems weird to import the repo from > > `linuxsoft.cern.ch`, and the key from

Re: Review Request 42586: Defined the NetClsHandleMgr class.

> On 二月 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 40 > > > > > > 2 blank lines above please. Does there are any policies for this when need one blank

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/#review117370 --- I saw that there are still other places using the call.type()

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/#review117369 --- Patch looks great! Reviews applied: [43075] Passed command:

Re: Review Request 42998: Added docs for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/#review117349 --- Patch looks great! Reviews applied: [42992, 42993, 42994, 42995,

Review Request 43075: Fixed error message when dropping a scheduler::Call message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/#review117363 --- Ship it! Ship It! - Guangya Liu On 二月 2, 2016, 5:12 a.m.,

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/#review117350 --- Ship it! Ship It! - haosdent huang On Feb. 1, 2016, 11:36