Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 19, 2016, 4:24 a.m., Shuai Lin wrote: > > Maybe we should also add a test that launches a task with this new http cmd > > executor? ping - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 18, 2016, 4:07 p.m., Shuai Lin wrote: > > src/slave/flags.cpp, line 693 > > > > > > One space before `\n`, otherwise the word would be mixed with the first > > word of the next line. > > Qian Zhang wrote:

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 18, 2016, 4:07 p.m., Shuai Lin wrote: > > src/slave/slave.cpp, line 3709 > > > > > > Instead of repeating the `if (flags.http_command_executor)...` logic > > multiple times, I would prefer use a temp vari

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 21, 2016, 7:46 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 19, 2016, 9:34 a.m., haosdent huang wrote: > > src/linux/fs.cpp, line 59 > > > > > > `tokens.back()` instead of `tokens[tokens.size() - 1]`? Good suggestion, updated. - Shuai ---

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 19, 2016, 9:28 a.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 49 > > > > > > I use CentOS 6. But seems don't have `ext2` and `ext3` in > > `/proc/filesystems` > > > > ``

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 21, 2016, 7:43 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43807: Replaced with `~` in authentication.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43807/ --- (Updated Feb. 21, 2016, 2:42 p.m.) Review request for mesos, Adam B and Till To

Re: Review Request 43807: Replaced with /Users/klaus in authentication.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43807/#review120059 --- Patch looks great! Reviews applied: [43807] Passed command: expo

Review Request 43807: Replaced with /Users/klaus in authentication.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43807/ --- Review request for mesos, Adam B and Till Toenshoff. Repository: mesos Descri

Re: Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review120057 --- Patch looks great! Reviews applied: [43806] Passed command: expo

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? > > Yongqiao Wang wrote: > Acco

Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-3943

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43802/ --- (Updated Feb. 21, 2016, 9:05 a.m.) Review request for mesos and Adam B. Chang

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated Feb. 20, 2016, 6:47 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 811-815 > > > > > > This is done after the container has been launched. We should > > definitely call out the fact that the

Re: Review Request 43450: Fixed typo in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43450/#review120052 --- Ship it! Ship It! - Ben Mahler On Feb. 10, 2016, 11:16 p.m.,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)?

Re: Review Request 43382: Updated Doxyfile to use relative path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/#review120049 --- Ship it! Thanks for clarifying! I see what this is doing now.

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43802/#review120048 --- Bad patch! Reviews applied: [43802] Failed command: ./support/ap

Review Request 43802: Wrapped TASK_LOST with `` in authorization.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43802/ --- Review request for mesos and Adam B. Repository: mesos Description --- W

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43489/#review120043 --- It would be helpful to reference in the testing done section that

Re: Review Request 40748: Updated documentation to point out the need of a resolvable hostname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40748/#review120047 --- docs/getting-started.md (line 26)

Re: Review Request 43319: Remove markdown files from doxygen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/ --- (Updated Feb. 20, 2016, 11:10 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43382: Updated Doxyfile to use relative path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/ --- (Updated Feb. 20, 2016, 11:04 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43701: Added a command executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review120046 --- Patch looks great! Reviews applied: [43701] Passed command: expo

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review120045 --- Hm.. I would expect this patch to be testing the functionality tha

Re: Review Request 43701: Added a command executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/ --- (Updated Feb. 20, 2016, 9:44 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 43487: Add TASK_KILLING state.

> On Feb. 20, 2016, 11:55 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 1109 > > > > > > Let's clarify that "being killed" in this context is referring to the > > executor having received the kill req

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you sh

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43488/#review120039 --- Fix it, then Ship it! Thanks! I'll make the adjustments here si

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 60 > > > > > > Regarnding `lround`, it maybe overcommit resources, if framework keep > > launching task with smaller CPU usage; I'd sugge

Re: Review Request 43487: Add TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43487/#review120038 --- Ship it! Thanks! I left a minor comment but I'll take care of i

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120037 --- Patch looks great! Reviews applied: [43776, 43777, 43782, 43778,

Re: Review Request 43319: Remove markdown files from doxygen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/#review120036 --- Fix it, then Ship it! site/README.md (lines 24 - 25)

Re: Review Request 43382: Updated Doxyfile to use relative path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/#review120035 --- Hm.. I still don't follow from the description what this change is

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120034 --- Patch looks great! Reviews applied: [43796] Passed command: expo

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120031 --- docs/authorization.md (lines 215 - 244)

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120033 --- src/tests/reservation_endpoints_tests.cpp (line 1035)

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120032 --- Patch looks great! Reviews applied: [43801] Passed command: expo

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/#review120030 --- src/tests/authorization_tests.cpp (line 565)

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120028 --- include/mesos/authorizer/authorizer.proto (line 87)