Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/#review120845 --- Patch looks great! Reviews applied: [43816, 43822, 43823, 43817,

Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-25 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/ --- Review request for mesos, Greg Mann, haosdent huang, and Jie Yu. Bugs: MESOS-44

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review120841 --- Bad patch! Reviews applied: [44045, 42036] Failed command: ./sup

Re: Review Request 44044: CMake: src CMakeLists-Added source to build master.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/#review120838 --- Bad patch! Reviews applied: [43997, 44001, 44003, 44005, 44007, 4

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/ --- (Updated Feb. 26, 2016, 5:59 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-25 Thread Alex Clemmer
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > > > > > Why is the cast to `size_t` needed here? > > Alex Clemmer wrote: > It is req

Re: Review Request 43777: Removed unnecessary parameter from validation function.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/#review120834 --- Ship it! Ship It! - Neil Conway On Feb. 24, 2016, 6:41 p.m.,

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review120833 --- Bad patch! Reviews applied: [44042, 41632, 40620, 40115, 40939, 4

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120826 --- src/master/master.cpp (line 2857)

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/#review120832 --- src/tests/persistent_volume_endpoints_tests.cpp (line 839)

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120829 --- src/tests/reservation_endpoints_tests.cpp (line 1069)

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120823 --- This needs a prominent note in `upgrades.md` about the change to t

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/#review120828 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 25

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 26, 2016, 5:31 a.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review120825 --- Bad patch! Reviews applied: [43908, 43907, 43906] Failed command

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43826/#review120822 --- site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/ --- (Updated Feb. 26, 2016, 4:07 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review120821 --- Bad patch! Reviews applied: [43905, 43904, 43903, 43709, 43708, 4

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-02-25 Thread Disha Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/ --- (Updated Feb. 26, 2016, 2:27 a.m.) Review request for mesos and Joseph Wu. Re

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-25 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/ --- (Updated Feb. 26, 2016, 9:59 a.m.) Review request for mesos. Bugs: MESOS-4774

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review120813 --- Fix it, then Ship it! LGTM, Just one minor query around moving

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/#review120812 --- Patch looks great! Reviews applied: [44029] Passed command: expo

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120810 --- include/mesos/mesos.proto (line 1577)

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-25 Thread Michael Park
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > > > > > Why is the cast to `size_t` needed here? > > Alex Clemmer wrote: > It is req

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 25, 2016, 4:41 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43410: Windows: Added support for dynamic library loading.

2016-02-25 Thread Michael Park
> On Feb. 24, 2016, 11:57 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp, > > lines 67-68 > > > > > > Fits in one line. > > Alex Clemmer wrote: > Hmm, d

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review120806 --- Patch looks great! Reviews applied: [44026] Passed command: expo

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120750 --- Fix it, then Ship it! Thanks! This is great! src/slave/contai

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120795 --- Patch looks great! Reviews applied: [43776, 43777, 43782, 43778,

Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-4667 htt

Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

2016-02-25 Thread Diana Arroyo
> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our leveldb.

Review Request 44044: CMake: src CMakeLists-Added source to build master.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120776 --- Patch looks great! Reviews applied: [44004] Passed command: expo

Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- (Updated Feb. 25, 2016, 8:53 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

2016-02-25 Thread Joseph Wu
> On Feb. 25, 2016, 3:36 a.m., Bernd Mathiske wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 1855 > > > > > > Why the extra image? This test seems to run just fine with the other > > change

Re: Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44008/#review120754 --- Patch looks great! Reviews applied: [43997, 44001, 44003, 44005,

Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- (Updated Feb. 25, 2016, 8:13 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43718: Added fs::supported() function.

2016-02-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120747 --- Fix it, then Ship it! Thanks! src/linux/fs.cpp (line 51)

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 7:42 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120740 --- Bad patch! Reviews applied: [43884, 43883, 43882, 43881, 43880, 4

Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-25 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/ --- Review request for mesos, Bernd Mathiske, Jie Yu, and Jiang Yan Xu. Bugs: MESOS

Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/#review120727 --- Patch looks great! Reviews applied: [43995] Passed command: expo

Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- (Updated Feb. 25, 2016, 6:04 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- (Updated Feb. 25, 2016, 5:45 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43410: Windows: Added support for dynamic library loading.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- (Updated Feb. 25, 2016, 5:15 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 25, 2016, 5:15 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-25 Thread Alex Clemmer
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > > > > > Why is the cast to `size_t` needed here? It is required, and (though it has been

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-25 Thread Alex Clemmer
> On Feb. 25, 2016, 12:09 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp, lines > > 73-74 > > > > > > We're only testing that `loadSymbol` fails if we don't call `open

Re: Review Request 43410: Windows: Added support for dynamic library loading.

2016-02-25 Thread Alex Clemmer
> On Feb. 24, 2016, 11:57 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp, > > lines 67-68 > > > > > > Fits in one line. Hmm, does it? I don't think so, am I

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review120718 --- src/master/allocator/mesos/hierarchical.cpp (line 1207)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120716 --- src/master/allocator/mesos/hierarchical.hpp (line 376)

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-25 Thread Anand Mazumdar
> On Feb. 24, 2016, 3:03 a.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, lines 239-244 > > > > > > Shouldn't we do the same for executor library? > > > > More importnatly, what if a previous subscri

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- (Updated Feb. 25, 2016, 4:27 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-25 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/#review120714 --- 3rdparty/libprocess/src/subprocess.cpp (line 345)

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-25 Thread Alex Rukletsov
Folks, Sorry for not communicating it properly, I should have discarded the patch actually. As Ben already mentioned, we had agreed to rework it and maybe split into multiple patches for clarity. However, I haven't published them yet. Best, Alex On 23 Feb 2016 18:35, "Bernd Mathiske" wrote: > >

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

2016-02-25 Thread Benjamin Bannier
> On Feb. 25, 2016, 12:59 p.m., Guangya Liu wrote: > > docs/monitoring.md, line 905 > > > > > > s/framework_filters/framework_offer_filters > > > > and ditto for the following > > > > There are both

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120710 --- include/mesos/mesos.proto (line 1576)

Review Request 44005: CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44005/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44008/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Review Request 44007: CMake: MesosConfigure-add include of master configure.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44007/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 25, 2016, 4:27 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
> On Feb. 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 229-251 > > > > > > What about as this: > > > > Try Docker::validateVersion(const Version& minVersion) const > > { > >

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
> On Feb. 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 144-172 > > > > > > why update this function, this can also get the docker version, why do > > you want to update the docker versi

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
> On Feb. 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.hpp, line 269 > > > > > > What about > > > > `Version dockerVersion` That is not working. First of all , we have to initialize docke

Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-4758 ht

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
> On Feb. 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 123-127 > > > > > > What about update here as: > > > > > > // Get docker version. > > Future version = this->

Review Request 44003: CMake: Add CMakeLists for master executable build.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44003/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Review Request 44001: CMake: Add MasterConfigure for master executable build.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120689 --- src/docker/docker.hpp (line 269)

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

2016-02-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review120688 --- docs/monitoring.md (line 905)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-25 Thread Benjamin Bannier
> On Feb. 25, 2016, 12:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1204 > > > > > > Even though I really like the anonymous namespace, we don't use it for > > some reasons

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 25, 2016, 12:37 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 25, 2016, 12:37 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

2016-02-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43963/#review120686 --- src/tests/containerizer/docker_containerizer_tests.cpp (line 1855

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43879: Added allocator metrics for number of allocations made.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

2016-02-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43961/#review120683 --- Fix it, then Ship it! src/tests/containerizer/isolator_tests.c

Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-25 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/ --- Review request for mesos. Bugs: MESOS-4774 https://issues.apache.org/jira/b

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120680 --- Patch looks great! Reviews applied: [43799] Passed command: expo

Review Request 43997: CMake: Move FindApr and FindSvn to master.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43997/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,

Re: Review Request 43461: Used foreach loop to iterate std list/set.

2016-02-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120677 --- Ship it! Ship It! - Michael Park On Feb. 25, 2016, 4:11 a.m.

Re: Review Request 43879: Added allocator metrics for number of allocations made.

2016-02-25 Thread Benjamin Bannier
- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120570 --- On Feb. 24, 2016, 9:42 p.m., Benjamin Bannier wrote:

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 8:22 a.m.) Review request for mesos, Artem Harutyunyan,

Review Request 43995: CMake: Creating MACROS to get time and date.

2016-02-25 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,