Re: Review Request 44144: Improved the documentation for setting ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44144/#review121127 --- Ship it! Ship It! - Adam B On Feb. 27, 2016, 9:49 a.m.,

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > > introduced at a specific kernel version

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review121122 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 9:16

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review121121 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 10:28

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review121120 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:09

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review121119 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review121118 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review121117 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/#review121115 --- Ship it! src/master/http.cpp (line 1228)

Re: Review Request 43817: Removed no-longer-used model functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/#review121116 --- Ship it! Ship It! - Michael Park On Feb. 28, 2016, 12:17

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/#review121114 --- docs/persistent-volume.md (lines 372 - 374)

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review121113 --- Ship it! Ship It! - Michael Park On Feb. 28, 2016, 12:15

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

> On Feb. 26, 2016, 9:38 p.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 625 > > > > > > Is this the best name for this type? Not sure there's a better name, > > but

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43938/ --- (Updated Feb. 28, 2016, 2:17 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/#review12 --- Patch looks great! Reviews applied: [43937, 43938, 43939, 43816,

Re: Review Request 44113: Cleaned up assertions in test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44113/#review121110 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 27, 2016,

Re: Review Request 43636: Cleaned up various code in a test file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43636/#review121109 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 27, 2016,

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 28, 2016, 12:21 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43817: Removed no-longer-used model functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/ --- (Updated Feb. 28, 2016, 12:17 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 28, 2016, 12:17 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated Feb. 28, 2016, 12:16 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 41760: Add initialization method to Anonymous class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/#review121102 --- Hi Marco, Sorry for the delayed response. While I already gave

Re: Review Request 44126: Fixed a few style issues in the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44126/#review121107 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 27, 2016,

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review121106 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review121105 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:13

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121104 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review121103 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121100 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:41

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121099 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121098 --- src/CMakeLists.txt (line 376)

Re: Review Request 44144: Improved the documentation for setting ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44144/#review121097 --- Patch looks great! Reviews applied: [44144] Passed command:

Re: Review Request 44144: Improved the documentation for setting ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44144/#review121096 --- Ship it! Ship It! - Neil Conway On Feb. 27, 2016, 5:49

Re: Review Request 44144: Improved the documentation for setting ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44144/#review121095 --- Ship it! Ship It! - Alexander Rojas On Feb. 27, 2016, 6:49

Review Request 44144: Improved the documentation for setting ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44144/ --- Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121092 --- Patch looks great! Reviews applied: [41597, 41681, 43863, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Feb. 27, 2016, 1:55 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review121088 --- Patch looks great! Reviews applied: [41597, 41681, 43863]

Re: Review Request 41790: Add tests for /weights endpoint.

> On Feb. 27, 2016, 12:21 p.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. Thanks Adam. I will add a couple of registrar tests

Re: Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121087 --- Ship it! Ship It! - Adam B On Feb. 27, 2016, 4:26 a.m.,

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review121086 --- Ship it! LGTM, but I didn't try to run the script to verify.

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/ --- (Updated Feb. 27, 2016, 12:43 p.m.) Review request for mesos, Adam B and

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/ --- (Updated Feb. 27, 2016, 12:40 p.m.) Review request for mesos, Adam B and

Re: Review Request 43863: Move the implementation of updateWeights out of header.

> On Feb. 27, 2016, 11:17 a.m., Adam B wrote: > > Looks good to me. I'm assuming you didn't change anything substantial in > > the implementation when you moved it. It looks the same to me. Yes, I didn't change anything substantial in the implementation. > On Feb. 27, 2016, 11:17 a.m., Adam

Re: Review Request 43716: Added title to every endpoint markdown file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review121084 --- Ship it! Ship It! - Adam B On Feb. 24, 2016, 10:51 a.m.,

Re: Review Request 43328: Added a title to all documentation markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review121082 --- Ship it! Ship It! - Adam B On Feb. 24, 2016, 10:50 a.m.,

Re: Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/ --- (Updated Feb. 27, 2016, 12:26 p.m.) Review request for mesos, Adam B and

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121077 --- Sorry this took me forever to get to. Looks pretty good except

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/#review121080 --- Patch looks great! Reviews applied: [43657, 43658, 43659, 43660,

Re: Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121079 --- I took a stab at rewording your comment. I particularly didn't

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review121078 --- Fix it, then Ship it! Looks good to me. I'm assuming you

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/ --- (Updated Feb. 27, 2016, 10:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- (Updated Feb. 27, 2016, 10:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On 二月 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 229-251 > > > > > > What about as this: > > > > Try Docker::validateVersion(const Version& minVersion) const > > { > >