Re: Review Request 44475: Improve master slaves metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44475/#review122480 --- Patch looks great! Reviews applied: [44473, 44474, 44475]

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 三月 8, 2016, 5:17 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 三月 7, 2016, 4:48 p.m., Gilbert Song wrote: > > Hi Guangya, Thanks for taking this on. My main consideration about this > > patch is making distinction between shell command v.s. non-shell command. > > We have two choices: > > > > 1. Following your current implementation, the description

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review122470 --- Patch looks great! Reviews applied: [43956, 44467, 44468, 44469,

Re: Review Request 44414: Added documentation about container image support.

> On 三月 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, lines 67-77 > > > > > > Does it make sense to enable slave add those isolations based on > > containizer technology? If using `Docker`,

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122465 --- Patch looks great! Reviews applied: [44408] Passed command:

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

> On March 8, 2016, 1:35 a.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 430-431 > > > > > > Couple of thoughts here: > > > > (1) This comment is no longer accurate since there is a special case > >

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review122455 --- src/linux/perf.cpp (lines 430 - 431)

Re: Review Request 44468: Fixed the logic for default docker cmd case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44468/#review122453 --- Ship it! Ship It! - Jie Yu On March 7, 2016, 9:46 p.m.,

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43802/#review122449 --- Ship it! Ship It! - Adam B On Feb. 20, 2016, 5:05 p.m.,

Re: Review Request 44454: Returned real path for PORT_MAPPING_BIND_MOUNT_ROOT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review122446 --- src/slave/containerizer/mesos/isolators/network/port_mapping.hpp

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review122443 --- Ship it! Ship It! - Gilbert Song On March 4, 2016, 8:14

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review122442 --- Fix it, then Ship it! include/mesos/mesos.proto (lines 1585 -

Re: Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122441 --- Ship it! Ship It! - Gilbert Song On March 4, 2016, 6:20

Re: Review Request 44414: Added documentation about container image support.

> On March 8, 2016, 12:53 a.m., Timothy Chen wrote: > > docs/container-image.md, line 210 > > > > > > How about adding a subsection ### Current limitations? > > > > It seems a bit out of place without a

Re: Review Request 44414: Added documentation about container image support.

> On March 7, 2016, 6:40 p.m., Gilbert Song wrote: > > docs/container-image.md, lines 54-60 > > > > > > Should we explain why do we allow multiple types? because users may ask > > `why don't I specify all possible

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122433 --- Fix it, then Ship it! Ship It! docs/container-image.md (line

Re: Review Request 44414: Added documentation about container image support.

> On March 6, 2016, 4:35 a.m., Guangya Liu wrote: > > docs/container-image.md, lines 146-177 > > > > > > What about move this to `## Docker Support` I would rather not. I want to have a complete flow in the

Re: Review Request 44414: Added documentation about container image support.

> On March 6, 2016, 2:06 a.m., Klaus Ma wrote: > > docs/container-image.md, line 6 > > > > > > The `Mesos Containerizer` seems ambiguous: Mesos Containerizer (vs. > > Docker Containerizer) and Mesos's feature. OK,

Re: Review Request 44414: Added documentation about container image support.

> On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, line 11 > > > > > > s/containerizers/__containerizers__ I think this is fine? Why do you want to make it bold? > On March 5, 2016,

Re: Review Request 44476: Revised comments about `link` semantics in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44476/#review122427 --- Ship it! - Vinod Kone On March 8, 2016, 12:13 a.m., Neil

Re: Review Request 44475: Improve master slaves metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44475/#review122425 --- Please see my review for https://reviews.apache.org/r/44474/

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122423 --- Please see the first comment... I think this unexpectedly

Re: Review Request 44479: Revised HA framework guide documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44479/ --- (Updated March 8, 2016, 12:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44476: Revised comments about `link` semantics in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44476/ --- (Updated March 8, 2016, 12:13 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review122377 --- Thanks for working on this. Looks good, just one major issue

Re: Review Request 44479: Revised HA framework guide documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44479/#review122415 --- Fix it, then Ship it!

Re: Review Request 44478: Revised slave recovery documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44478/#review122409 --- Ship it! Thanks for the cleanup! - Vinod Kone On March 7,

Re: Review Request 44477: Fixed typo in slave's `--help` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44477/#review122408 --- Ship it! Ship It! - Vinod Kone On March 7, 2016, 10:54

Re: Review Request 44476: Revised comments about `link` semantics in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44476/#review122407 --- 3rdparty/libprocess/include/process/process.hpp (lines 112 -

Re: Review Request 44463: Made `timer.hpp` header self-contained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44463/#review122406 --- Patch looks great! Reviews applied: [44463] Passed command:

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122401 --- src/master/master.cpp (line 6461)

Review Request 44479: Revised HA framework guide documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44479/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44476: Revised comments about `link` semantics in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44476/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44477: Fixed typo in slave's `--help` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44477/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44478: Revised slave recovery documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44478/ --- (Updated March 7, 2016, 10:54 p.m.) Review request for mesos and Vinod Kone.

Review Request 44478: Revised slave recovery documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44478/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44475: Improve master slaves metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44475/ --- Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-4740

Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/ --- Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-4740

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review122396 --- src/master/master.cpp (line 2846)

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review122395 --- Patch looks great! Reviews applied: [44342] Passed command:

Re: Review Request 44414: Added documentation about container image support.

> On March 5, 2016, 8:35 p.m., Guangya Liu wrote: > > docs/container-image.md, lines 222-223 > > > > > > Suggest add the default value here: /tmp/mesos/store/docker +1. - Gilbert

Re: Review Request 44414: Added documentation about container image support.

> On March 4, 2016, 7:18 p.m., Guangya Liu wrote: > > docs/container-image.md, line 83 > > > > > > default value is `mesos`, do we need to specify it again? It might be more safe if specified explicitly. - Gilbert

Review Request 44470: Implemented runtime isoaltor default entrypoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 44468: Fixed the logic for default docker cmd case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44468/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 44467: Implemented local puller shell command test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 44469: Implemented runtime isolator default cmd test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review122381 --- Bad patch! Reviews applied: [44376] Failed command:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? > > Anurag Singh wrote: > Do you mean why is this header not ""? It's > different from - it

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? > > Anurag Singh wrote: > Do you mean why is this header not ""? It's > different from - it

Re: Review Request 44456: Added Appc provisioner integration test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review122370 --- Patch looks great! Reviews applied: [44239, 44298, 43969, 44299,

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On March 7, 2016, 7:39 p.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, lines 295-299 > > > > > > Nit: An arrangement like this is preferable: > > ``` > > FrameworkInfo frameworkInfo =

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 7, 2016, 8:52 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:14 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:13 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

> On Feb. 24, 2016, 7:57 a.m., Adam B wrote: > > docs/app-framework-development-guide.md, lines 137-139 > > > > > > Let's be very explicit that they'll need to instantiate a > > MesosSchedulerDriver and call these

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:05 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

> On Feb. 24, 2016, 7:57 a.m., Adam B wrote: > > docs/app-framework-development-guide.md, line 144 > > > > > > Get rid of the `virtual` and `= 0` since that's not a part of the API > > that their scheduler will

Re: Review Request 41049: New python lib with only the executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 7, 2016, 7:40 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122346 --- Fix it, then Ship it! LGTM. You should probably ask Adam to

Review Request 44463: Made `timer.hpp` header self-contained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44463/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 44454: Returned real path for PORT_MAPPING_BIND_MOUNT_ROOT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review122355 --- Patch looks great! Reviews applied: [44454] Passed command:

Re: Review Request 44433: Added empty line for list in maintenance doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44433/#review122349 --- Ship it! Nice catch :) - Joseph Wu On March 6, 2016, 7:52

Re: Review Request 44433: Added empty line for list in maintenance doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44433/#review122354 --- Ship it! Ship It! - Neil Conway On March 6, 2016, 3:52

Re: Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122308 --- docs/container-image.md (line 46)

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 7, 2016, 6:38 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44342: XFS disk resource isolator.

> On March 4, 2016, 1:08 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.hpp, line 84 > > > > > > This should be optional because some directories are not isolated. On recovery, it is

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122327 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. Hi Timothy, I've been stalling this for https://reviews.apache.org/r/42516, as that patch

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

> On March 4, 2016, 1:45 a.m., haosdent huang wrote: > > Ship It! Sorry, I found you binary file in this patch is incomplete when you submit it. Could you apply this https://reviews.reviewboard.org/r/7571/diff/1#index_header to you rbtools and upload the patch again? Same as your patch for

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

> On March 4, 2016, 2:55 a.m., haosdent huang wrote: > > Ship It! Sorry, I found you binary file in this patch is incomplete when you submit it. Could you apply this https://reviews.reviewboard.org/r/7571/diff/1#index_header to you rbtools and upload the patch again? - haosdent

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122314 --- Are you still be able to work on this? We like to get this

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review122309 --- Patch looks great! Reviews applied: [41681, 44450] Passed

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122305 --- Hi Guangya, Thanks for taking this on. My main consideration

Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44455/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 44454: Returned real path for PORT_MAPPING_BIND_MOUNT_ROOT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- Review request for mesos. Bugs: MESOS-4662

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 11:30 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 134 > > > > > > I don't understand this comment. We just made sure the plugin does not > >

Re: Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review122300 --- Patch looks great! Reviews applied: [6, 7, 8]

Re: Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review122299 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:09

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122298 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 7, 2016, 1:55 p.m.) Review request for mesos, Adam B and

Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- Review request for mesos and Adam B. Bugs: MESOS-4881

Re: Review Request 44447: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review122295 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:09

Re: Review Request 44446: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review122294 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:08

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122293 --- src/tests/hierarchical_allocator_tests.cpp (line 2445)

Review Request 44447: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122292 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated March 7, 2016, 12:19 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 7, 2016, 11:35 a.m.) Review request for mesos and Adam B.

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 7, 2016, 11:31 a.m.) Review request for mesos, Adam B and

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

> On March 7, 2016, 9:28 a.m., Adam B wrote: > > src/tests/fault_tolerance_tests.cpp, lines 230-233 > > > > > > Should we also `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, > > "Content-Type", masterState);`?

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122280 --- Fix it, then Ship it!

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 4, 2016, 1:46 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 75 > > > > > > two spaces > > Benjamin Bannier wrote: > I might be wrong, but don't we indent by four

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote: > > src/tests/dynamic_reservation_framework_test.sh, line 30 > > > > > > Thy do we need this? Comparing to persistent_volume_framework_test.sh After implicit role,

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

> On Feb. 21, 2016, 7:20 p.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? > > Joerg Schad wrote: > I

  1   2   >