Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review125393 --- Fix it, then Ship it! Looks great. I'll fix up these last bits

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

2016-03-24 Thread Jay Guo
> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the fu

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125387 --- Patch looks great! Reviews applied: [45310, 45311, 45312, 45313,

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-24 Thread Deshi Xiao
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. > >

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-24 Thread haosdent huang
> On March 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. >

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-24 Thread Deshi Xiao
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. Neil

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
> On March 25, 2016, 1:53 a.m., Anand Mazumdar wrote: > > LGTM, just some minor code comments. Thanks a lot for the review Anand. I just updated the review request with the fixes. Let me know if there are other issues. - Yong --- This

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/ --- (Updated March 25, 2016, 2:28 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Jian Qiu
> On 三月 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > > > > > s/sepcified/specified/ Sorry for the typo... please review again. - Jian --

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 25, 2016, 1:54 a.m.) Review request for mesos, Greg Mann, Shuai Lin

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125378 --- Fix it, then Ship it! LGTM, just some minor code comments. sr

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125377 --- Patch looks great! Reviews applied: [45304] Passed command: expo

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125367 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 25, 2016, midnight) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 24, 2016, 11:59 p.m.) Review request for mesos, Adam B, Ben Mahl

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-24 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 24, 2016, 11:54 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review125369 --- Patch looks great! Reviews applied: [45033] Passed command: expo

Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-24 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5020 h

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125362 --- Ship it! Ship It! - Jie Yu On March 24, 2016, 2:34 a.m., Qia

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-24 Thread Jie Yu
> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the > mesos-docker-ex

Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

2016-03-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review125348 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 5:54 a.m., Nei

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-24 Thread Gilbert Song
> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 160 > > > > > > Does it makes sense to distinguish the sources of overwriting here and > >

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/ --- (Updated March 24, 2016, 3:01 p.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:58 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

2016-03-24 Thread Gilbert Song
> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/launcher/executor.cpp, lines 470-471 > > > > > > Any reason we cannot use the `CHECK` condition for the `if`? Thanks, Benjamin! We do not always have t

Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 45319: Cleaned up various code in libprocess.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45319/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 45318: Added a comment to a utility function in libprocess.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45318/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/ --- (Updated March 24, 2016, 2:53 p.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

2016-03-24 Thread Gilbert Song
> On March 8, 2016, 10:02 p.m., Guangya Liu wrote: > > The configuration.md should also be updated. > > Gilbert Song wrote: > Thanks, Guangya! Will do. > > Note that this patch will be commited until 0.30 :) Fixed. Thanks, Guangya! - Gilbert

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44498/ --- (Updated March 24, 2016, 2:51 p.m.) Review request for mesos and Jie Yu. Repo

Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-24 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5014 https://issues.ap

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated March 24, 2016, 8:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 44981: Marked some private `json` functions as `static`.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44981/#review125334 --- Bad review! Reviews applied: [44981, 43911] Error: No reviewers

Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Repository: meso

Re: Review Request 45249: Added new '/files' endpoints tests using authentication.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 24, 2016, 8:33 p.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 45248: Added authentication to the '/files' endpoints.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45248/ --- (Updated March 24, 2016, 8:30 p.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-24 Thread Michael Park
> On March 10, 2016, 7 p.m., Michael Park wrote: > > src/slave/http.cpp, line 105 > > > > > > If we were using `model` before, we need to maintain that. > > > > We have a `json` defined for `CommandInfo` in

Review Request 45313: Introduced `WindowsSocketError` and factored out `WindowsErrorBase`.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: me

Review Request 45311: Added an additional template parameter to 'Try' for typeful error.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: me

Review Request 45310: Removed unnecessary constructors in `Try`.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: me

Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: me

Review Request 45312: Captured the error code in `ErrnoError` and `WindowsError`.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45312/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: me

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125329 --- Fix it, then Ship it! src/cli/execute.cpp (line 214)

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-24 Thread Steve Niemitz
> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the > mesos-docker-ex

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/#review125324 --- Patch looks great! Reviews applied: [45280] Passed command: expo

Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-24 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5015 https://issues.ap

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125311 --- I am discarding these patches because they should be supported by

Re: Review Request 45278: Replace remain zookeeper version number.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45278/#review125308 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125297 --- Patch looks great! Reviews applied: [37168] Passed command: expo

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 24, 2016, 5:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review125072 --- src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line

Re: Review Request 44948: Add XFS disk resource isolator.

2016-03-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124983 --- src/slave/containerizer/mesos/containerizer.cpp (line 217)

Re: Review Request 45185: Introduced an agent flag 'system_config_files'.

2016-03-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45185/#review125289 --- src/slave/flags.cpp (line 108)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-24 Thread Neil Conway
> On March 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. Are non-ASCII characters in .md files actually required? We should be able to use HTML character entities instead (e.g., `Ӓ`) instead. - Neil --

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125287 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-24 Thread Michael Park
> On March 24, 2016, 4:38 p.m., Michael Park wrote: > > src/slave/http.cpp, line 96 > > > > > > This should be marked `static`, right? This is addressed in https://reviews.apache.org/r/44981/. - Michael -

Re: Review Request 44981: Marked some private `json` functions as `static`.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44981/#review125283 --- Ship it! Ship It! - Michael Park On March 17, 2016, 9:33 p.m

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-24 Thread Yong Tang
> On March 17, 2016, 8:34 p.m., Michael Park wrote: > > support/clang-format, line 3 > > > > > > Can we uncomment this? Our style by definition is > > > > > The Mesos codebase follows the Google C++ Style Guid

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/#review125280 --- Fix it, then Ship it! src/slave/http.cpp (line 81)

Re: Review Request 44658: Removed unused signal escalation constant.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 24, 2016, 4:18 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 44992: Reordered function declarations in `TestContainerizer`.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44707: Added validation for task's kill policy.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 24, 2016, 4:13 p.m.) Review request for mesos, Ben Mahler and Ti

Re: Review Request 45270: Added spec protobut for external mount.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review125266 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270]

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- (Updated March 24, 2016, 2:59 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 42551: Porting mesos on ppc64le.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42551/#review125251 --- Patch looks great! Reviews applied: [42551] Passed command: expo

Re: Review Request 43883: Added a metric for querying the number offer filters for a role.

2016-03-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 24, 2016, 2:36 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43883: Added a metric for querying the number offer filters for a role.

2016-03-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 24, 2016, 2:35 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 24, 2016, 9:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-24 Thread Qian Zhang
> On March 22, 2016, 11:37 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151 > > > > > > I guess if we are going to use `attach` for connecting to networks, > >

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- (Updated March 24, 2016, 2:22 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- (Updated March 24, 2016, 1:45 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-24 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 24, 2016, 8:33 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 11:10 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 11:08 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 11:03 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
> On March 17, 2016, 6:21 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 227 > > > > > > We now mention deprecated twice here. > > The 'Note that' also seems to be out of sync with the configuration.md.

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review125237 --- Patch looks great! Reviews applied: [44255] Passed command: expo

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:23 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:21 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:19 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/ --- (Updated March 24, 2016, 10:19 a.m.) Review request for mesos and Bernd Mathisk

Re: Review Request 44447: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in libprocess.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/ --- (Updated March 24, 2016, 10:18 a.m.) Review request for mesos and Bernd Mathisk

Re: Review Request 44446: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in stout.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated March 24, 2016, 10:18 a.m.) Review request for mesos and Bernd Mathisk

Review Request 45280: Test upload binary file.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description -

Review Request 45278: Replace remain zookeeper version number.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45278/ --- Review request for mesos. Repository: mesos Description --- Replace rema

Review Request 45277: Add zookeeper-3.4.8.tar.gz.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45277/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description -

Review Request 45276: Remove zookeeper-3.4.5.tar.gz.

2016-03-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45276/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description -

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/#review125235 --- Ship it! Ship It! - Adam B On March 24, 2016, 2:07 a.m., Joe

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/ --- (Updated March 24, 2016, 9:07 a.m.) Review request for mesos, Adam B and Greg M

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Joerg Schad
> On March 21, 2016, 10:30 a.m., Adam B wrote: > > docs/endpoints/slave/health.md, lines 17-18 > > > > > > Why the double-blank line here (and elsewhere)? This is caused by the way the Description help is generated.

  1   2   >