Re: Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/#review136969 --- Patch looks great! Reviews applied: [48530] Passed command: expo

Re: Review Request 48518: Moved release plan from wiki to page.

> On June 9, 2016, 10:59 p.m., Tomasz Janiszewski wrote: > > I have some concerns with this patch. > > > > 1. Where it should be placed? > > 2. Where is should be linked? > > 3. It duplicates data from Downloads, maybe it could be merged into one > > page. > > Jie Yu wrote: > Tomasz, thank

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review136955 --- Mostly comments around: - Similar to comments from @haosdent abst

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136965 --- Patch looks great! Reviews applied: [48438] Passed command: expo

Re: Review Request 48518: Moved release plan from wiki to page.

> On June 9, 2016, 10:59 p.m., Tomasz Janiszewski wrote: > > I have some concerns with this patch. > > > > 1. Where it should be placed? > > 2. Where is should be linked? > > 3. It duplicates data from Downloads, maybe it could be merged into one > > page. > > Jie Yu wrote: > Tomasz, thank

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/common/values.cpp, lines 654-657 > > > > > > Can you pull this cleanup into a separate patch? Note that you don't > > need the variable: > > > >

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review136961 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 48524: Moved flag validation after check for required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48524/#review136959 --- Patch looks great! Reviews applied: [48524] Passed command: expo

Re: Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/#review136957 --- Hi, @janisz your patch looks quite nice! Wonderful jobs! site/da

Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/ --- Review request for mesos, haosdent huang, Jie Yu, and Vinod Kone. Bugs: MESOS-5

Re: Review Request 45905: Added metrics to the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review136956 --- Patch looks great! Reviews applied: [46407, 48299, 45604, 46411,

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48511/#review136953 --- Ship it! Ship It! - haosdent huang On June 9, 2016, 9:30 p.m

Re: Review Request 48510: Passed `ContentType` enum by value instead of const ref.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48510/#review136954 --- Ship it! Ship It! - haosdent huang On June 10, 2016, midnigh

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/#review136952 --- Ship it! Ship It! - Jie Yu On June 10, 2016, 12:47 a.m., Gua

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

> On June 7, 2016, 9:19 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 73-76 > > > > > > see above. don't need this. > > Joseph Wu wrote: > Note: This is fixed, but currently does not print

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 10, 2016, 1:16 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On June 9, 2016, 5:10 p.m., Jiang Yan Xu wrote: > > I feel good about the overall structure of this change with this revision. > > I hope I have captured most things so if we do another pass after it should > > mostly be relatively minor readability/reusablity/documentation/cleanups > > etc.

Re: Review Request 48455: Removed unused import from sorter.cpp.

> On 六月 9, 2016, 9:18 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 17-18 > > > > > > Rather than just removing this one, would you mind doing an audit of > > the headers? We're m

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/#review136944 --- Fix it, then Ship it! src/common/resources.cpp (line 756)

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/ --- (Updated 六月 10, 2016, 12:47 a.m.) Review request for mesos, Gilbert Song, haosd

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

> On 六月 9, 2016, 5:44 p.m., Jie Yu wrote: > > Can we first just log(info) docker run? Looking at the ticket that folks > > filed, looks like this is the one that's been asked the most? +1 to this, seems end user cared more for the arguments of `docker run`, will post a patch soon. - Guangya

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136940 --- Patch looks great! Reviews applied: [48400, 48401, 48449, 48046,

Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- Review request for mesos. Repository: mesos Description --- Add NetworkI

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review136417 --- I feel good about the overall structure of this change with this r

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

> On June 1, 2016, 11:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 265 > > > > > > I think you need to handle `cgroups/devices/gpus/nvidia` which also > > starts with `cgroup

Re: Review Request 48458: Corrected comment for QuotaProvidesGuarantee.

> On 六月 9, 2016, 11:52 p.m., Benjamin Mahler wrote: > > Ship It! > > Benjamin Mahler wrote: > We should clarify that QuotaProvidesGuarantee is a test in the summary of > this review because it will become the commit message. Thanks Ben, got it. - Guangya ---

Re: Review Request 48524: Moved flag validation after check for required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48524/#review136936 --- Ship it! Ship It! - Joseph Wu On June 9, 2016, 4:54 p.m., Gr

Re: Review Request 45905: Added metrics to the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated June 9, 2016, 4:55 p.m.) Review request for mesos, Greg Mann, Artem Ha

Review Request 48524: Moved flag validation after check for required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48524/ --- Review request for mesos, Joseph Wu and Vinod Kone. Repository: mesos Descrip

Re: Review Request 48458: Corrected comment for QuotaProvidesGuarantee.

> On June 9, 2016, 11:52 p.m., Benjamin Mahler wrote: > > Ship It! We should clarify that QuotaProvidesGuarantee is a test in the summary of this review because it will become the commit message. - Benjamin --- This is an automatically

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48303/ --- (Updated June 9, 2016, 4:53 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

> On June 7, 2016, 2:23 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, line 255 > > > > > > why this change? Ah, that line should have been in the next commit. I made a mistake while splitting the

Re: Review Request 48458: Corrected comment for QuotaProvidesGuarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48458/#review136934 --- Ship it! Ship It! - Benjamin Mahler On June 9, 2016, 2:38 a.

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

> On June 7, 2016, 2:19 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 73-76 > > > > > > see above. don't need this. Note: This is fixed, but currently does not print the correct validation me

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- (Updated June 9, 2016, 4:48 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 11:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48400: Extract task collection logic to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- (Updated June 9, 2016, 11:13 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/ --- (Updated June 9, 2016, 11:13 p.m.) Review request for mesos and Vinod Kone. R

Re: Review Request 48299: Updated balloon framework spacing and logging.

> On June 7, 2016, 2:11 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 52-53 > > > > > > IIRC for constructors we use the format on the left. I think both are acceptable, but the code-base pref

Re: Review Request 48299: Updated balloon framework spacing and logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48299/ --- (Updated June 9, 2016, 4:09 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 46407: Updated balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46407/ --- (Updated June 9, 2016, 4:09 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 48518: Moved release plan from wiki to page.

> On June 9, 2016, 10:59 p.m., Tomasz Janiszewski wrote: > > I have some concerns with this patch. > > > > 1. Where it should be placed? > > 2. Where is should be linked? > > 3. It duplicates data from Downloads, maybe it could be merged into one > > page. Tomasz, thanks for doing this. This

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 9:26 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 171 > > > > > > What does this comment mean? I didn't follow. > > > > Also, comments should start with a capital letter and e

Re: Review Request 48518: Moved release plan from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48518/#review136926 --- I have some concerns with this patch. 1. Where it should be place

Re: Review Request 48518: Moved release plan from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48518/#review136924 --- Ship it! Ship It! - Jie Yu On June 9, 2016, 10:55 p.m., Toma

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/#review136923 --- Ship it! No tests for this and the previous review? - Vinod Ko

Review Request 48518: Moved release plan from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48518/ --- Review request for mesos, haosdent huang, Jie Yu, and Vinod Kone. Bugs: MESOS-5

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/#review136922 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m., h

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/#review136921 --- src/tests/api_tests.cpp (lines 323 - 337)

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/#review136912 --- src/tests/api_tests.cpp (line 73)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 9:26 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 171 > > > > > > What does this comment mean? I didn't follow. > > > > Also, comments should start with a capital letter and e

Re: Review Request 48428: Updated Docker::run to return exit status of container.

> On June 9, 2016, 7:31 p.m., Joseph Wu wrote: > > src/docker/docker.cpp, line 705 > > > > > > Is there any reason why this `.onDiscard` isn't chained onto the > > `return s->status()` below instead of the `s->statu

Re: Review Request 48429: Fixed broken docker logging redirection in the docker executor.

> On June 9, 2016, 7:43 p.m., Joseph Wu wrote: > > src/docker/executor.cpp, lines 307-314 > > > > > > If the `docker inspect` times out, is it possible that we still try to > > `docker stop` on a container docker do

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48511/#review136911 --- Patch looks great! Reviews applied: [48510, 48511] Passed comman

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review136910 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m., h

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 9, 2016, 10 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2874 > > > > > > to be consistent with how we did others, lets have this function return > > JSON::Object, i.e., JSON::Protobuf(schedule)

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136909 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m., h

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136907 --- src/master/http.cpp (line 2874)

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136905 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m., h

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

> On June 9, 2016, 9:14 p.m., Joseph Wu wrote: > > src/master/http.cpp, lines 3286-3289 > > > > > > I probably missed a discussion elsewhere... > > > > Aren't all (master) operator API's supposed to return

Review Request 48511: Renamed `responseContentType` to `responseType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48511/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos De

Review Request 48510: Passed `ContentType` enum by value instead of const ref.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48510/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos De

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136898 --- src/tests/master_tests.cpp (lines 2495 - 2518)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136822 --- src/master/http.cpp (line 645)

Re: Review Request 48455: Removed unused import from sorter.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/#review136896 --- src/master/allocator/sorter/drf/sorter.cpp

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review136895 --- Content LGTM, but the return types are inconsistent with other ope

Re: Review Request 48478: Created a `cgroups/devices` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48478/#review136894 --- Ship it! Looks good, I made some minor tweaks and added the new

Re: Review Request 48477: Added ability to express dependencies between isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48477/#review136893 --- Ship it! Very nice! I made some slight adjustments, let me kno

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136890 --- src/master/http.cpp (line 662)

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/#review136889 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 47662: Added image user to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47662/#review136888 --- Since we do not support container user yet, can we punt on this pa

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

> On 六月 9, 2016, 6:12 p.m., haosdent huang wrote: > > Looks great to me. XD Thanks hasdent for the review! hope some day can meet you in person:) I will update the patch later - zhou --- This is an automatically generated e-mail. To re

Re: Review Request 48387: Delay before initiating a connection with master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review136869 --- Thanks for taking this on. Looks pretty good minus a small bug tha

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48381/#review136883 --- Bad patch! Reviews applied: [48381, 48380] Failed command: ./sup

Re: Review Request 48429: Fixed broken docker logging redirection in the docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48429/#review136881 --- src/docker/executor.cpp (lines 307 - 314)

Re: Review Request 48504: Updated libprocess to support GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48504/ --- (Updated June 9, 2016, 7:37 p.m.) Review request for mesos, Anand Mazumdar and

Review Request 48504: Updated libprocess to support GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48504/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5511 h

Re: Review Request 48428: Updated Docker::run to return exit status of container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48428/#review136726 --- Fix it, then Ship it! LGTM src/docker/docker.cpp (line 699) <

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47663/#review136880 --- include/mesos/slave/isolator.proto (line 133)

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/#review136878 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/#review136876 --- make check passed. I guess there are already test cases that cover

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/#review136874 --- Patch looks great! Reviews applied: [48115, 48116, 48257, 48084,

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 6:20 p.m., haosdent huang wrote: > > Hi, @guoger. Now the return type of RPC handlers become > > process::http::Response, may you rebase your patch? Good job! working on it! - Jay --- This is an automatically generat

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48380/ --- (Updated June 9, 2016, 6:33 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48380/ --- (Updated June 9, 2016, 6:32 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136867 --- Hi, @guoger. Now the return type of RPC handlers become process::

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48381/ --- (Updated June 9, 2016, 6:16 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136864 --- Looks great to me. XD include/mesos/v1/mesos.proto (lines 1974 -

Re: Review Request 48499: Moved design docs from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48499/#review136861 --- Patch looks great! Reviews applied: [48499] Passed command: expo

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136859 --- Hi, @dongdong. Now the return type of RPC handlers become `proces

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 9, 2016, 5:49 p.m.) Review request for mesos, Joseph Wu and Vinod

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- (Updated June 9, 2016, 5:49 p.m.) Review request for mesos, Joseph Wu and Vinod

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

> On June 6, 2016, 10:21 p.m., Joseph Wu wrote: > > src/tests/api_tests.cpp, lines 266-269 > > > > > > Why don't you evolve/devolve here? @kaysoky, thanks a lot for your review. Because we define ``` v1::master::Re

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/#review136856 --- Can we first just log(info) docker run? Looking at the ticket that

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 9:06 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 678 > > > > > > Depending on what the final return type ends up being (for > > `_updateMaintenanceSchedule`), is this missing a `.then(ser

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2773 > > > > > > this should return `v1::master::Response`. see below comment. > > Vinod Kone wrote: > sorry this should return Futu

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 1:28 p.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity a

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- (Updated June 9, 2016, 5:33 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 9, 2016, 5:32 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/ --- (Updated June 9, 2016, 5:32 p.m.) Review request for mesos and Vinod Kone. Ch

  1   2   >