Re: Review Request 46822: Avoided slicing of flags in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/ --- (Updated July 5, 2016, 7:46 a.m.) Review request for mesos, Alexander

Re: Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review140718 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review140717 --- I also did some test with patch

Re: Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49615/#review140716 --- Patch looks great! Reviews applied: [49598, 49615] Passed

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review140714 --- src/tests/hierarchical_allocator_tests.cpp (line 3617)

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/#review140713 --- Patch looks great! Reviews applied: [49610, 49612] Passed

Re: Review Request 49604: Fixed incorrect clock time in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49604/#review140709 --- Patch looks great! Reviews applied: [49602, 49604] Passed

Re: Review Request 49610: Added test case for quota allocation with reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49610/#review140704 --- src/tests/hierarchical_allocator_tests.cpp (line 3192)

Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- Review request for mesos. Repository: mesos Description --- - Useful

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- (Updated July 5, 2016, 1:14 a.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 46821: Avoided slicing of flags in subprocess in libprocess and stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 46822: Avoided slicing of flags in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/ --- (Updated July 4, 2016, 11:04 p.m.) Review request for mesos. Bugs:

Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/ --- Review request for mesos. Repository: mesos Description --- - This

Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49615/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5401

Re: Review Request 49223: Enhance value parsing.

> On 七月 4, 2016, 11:55 a.m., Guangya Liu wrote: > > src/common/values.cpp, line 673 > > > > > > Sorry, I should ask this question in previous patch. Same as above, can > > you please show more comments for what do

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140703 --- Patch looks great! Reviews applied: [49600] Passed command:

Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 49610: Added test case for quota allocation with reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49610/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 49412: Updated SSL.md with 'SSL_VERIFY_IPADD'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49412/#review140702 --- Bad patch! Reviews applied: [49412, 49411, 49402, 49401, 49400]

Re: Review Request 49603: Fixed line in '3rdParty/Makefile.am' that had potential to 'rm -rf /'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49603/#review140701 --- Ship it! Ship It! - Jie Yu On July 4, 2016, 6:09 p.m.,

Re: Review Request 49186: Added test for file volume from host sandbox mountpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49186/#review140700 --- Ship it! Ship It! - Jie Yu On July 4, 2016, 5:41 p.m.,

Re: Review Request 49185: Added test for file volume from host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49185/#review140699 --- Ship it! Ship It! - Jie Yu On July 4, 2016, 5:40 p.m.,

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review140698 --- Ship it! Ship It! - Jie Yu On July 4, 2016, 5:40 p.m.,

Re: Review Request 49223: Enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140695 --- Patch looks great! Reviews applied: [49223] Passed command:

Review Request 49605: Renamed 'commands' to 'pre_exec_commands' in ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49605/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 49603: Fixed line in '3rdParty/Makefile.am' that had potential to 'rm -rf /'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49603/#review140694 --- Ship it! Ship It! - Gilbert Song On July 4, 2016, 11:09

Review Request 49604: Fixed incorrect clock time in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49604/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 49003: Added a Contributing to Mesos blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49003/ --- (Updated July 4, 2016, 6:16 p.m.) Review request for mesos, Artem Harutyunyan

Review Request 49603: Fixed line in '3rdParty/Makefile.am' that had potential to 'rm -rf /'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49603/ --- Review request for mesos, Jie Yu and Kapil Arya. Repository: mesos

Review Request 49602: Fixed log message to avoid spanning multiple lines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49602/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Repository: mesos

Re: Review Request 49598: Added ability to parse docker v1 'ImageManifest' from 'docker inspect'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49598/ --- (Updated July 4, 2016, 5:57 p.m.) Review request for mesos, Benjamin Mahler

Review Request 49598: Added ability to parse docker v1 'ImageManifest' from 'docker inspect'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49598/ --- Review request for mesos, Benjamin Mahler and Yubo Li. Bugs: MESOS-5779

Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Jan

Re: Review Request 49186: Added test for file volume from host sandbox mountpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49186/ --- (Updated July 4, 2016, 10:41 a.m.) Review request for mesos, Artem

Re: Review Request 49185: Added test for file volume from host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49185/ --- (Updated July 4, 2016, 10:40 a.m.) Review request for mesos, Artem

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/ --- (Updated July 4, 2016, 10:40 a.m.) Review request for mesos, Artem

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

> On June 25, 2016, 8:42 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 429 > > > > > > Just nit: What about adding a comment here, someone may be confused as > >

Re: Review Request 49273: Helper binary for executors to chroot tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review140687 --- Please see the test section of

Re: Review Request 49003: Added a Contributing to Mesos blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49003/ --- (Updated July 4, 2016, 5:10 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 49587: Added "fair_sharing_excluded_resource_names" to configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49587/#review140686 --- Patch looks great! Reviews applied: [49587] Passed command:

Re: Review Request 49568: Simplified a flag in the launch helper binary.

> On July 4, 2016, 8:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1179 > > > > > > Actually I really dont like `commands` in isolator.proto > > `ContainerLaunchInfo`. Good

Re: Review Request 49549: Used the launch helper binary to launch user task in command executor.

> On July 4, 2016, 8:03 a.m., Gilbert Song wrote: > > This patch is great! > > > > I am still thinking it may be a little risky for 1.0 using command task > > with container image, because this is what we are currently doing: > > > > mesos containerizer fork a subprocess ->

Re: Review Request 49541: Renamed healthCheckDir to launcherDir in command executor.

> On July 4, 2016, 6:08 a.m., Gilbert Song wrote: > > src/launcher/executor.cpp, lines 664-701 > > > > > > This method was removed. Could you rebase? yep. I'll rebase. > On July 4, 2016, 6:08 a.m., Gilbert Song

Re: Review Request 49540: Used the argv version for command that launches the command executor.

> On July 4, 2016, 5:59 a.m., Gilbert Song wrote: > > src/slave/slave.cpp, line 3964 > > > > > > Hmm.. seems like we dont have `mesos-executor` as the first argv for a > > while. Just curious that is not supposed

Re: Review Request 49412: Updated SSL.md with 'SSL_VERIFY_IPADD'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49412/ --- (Updated July 4, 2016, 4:31 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49402: Added tests for IP based certificate validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/ --- (Updated July 4, 2016, 4:30 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49473: Made control pipe to mesos-containerizer launch optional.

> On July 2, 2016, 8:09 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 374-375 > > > > > > Also not yours. Could we fix the style here? Seems like from > >

Re: Review Request 49425: Used os::raw::Argv in command executor.

> On July 4, 2016, 9:50 a.m., Guangya Liu wrote: > > src/launcher/windows/executor.cpp, lines 70-71 > > > > > > remove this I think this TODO is still valid. I think os::stringify_args should just take a vector (or

Re: Review Request 49319: Fixed incorrect comment on ACCESS_SANDBOX in authorizer.proto.

> On June 28, 2016, 2:50 p.m., Alexander Rojas wrote: > > include/mesos/authorizer/authorizer.proto, lines 90-91 > > > > > > This comment is rather incomplete: > > > > 1. Either they are both set or none. >

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

> On July 2, 2016, 5:11 p.m., Joris Van Remoortere wrote: > > 3rdparty/stout/include/stout/os/raw/argv.hpp, line 40 > > > > > > It seems like this extra vector and the subsequent copy into the argv > > array is only

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated July 4, 2016, 4:17 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49415: Removed the argv parameter in command executor helper.

> On July 1, 2016, 9:33 p.m., Gilbert Song wrote: > > Do you miss `windows/executor.hpp`? > > Gilbert Song wrote: > Fix it, Ship it! :) Thanks! Fixed it. - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49401: Updated certificate validation to check 'IP Address' SAN.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49401/ --- (Updated July 4, 2016, 4:09 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140669 --- Patch looks great! Reviews applied: [49369, 49370, 49574, 49575]

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review140661 --- Ship it! Ship It! - Michael Park On July 4, 2016, 1:57

Re: Review Request 49262: Added '--enable-netlink' into configure.ac.

> On June 28, 2016, 4:41 a.m., Jie Yu wrote: > > configure.ac, lines 2087-2088 > > > > > > Instead of copying it, can you place this check first and the > > `with_network_isolator` check can be simplified to check

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/ --- (Updated July 4, 2016, 9:57 p.m.) Review request for mesos and Michael Park.

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140656 --- Ship it! Ship It! - Michael Park On July 4, 2016, 8:53

Re: Review Request 49323: Added tests that combine the two ways of creating volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/#review140655 --- Ship it! Ship It! - Michael Park On July 4, 2016, 8:32

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140654 --- Patch looks great! Reviews applied: [49323, 49375, 49376, 49377]

Re: Review Request 49223: Enhance value parsing.

> On July 4, 2016, 7:55 p.m., Guangya Liu wrote: > > src/common/values.cpp, line 673 > > > > > > Sorry, I should ask this question in previous patch. Same as above, can > > you please show more comments for what do

Re: Review Request 49586: Used startsWith char version for role validation.

> On July 4, 2016, 6:51 p.m., Michael Park wrote: > > This is covered in https://reviews.apache.org/r/49582/ Yes, you're right :). Discard this patch. - Klaus --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49223: Enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140650 --- src/common/values.cpp (line 665)

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- (Updated July 4, 2016, 2:41 p.m.) Review request for mesos, Alexander

Re: Review Request 46822: Avoided slicing of flags in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/ --- (Updated July 4, 2016, 2:41 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 4, 2016, 2:41 p.m.) Review request for mesos, Alexander

Re: Review Request 46821: Avoided slicing of flags in subprocess in libprocess and stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/ --- (Updated July 4, 2016, 2:41 p.m.) Review request for mesos, Alexander

Re: Review Request 49223: Enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140648 --- src/common/values.cpp (line 648)

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140647 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Re: Review Request 49586: Used startsWith char version for role validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49586/#review140646 --- This is covered in https://reviews.apache.org/r/49582/ - Michael

Re: Review Request 49223: Enhance value parsing.

> On July 1, 2016, 1:27 p.m., Guangya Liu wrote: > > src/tests/values_tests.cpp, line 204 > > > > > > Would it make sense to add some negative case here to test against the > > code for error handling? Will handle

Re: Review Request 49223: Enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 4, 2016, 6:33 p.m.) Review request for mesos and Benjamin

Re: Review Request 49586: Used startsWith char version for role validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49586/#review140644 --- Patch looks great! Reviews applied: [49586] Passed command:

Review Request 49587: Added "fair_sharing_excluded_resource_names" to configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49587/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5758

Re: Review Request 49425: Used os::raw::Argv in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49425/#review140637 --- src/launcher/windows/executor.cpp (lines 70 - 71)

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/ --- (Updated July 4, 2016, 9:22 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49574/ --- (Updated July 4, 2016, 9:21 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/ --- (Updated July 4, 2016, 9:21 a.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49369: Introduced authorization based filtering for /roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/ --- (Updated July 4, 2016, 9:12 a.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49375: Simplified DRFSorter to not track per-slave total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49375/ --- (Updated July 4, 2016, 9:01 a.m.) Review request for mesos, Alexander

Re: Review Request 49375: Simplified DRFSorter to not track per-slave total resources.

> On July 4, 2016, 7:51 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 716-723 > > > > > > Just nit: I think that here the `role sorters` should include both > > `roleSorter` and

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/ --- (Updated July 4, 2016, 8:53 a.m.) Review request for mesos, Alexander

Re: Review Request 49323: Added tests that combine the two ways of creating volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/ --- (Updated July 4, 2016, 8:32 a.m.) Review request for mesos, Alexander

Re: Review Request 49376: Added assertions to DRFSorter.

> On 七月 4, 2016, 8:01 a.m., Guangya Liu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 272-275 > > > > > > How about adjust the order a bit as following? > > > >

Re: Review Request 49376: Added assertions to DRFSorter.

> On July 4, 2016, 8:01 a.m., Guangya Liu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 272-275 > > > > > > How about adjust the order a bit as following? > > > >

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140625 --- Ship it! Ship It! - Alexander Rojas On July 3, 2016, 7:51

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 4, 2016, 10:17 a.m.) Review request for mesos, Alexander

Re: Review Request 49569: Added an option to the launch helper binary to unshare mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49569/#review140624 --- Ship it! LGTM! I will do some real container image command

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review140623 --- Patch looks great! Reviews applied: [49140, 49246] Passed

Re: Review Request 49568: Simplified a flag in the launch helper binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49568/#review140622 --- Ship it! LGTM!

Review Request 49586: Used startsWith char version for role validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49586/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 49549: Used the launch helper binary to launch user task in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49549/#review140621 --- Ship it! This patch is great! I am still thinking it may be a

Re: Review Request 49376: Added assertions to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49376/#review140620 --- src/master/allocator/sorter/drf/sorter.cpp (lines 272 - 275)

Re: Review Request 49375: Simplified DRFSorter to not track per-slave total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49375/#review140617 --- src/master/allocator/mesos/hierarchical.cpp (line 543)

Re: Review Request 49548: Added devolve function for CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49548/#review140615 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 6:01

Re: Review Request 49542: Explicitly passed in launcher dir to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49542/#review140614 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 4:53

Re: Review Request 49540: Used the argv version for command that launches the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49540/#review140612 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 4:24

  1   2   >