Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

> On July 15, 2016, 6:55 a.m., Abhishek Dasgupta wrote: > > src/master/http.cpp, lines 1917-1928 > > > > > > You may do it this way: > > // TODO(tuananh): I don't know why I cannot use foreachpair instead. > >

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142339 --- src/master/http.cpp (lines 1917 - 1928)

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142338 --- src/tests/api_tests.cpp (line 335)

Re: Review Request 49943: Made vector reserve some spaces for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49943/#review142336 --- Ship it! Ship It! - Jiang Yan Xu On July 14, 2016, 8:14 p.m.

Review Request 50065: Enhancement for containers which have image and join host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50065/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5806 ht

Re: Review Request 50061: Removed the trailing semi-colon when parse resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50061/#review142334 --- Patch looks great! Reviews applied: [49943, 49781, 50060, 50061]

Re: Review Request 50061: Removed the trailing semi-colon when parse resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50061/ --- (Updated 七月 15, 2016, 5:16 a.m.) Review request for mesos, Benjamin Mahler, Kla

Re: Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50060/#review142329 --- Patch looks great! Reviews applied: [49943, 49781, 50060] Passed

Re: Review Request 49178: Configured single output binary folder.

> On June 24, 2016, 8:41 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 462 > > > > > > Would it be worthwhile to get rid of the "Debug" and "Release" build > > configuration folders too? > > > > i.e.

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 15, 2016, 3:32 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 15, 2016, 3:32 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 15, 2016, 3:32 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 15, 2016, 3:31 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50061: Removed the trailing semi-colon when parse resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50061/ --- (Updated 七月 15, 2016, 3:20 a.m.) Review request for mesos, Benjamin Mahler, Kla

Review Request 50061: Removed the trailing semi-colon when parse resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50061/ --- Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu. Reposito

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 15, 2016, 3 a.m.) Review request for mesos, Gilbert Song, Jie Yu,

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 15, 2016, 3 a.m.) Review request for mesos, Gilbert Song, Jie Yu,

Re: Review Request 49843: Added benchmark test for sorter.

> On 七月 14, 2016, 7:14 p.m., Benjamin Mahler wrote: > > Thanks Ben for the cleanup and helping merge the code. Please check my answers inline. > On 七月 14, 2016, 7:14 p.m., Benjamin Mahler wrote: > > src/tests/sorter_tests.cpp, lines 504-542 > >

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review142327 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50060/ --- Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu. Reposito

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142325 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142324 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 15, 2016, 7:49 a.m., Klaus Ma wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 22 > > > > > > This's not necessary, `sorter/sorter.hpp` had included it. > > Guangya Liu wrote: > I think the r

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49939/#review142317 --- Patch looks great! Reviews applied: [49936, 49937, 49938, 49939]

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On 七月 14, 2016, 11:49 p.m., Klaus Ma wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 22 > > > > > > This's not necessary, `sorter/sorter.hpp` had included it. I think the reason here is we generally don

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142312 --- src/master/allocator/sorter/sorter.hpp (line 131)

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142309 --- Ship it! Ship It! - Klaus Ma On July 15, 2016, 3:35 a.m., Be

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142308 --- src/master/allocator/sorter/drf/sorter.hpp (line 22)

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142300 --- Patch looks great! Reviews applied: [50044] Passed command: expo

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 14, 2016, 10:11 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

> On July 14, 2016, 1:27 a.m., Vinod Kone wrote: > > 3rdparty/stout/tests/flags_tests.cpp, line 546 > > > > > > s/test_option_map/values2/ Scoped so they can share the same name of `values` - Ammar -

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/ --- (Updated July 14, 2016, 10:10 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/ --- (Updated July 14, 2016, 2:35 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

> On July 14, 2016, 12:31 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [49939, 49938, 49937, 49936] > > > > Failed command: ./support/apply-review.sh -n -r 49938 > > > > Error: > > 2016-07-14 07:31:47 URL:https://reviews.apache.org/r/49938/diff/raw/ > > [4422/4422] ->

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

> On July 14, 2016, 3:19 a.m., Abhishek Dasgupta wrote: > > If you address my comments in master, pls do them for agent as well. Yes thank you for your reviews, I updated both Master and Agent - Tuan-Anh --- This is an automatically gen

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49939/ --- (Updated July 14, 2016, 2:32 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 50041: Supported docker container running as a defined user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50041/#review142280 --- Patch looks great! Reviews applied: [50041] Passed command: expo

Re: Review Request 49938: Updated GET_METRICS call in v1 api to return metrics grouped by types.

> On July 14, 2016, 1:47 a.m., Abhishek Dasgupta wrote: > > src/master/http.cpp, lines 1916-1944 > > > > > > Can we consider to use a switch here? I don't know why I can't use foreachpair for MetricMap. I got this

Re: Review Request 49938: Updated GET_METRICS call in v1 api to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/ --- (Updated July 14, 2016, 1:31 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/ --- Review request for mesos, Guangya Liu, Klaus Ma, and Jiang Yan Xu. Repository:

Re: Review Request 49843: Added benchmark test for sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/#review142264 --- Fix it, then Ship it! src/tests/sorter_tests.cpp (lines 504 -

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 13, 2016, 10:09 a.m., Neil Conway wrote: > > src/tests/api_tests.cpp, line 95 > > > > > > Rather than changing this for all tests implicitly, I'd prefer creating > > a `master::Flags` and changing the alloc

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review142268 --- Bad patch! Reviews applied: [49855, 49854, 49853, 45573, 49852, 4

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

> On July 14, 2016, 4:44 p.m., Greg Mann wrote: > > 3rdparty/stout/tests/flags_tests.cpp, line 546 > > > > > > Another option would be to scope the flag loading/checking so that you > > can use the same variable nam

Review Request 50041: Supported docker container running as a defined user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50041/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Timoth

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/#review142258 --- Bad review! Reviews applied: [49689] Error: No reviewers specifi

Re: Review Request 50017: WIP: Validated the resources when parsing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review142257 --- include/mesos/resources.hpp (lines 135 - 147)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142254 --- src/local/flags.hpp (line 36)

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 14, 2016, 5:30 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated July 14, 2016, 5:30 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated July 14, 2016, 5:30 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated July 14, 2016, 5:30 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated July 14, 2016, 5:29 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 14, 2016, 5:29 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 14, 2016, 5:28 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 14, 2016, 5:27 p.m.) Review request for mesos. Bugs: MESOS-4778

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated July 14, 2016, 5:28 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 49936: Added metric types in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49936/ --- (Updated July 14, 2016, 10:27 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated July 14, 2016, 5:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 14, 2016, 5:25 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 14, 2016, 5:16 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50038: Removed unnecessary forward declaration in subsystem.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50038/#review142256 --- Ship it! Ship It! - Gilbert Song On July 14, 2016, 10:11 a.m

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 14, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 14, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 14, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 14, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 14, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 14, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 14, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49816: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49816/ --- (Updated July 14, 2016, 5:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 14, 2016, 5:14 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 14, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 14, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50038: Removed unnecessary forward declaration in subsystem.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50038/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. Bu

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

> On July 10, 2016, 9:50 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 36-37 > > > > > > Why do you do the forward declaration rather than include cgroups.hpp? > > h

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 14, 2016, 4:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142246 --- 3rdparty/stout/include/stout/flags/flags.hpp (lines 905 - 906)

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/ --- (Updated July 14, 2016, 4:42 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/ --- (Updated July 14, 2016, 4:42 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50017: WIP: Validated the resources when parsing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Repository: mesos Des

Re: Review Request 42441: Speeded up the `ExamplesTest.*` test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review142240 --- Patch looks great! Reviews applied: [50026, 42441] Passed comman

Re: Review Request 50022: Fixed incorrected command in documentation.

> On July 14, 2016, 10:35 a.m., Guangya Liu wrote: > > I think we should not merge this, the mesos-execute should use mesos > > containerizer but not docker containerizer here, comments? > > Joerg Schad wrote: > Good point. I was mostly concerned with the command not working. I will > chec

Re: Review Request 50022: Fixed incorrected command in documentation.

> On 七月 14, 2016, 10:35 a.m., Guangya Liu wrote: > > I think we should not merge this, the mesos-execute should use mesos > > containerizer but not docker containerizer here, comments? > > Joerg Schad wrote: > Good point. I was mostly concerned with the command not working. I will > check

Re: Review Request 50022: Fixed incorrected command in documentation.

> On July 14, 2016, 10:35 a.m., Guangya Liu wrote: > > I think we should not merge this, the mesos-execute should use mesos > > containerizer but not docker containerizer here, comments? Good point. I was mostly concerned with the command not working. I will check with containerizers=mesos and

Re: Review Request 49936: Added metric types in libprocess.

> On July 14, 2016, 8:26 a.m., Abhishek Dasgupta wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, line 74 > > > > > > We may modify it to data(new Data(name, UNKNOWN, window) if we follow > > the be

Re: Review Request 50023: Fixed flakiness in persistent volume test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50023/#review14 --- Patch looks great! Reviews applied: [50023] Passed command: expo

  1   2   >