Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_BENC

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 6, 2016, 9:59 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2594 > > > > > > Seems we should also `Clock::settle();` here, otherwise, this test may > > be failed as r/5102

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

- Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review147697 --- On Aug. 23, 2016, 8:47 a.m., Jacob Janco wrote: > > ---

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 5, 2016, 11:23 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3126-3128 > > > > > > After reading this comment people could still wonder why this is > > important because

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 8, 2016, 6:31 a.m.) Review request for mesos, Benjamin Mahler and J

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.hpp, line 1027 > > > > > > How about const? > > Anand Mazumdar wrote: > Can you elaborate? Non member functions can't be marked `const`. Also,

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 8, 2016, 2:54 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 2102 > > > > > > How about also adding `[]` here? > > > > ``` > > out << "tasks [" << stringify(taskIds) << "]"; > > `

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.hpp, line 1027 > > > > > > How about const? > > Anand Mazumdar wrote: > Can you elaborate? Non member functions can't be marked `const`. Al

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 6, 2016, 9 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/capabilities.hpp, line 41 > > > > > > are we consistent on 'override' keyword? I'd suggest we be consistent > > with other isolato

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

> On Sept. 8, 2016, 5:01 a.m., Jie Yu wrote: > > Any comment on unresolved issues? Sorry, published comments now. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/#review14813

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

> On Sept. 6, 2016, 8:35 nachm., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 378 > > > > > > I am wondering if we should rename this to: > > ``` > > capabilities->setKeepCaps() > > ca

Re: Review Request 51480: Added tests for launching task groups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51480/ --- (Updated Sept. 8, 2016, 5:52 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 51710: Minor fix to avoid creating an unnecessary temporary when looping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51710/ --- (Updated Sept. 8, 2016, 5:45 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 51476: Made the `TaskInfo` argument in `launchExecutor()` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51476/ --- (Updated Sept. 8, 2016, 5:28 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 51709: Removed a no longer needed comment after the `runTasks()` refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51709/ --- (Updated Sept. 8, 2016, 5:24 a.m.) Review request for mesos, Guangya Liu and Vi

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/ --- (Updated Sept. 8, 2016, 5:19 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 9:21 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 484-485 > > > > > > I did some test with benchmark test of > > `SlaveAndFrameworkCount/HierarchicalAllocator_B

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Sept. 3, 2016, 6:38 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1226-1229 > > > > > > Just nit, I think that we should separate the `_allocate()` and > > `_deallocate()` to

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/#review148135 --- Patch looks great! Reviews applied: [45966] Passed command: expo

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/#review148133 --- Any comment on unresolved issues? - Jie Yu On Sept. 7, 2016, 4:

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review148132 --- src/slave/slave.cpp (lines 1839 - 1840)

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.hpp, line 1027 > > > > > > How about const? > > Anand Mazumdar wrote: > Can you elaborate? Non member functions can't be marked `const`. Also,

Re: Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

> On 九月 7, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3427-3428 > > > > > > This looks alright. Why is it removed? I added this back, thanks Jiang Yan. - Guangya

Re: Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/ --- (Updated 九月 8, 2016, 2:04 a.m.) Review request for mesos, Benjamin Mahler, Vino

Re: Review Request 51480: Added tests for launching task groups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51480/#review148126 --- Bad patch! Reviews applied: [51480, 51479, 51478, 51710, 51709, 5

Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51707/#review148121 --- Bad patch! Reviews applied: [51707, 51653, 51706, 51021, 51377, 5

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148109 --- Summarize the behavioral change in the summary? i.e., previously i

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Sept. 7, 2016, 11:55 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 7, 2016, 11:55 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 7, 2016, 11:55 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 7, 2016, 11:52 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 7, 2016, 11:52 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

> On Sept. 7, 2016, 10:09 p.m., Jiang Yan Xu wrote: > > Can we have a simple allocator test with two frameworks, one framework > > without the capability doesn't get allocated the shared resource and the > > other with the capability gets it? > > > > Could be in a follow up review. Will add t

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/ --- (Updated Sept. 7, 2016, 11:03 p.m.) Review request for mesos, Xiaojian Huang, h

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review148068 --- - Anand Mazumdar On Sept. 6, 2016, 9:25 p.m., Anand Mazumdar wro

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/ --- (Updated Sept. 7, 2016, 10:13 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review148099 --- Patch looks great! Reviews applied: [49688, 49862, 49863, 49870,

Re: Review Request 51478: Modified tests to account for `runTask()`/`_runTask()` refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51478/ --- (Updated Sept. 7, 2016, 10:11 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51480: Added tests for launching task groups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51480/ --- (Updated Sept. 7, 2016, 10:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51480: Added tests for launching task groups on the agent.

> On Sept. 7, 2016, 5:37 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, lines 4621-4622 > > > > > > why did you need to explicitly do this here but not in the above test? In the previous test we did not use

Re: Review Request 51478: Modified tests to account for `_runTask()` rename.

> On Sept. 7, 2016, 5:29 p.m., Vinod Kone wrote: > > I intentionally omitted putting the backticks since I was just renaming function calls/moving code around due to the refactoring. We might consider doing a sweep later. What do you think? - Anand -

Review Request 51710: Minor fix to avoid creating an unnecessary temporary when looping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51710/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 51709: Removed a no longer needed comment after the `runTasks()` refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51709/ --- Review request for mesos, Guangya Liu and Vinod Kone. Repository: mesos Descr

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, lines 3120-3135 > > > > > > Can you please show more detail and update the comments here for which > > case will cause the `executor->queu

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 7, 2016, 10:26 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1616 > > > > > > couldn't this have been? > > > > ``` > > for (auto it = tasks.begin(); it != tasks.end(); ++it) > > `

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/#review148098 --- Fix it, then Ship it! Can we have a simple allocator test with

Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51475/ --- (Updated Sept. 7, 2016, 9:53 p.m.) Review request for mesos and Vinod Kone. C

Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51707/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5965 https://issues.ap

Review Request 51706: Tweaked logging for UnregisterSlaveMessage handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51706/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5965 https://issues.ap

Re: Review Request 51653: Handled agents failing health checks multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/ --- (Updated Sept. 7, 2016, 9:35 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

> On Sept. 7, 2016, 8:57 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1763 > > > > > > indent by 4? I think this is indented correctly in the revised RR; let me know if that's not the case. - Neil -

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/ --- (Updated Sept. 7, 2016, 9:30 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Sept. 7, 2016, 9:29 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 46220: Added documentation for Nvidia GPU support.

> On Sept. 7, 2016, 5:52 p.m., Vinod Kone wrote: > > docs/gpu-support.md, lines 366-367 > > > > > > you can combine these 2 into one > > > > ``` > > $ make -j check GTEST_FILTER="*NVIDIA_GPU*" > > ``

Re: Review Request 46220: Added documentation for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/ --- (Updated Sept. 7, 2016, 9:13 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 46220: Added documentation for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/ --- (Updated Sept. 7, 2016, 9:12 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 51020: Clarified a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51020/#review148083 --- Ship it! Ship It! - Vinod Kone On Aug. 24, 2016, 3:46 p.m.,

Re: Review Request 50846: Added more assertions to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50846/#review148082 --- Ship it! Ship It! - Vinod Kone On Aug. 29, 2016, 9:50 a.m.,

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/#review148077 --- Fix it, then Ship it! src/master/master.cpp (line 1763)

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review148076 --- Bad patch! Reviews applied: [49571, 45967, 45966, 45963, 45962, 4

Re: Review Request 51257: Add external process container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51257/#review148063 --- src/slave/container_loggers/lib_externallogger.hpp (lines 20 - 38

Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/ --- Review request for mesos, Xiaojian Huang, haosdent huang, and Vinod Kone. Bugs:

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148065 --- Patch looks great! Reviews applied: [51697, 50270, 50271] Passed

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review148064 --- Given the way this review has evolved how about the following summ

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review148062 --- As Greg said some tests would be great. Then we can ship this. s

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

> On Sept. 7, 2016, 1 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1540-1542 > > > > > > Given that this case is very specific for systems without a dependency > > o

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

> On Sept. 7, 2016, 5:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1537-1538 > > > > > > I would mention that this step is necessary because we change the > > hostna

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/ --- (Updated Sept. 7, 2016, 7:02 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/ --- (Updated Sept. 7, 2016, 12:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51359: Added unit test for provisioner helper findContainerDir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/ --- (Updated Sept. 7, 2016, 12:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/ --- (Updated Sept. 7, 2016, noon) Review request for mesos, Benjamin Hindman, Artem

Re: Review Request 51402: Added nested container check in provisioner destroy.

> On Sept. 5, 2016, 2:51 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 434 > > > > > > s/sub-container/sub-containers/ Lets us nested containers consistantly. - Gilber

Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.

> On Sept. 4, 2016, 7:13 a.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 372-373 > > > > > > Just nit, I saw that the recover case is using > > `UUID::random().toString()` to s

Re: Review Request 51402: Added nested container check in provisioner destroy.

> On Sept. 5, 2016, 7:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 432-434 > > > > > > Just a question, how do we ensure when a container is being destroyed, > > al

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

> On Aug. 30, 2016, 3:56 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp, lines 194-196 > > > > > > You don't really need to check if the subcontainers are empty here. Fixed. - Gilbe

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/ --- (Updated Sept. 7, 2016, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/ --- (Updated Sept. 7, 2016, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51393: Added unit test for provisioner recursive listContainers().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/ --- (Updated Sept. 7, 2016, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51402: Added nested container check in provisioner destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/ --- (Updated Sept. 7, 2016, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51503: Fixed appc provisioner tests to use absolute work directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51503/ --- (Updated Sept. 7, 2016, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49688: Added cmake build variables for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 51674: Supported mesos containerizer destroy to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51674/#review148032 --- This patch does not look correct. I think we need a top level des

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Sept. 7, 2016, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Sept. 7, 2016, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 7, 2016, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 7, 2016, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 7, 2016, 5:56 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 7, 2016, 5:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Sept. 7, 2016, 5:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

> On Sept. 7, 2016, 1 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1540-1542 > > > > > > Given that this case is very specific for systems without a dependency > > o

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review148047 --- Ship it! Ship It! - Anindya Sinha On Sept. 7, 2016, 5:16 p.m

Re: Review Request 46220: Added documentation for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/#review148043 --- Fix it, then Ship it! This is great! Thanks for being so thorou

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review148042 --- Patch looks great! Reviews applied: [46187] Passed command: expo

  1   2   >