Re: Review Request 52462: Ported ReviewBot script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52462/#review15 --- Bad patch! Reviews applied: [52462, 52461] Failed command: ./sup

Re: Review Request 52466: Simplified the destroy logic in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52466/#review151110 --- Ship it! Ship It! - Benjamin Mahler On Oct. 1, 2016, 1:21 a.

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 1, 2016, 1:35 a.m.) Review request for mesos and Joseph Wu. Bug

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 1, 2016, 1:34 a.m.) Review request for mesos and Joseph Wu. Bug

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 1:34 a.m.) Review request for mesos and Joseph Wu. Sum

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 1, 2016, 1:33 a.m.) Review request for mesos and Joseph Wu. Sum

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 1, 2016, 1:33 a.m.) Review request for mesos and Joseph Wu. Sum

Review Request 52466: Simplified the destroy logic in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52466/ --- Review request for mesos, Benjamin Mahler and Gilbert Song. Repository: mesos

Review Request 52465: Fixed the race in master update slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52465/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 52438: Reduce log level to verbose MESOS-6295.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52438/#review151065 --- Ship it! Note: I'm going to tweak the commit message ("descript

Review Request 52462: Ported ReviewBot script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52462/ --- Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Al

Review Request 52461: Ported apply-reviews.py script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52461/ --- Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Al

Re: Review Request 52450: Simplied the buildPath logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52450/#review151108 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 5:03 p.m

Re: Review Request 52450: Simplied the buildPath logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52450/ --- (Updated Oct. 1, 2016, 12:03 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 52450: Simplied the buildPath logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52450/#review151107 --- src/slave/containerizer/mesos/paths.cpp (lines 50 - 52)

Re: Review Request 52460: Ignored cleanup request for unknown containers in posix isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52460/#review151106 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 4:18 p.m

Re: Review Request 52459: Ignored error in posix launcher destroy if the container is unknown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52459/#review151105 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 4:17 p.m

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 11:22 p.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 11:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 146-149 > > > > > > termination could be None, right? Calling error will an assertion > > failure. Yes, of course. S

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151103 --- - Kevin Klues On Sept. 30, 2016, 11:08 p.m., Kevin Klues wrote:

Review Request 52460: Ignored cleanup request for unknown containers in posix isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52460/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 52459: Ignored error in posix launcher destroy if the container is unknown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52459/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151102 --- src/slave/containerizer/mesos/paths.cpp (lines 146 - 149)

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 9:52 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 711-713 > > > > > > Can you introduce a helper in paths.hpp|cpp: > > > > ``` > > paths::getContain

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 11:08 p.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 9:52 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 711-713 > > > > > > Can you introduce a helper in paths.hpp|cpp: > > > > ``` > > paths::getContain

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151092 --- Fix it, then Ship it! src/slave/containerizer/mesos/containeri

Review Request 52450: Simplied the buildPath logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52450/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 9:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151090 --- src/tests/containerizer/nested_container_tests.cpp (line 117)

Re: Review Request 52415: Extended buildPath to support more modes.

> On Sept. 30, 2016, 5:20 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 46-64 > > > > > > I think the code is fine, but suggestion on simplifying: > > > > const string path

Re: Review Request 52444: Fixed the MesosContainerizer destroy issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52444/ --- (Updated Sept. 30, 2016, 9:14 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 52415: Extended buildPath to support more modes.

> On Sept. 30, 2016, 5:20 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 46-64 > > > > > > I think the code is fine, but suggestion on simplifying: > > > > const string path

Re: Review Request 52448: Fixed a CNI test that might cause a failed container destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52448/#review151086 --- Ship it! Ship It! - Avinash sridharan On Sept. 30, 2016, 8:4

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151084 --- Fix it, then Ship it! LGTM. src/slave/containerizer/mesos/con

Re: Review Request 52444: Fixed the MesosContainerizer destroy issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52444/#review151085 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 1:32 p.m

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 8:57 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Repository: mes

Re: Review Request 52415: Extended buildPath to support more modes.

> On Sept. 30, 2016, 3:36 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/paths.hpp, lines 57-60 > > > > > > To keep similar semantics as before, maybe it makes sense to set > > defaults for separator and

Re: Review Request 52415: Extended buildPath to support more modes.

> On Sept. 30, 2016, 5:20 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 46-64 > > > > > > I think the code is fine, but suggestion on simplifying: > > > > const string path

Re: Review Request 52445: Used posix launcher for multiple slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52445/#review151081 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 1:33 p.m

Review Request 52448: Fixed a CNI test that might cause a failed container destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52448/ --- Review request for mesos, Avinash sridharan and Gilbert Song. Repository: mesos

Re: Review Request 52442: Added logging for MesosContainerizer internal state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52442/#review151080 --- Ship it! Ship It! - Gilbert Song On Sept. 30, 2016, 1:28 p.m

Review Request 52445: Used posix launcher for multiple slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52445/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 52444: Fixed the MesosContainerizer destroy issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52444/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 52440: Fixed master to properly handle pending tasks.

> On Sept. 30, 2016, 8:23 p.m., Anand Mazumdar wrote: > > src/master/master.cpp, line 3689 > > > > > > Can we log here before we remove the tasks? as discussed offline, we don't log about removing pending tasks in

Review Request 52442: Added logging for MesosContainerizer internal state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52442/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 52440: Fixed master to properly handle pending tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52440/#review151069 --- Fix it, then Ship it! LGTM. src/master/master.cpp (line 3689)

Re: Review Request 52440: Fixed master to properly handle pending tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52440/ --- (Updated Sept. 30, 2016, 8:21 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 52439: Add Zhitao Li to contributor.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52439/#review151075 --- Ship it! lgtm - Xiaojian Huang On Sept. 30, 2016, 8:08 p.m.,

Re: Review Request 52439: Add Zhitao Li to contributor.yaml.

> On Sept. 30, 2016, 7:30 p.m., Vinod Kone wrote: > > Ship It! > > Xiaojian Huang wrote: > Please hold off a bit :) Added affiliation and uber.com email. - Zhitao --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 52439: Add Zhitao Li to contributor.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52439/ --- (Updated Sept. 30, 2016, 8:08 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52439: Add Zhitao Li to contributor.yaml.

> On Sept. 30, 2016, 7:30 p.m., Vinod Kone wrote: > > Ship It! Please hold off a bit :) - Xiaojian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52439/#review151064

Review Request 52440: Fixed master to properly handle pending tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52440/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Bugs: MESOS-6299

Re: Review Request 52439: Add Zhitao Li to contributor.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52439/#review151064 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2016, 7:18 p.m.,

Re: Review Request 52438: Reduce log level to verbose MESOS-6295.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52438/#review151063 --- Ship it! Ship It! - Zhitao Li On Sept. 30, 2016, 7:17 p.m.,

Review Request 52439: Add Zhitao Li to contributor.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52439/ --- Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Vinod Kone.

Review Request 52438: Reduce log level to verbose MESOS-6295.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52438/ --- Review request for mesos, Joseph Wu and Zhitao Li. Bugs: MESOS-6295 https:/

Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

> On Sept. 30, 2016, 5:23 p.m., haosdent huang wrote: > > It is flaky in slow machine because advance Clock before statusUpdate. May > > refer to https://reviews.apache.org/r/47089/diff/3#index_header about how > > to fix it. Never mind, I discard that stale patch. - haosdent -

Re: Review Request 52435: Fixed children list issue and log in containerizer destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52435/ --- (Updated Sept. 30, 2016, 11:20 a.m.) Review request for mesos, Artem Harutyunya

Review Request 52435: Fixed children list issue and log in containerizer destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52435/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Vinod Kone. Repository

Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/ --- (Updated Sept. 30, 2016, 6:12 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52434: Improved handling of tmp file creation in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/#review151041 --- Ship it! Ship It! - haosdent huang On Sept. 30, 2016, 5:15 p

Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151040 --- It is flaky in slow machine because advance Clock before statusUpd

Re: Review Request 52415: Extended buildPath to support more modes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52415/#review151038 --- Fix it, then Ship it! src/slave/containerizer/mesos/paths.cpp

Re: Review Request 52431: Reduced boilerplate from health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52431/#review151037 --- Ship it! Ship It! - haosdent huang On Sept. 30, 2016, 5:15 p

Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository: m

Review Request 52434: Improved handling of tmp file creation in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository: m

Review Request 52431: Reduced boilerplate from health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52431/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository: m

Review Request 52431: Reduced boilerplate from health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52431/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository: m

Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository: m

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review151036 --- Bad patch! Reviews applied: [52311, 52310, 52309, 52308] Failed

Re: Review Request 52415: Extended buildPath to support more modes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52415/#review151025 --- Fix it, then Ship it! src/slave/containerizer/mesos/linux_laun

Re: Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.

> On Sept. 30, 2016, 3:19 p.m., Benjamin Hindman wrote: > > > > Benjamin Hindman wrote: > FYI, if we factor out `parse` so others can use it as well we won't have > `flags` (so we can't remove `flags.cgroups_root` from the prefix), which is > why this function originally wasn't a `LinuxLau

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 30, 2016, 3:30 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 3:29 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 3:29 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 3:28 p.m.) Review request for mesos and Joseph Wu. S

Re: Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.

> On Sept. 30, 2016, 3:19 p.m., Benjamin Hindman wrote: > > FYI, if we factor out `parse` so others can use it as well we won't have `flags` (so we can't remove `flags.cgroups_root` from the prefix), which is why this function originally wasn't a `LinuxLauncher` member function and we removed

Re: Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52416/#review151021 --- Fix it, then Ship it! src/slave/containerizer/mesos/linux_laun

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:49 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 30, 2016, 2:50 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 2:50 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52311: Fix removed empty lines from slave.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 2:48 p.m.) Review request for mesos and Joseph Wu. S

Review Request 52424: Fix removed empty lines from slave.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52424/ --- Review request for mesos. Repository: mesos Description --- Fix removed

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:17 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 2:17 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52309: Set the user to stderr-logger binary too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 2:17 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 30, 2016, 2:16 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review151016 --- Patch looks great! Reviews applied: [52412] Passed command: expo

Re: Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52416/#review151008 --- Patch looks great! Reviews applied: [52415, 52416] Passed comman

Re: Review Request 51784: Supported merging the launch command from isolators.

> On Sept. 12, 2016, 10:16 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1109 > > > > > > Could we just have `arguments` MergeFrom? Because singular field (e.g., > > `value`) m

Re: Review Request 52357: Improved handling of health check failures within the grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/ --- (Updated Sept. 30, 2016, 11:29 a.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review151006 --- Patch looks great! Reviews applied: [51009] Passed command: expo

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review151001 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Re: Review Request 52357: Improved handling of health check failures within the grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review150994 --- Patch looks great! Reviews applied: [52357] Passed command: expo