Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review156284 --- Ship it! src/health-check/health_checker.hpp (line 122)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for the

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156282 --- Patch looks great! Reviews applied: [53704, 53837] Passed comman

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review156280 --- Ship it! We might want to update the description of the commit

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Nov. 18, 2016, 5:14 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 17, 2016, 5:20 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, line 201 > > > > > > Consolidate this with `case Shard::STAGING`? > > > > We can just do: > > > >

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 18, 2016, 5:13 a.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Nov. 18, 2016, 5:14 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 18, 2016, 5:07 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Nov. 18, 2016, 4:32 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/#review156277 --- Patch looks great! Reviews applied: [52308, 52310, 53473, 53699]

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156259 --- src/tests/containerizer/rootfs.cpp (line 58)

Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/#review156270 --- Patch looks great! Reviews applied: [53853] Passed command: expo

Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53474/#review156246 --- Ship it! 3rdparty/stout/include/stout/windows/error.hpp (lines

Re: Review Request 52653: Modified a test to use the updated Bytes operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52653/#review156257 --- Ship it! Ship It! - Michael Park On Oct. 7, 2016, 3:19 p.m.,

Re: Review Request 52652: Changed Bytes operators to take unsigned integers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52652/#review156256 --- Ship it! Ship It! - Michael Park On Oct. 7, 2016, 3:19 p.m.,

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review156252 --- Ship it! Ship It! - Michael Park On Nov. 9, 2016, 11:05 a.m.

Re: Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53850/#review156254 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review156253 --- Ship it! Ship It! - Michael Park On Nov. 9, 2016, 11:07 a.m.

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review156251 --- Ship it! Ship It! - Michael Park On Nov. 8, 2016, 9:40 a.m.,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review156250 --- Ship it! Ship It! - Michael Park On Nov. 9, 2016, 11:37 a.m.

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/#review156247 --- Fix it, then Ship it! This patch is code movement only right? W

Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53474/ --- (Updated Nov. 17, 2016, 9:26 p.m.) Review request for mesos, Alex Clemmer and M

Re: Review Request 53475: Use explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53475/ --- (Updated Nov. 17, 2016, 9:25 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review156240 --- Fix it, then Ship it! 3rdparty/stout/tests/json_tests.cpp (lin

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review156238 --- 3rdparty/libprocess/src/decoder.hpp (line 21)

Re: Review Request 53842: Add role specific metrics for sorting runs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53842/#review156237 --- Patch looks great! Reviews applied: [53839, 53840, 53841, 53842]

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 17, 2016, 8:42 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53475: Use explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53475/#review156236 --- 3rdparty/libprocess/src/libevent_ssl_socket.cpp (line 166)

Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53474/ --- (Updated Nov. 17, 2016, 7:07 p.m.) Review request for mesos, Alex Clemmer and M

Re: Review Request 53475: Use explicit error codes in ErrnoError and SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53475/ --- (Updated Nov. 17, 2016, 7:08 p.m.) Review request for mesos and Michael Park.

Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.

> On Nov. 16, 2016, 10:25 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/posix/rmdir.hpp, lines 57-58 > > > > > > This is great! > > > > It seems like we have more opportunities to update here:

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156226 --- Patch looks great! Reviews applied: [53704, 53837] Passed comman

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 6, 2016, 9:25 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 470-476 > > > > > > I think it's sufficient to have the following states. (We should use a > > minimun numbe

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 6, 2016, 9:25 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 470-476 > > > > > > I think it's sufficient to have the following states. (We should use a > > minimun numbe

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156082 --- src/examples/persistent_volume_framework.cpp (lines 33 - 37)

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/#review156217 --- src/slave/container_loggers/CMakeLists.txt (line 25)

Re: Review Request 53761: CMake: Add a target between MESOS_TARGET and MESOS_PROTOBUFs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53761/#review156215 --- cmake/MesosConfigure.cmake (line 145)

Re: Review Request 53759: CMake: Change libprocess to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53759/#review156214 --- 3rdparty/libprocess/src/CMakeLists.txt (line 93)

Re: Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53754/#review156212 --- src/examples/CMakeLists.txt (line 24)

Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Jie Yu. Repositor

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53327/#review156211 --- src/tests/cmake/MesosTestsConfigure.cmake (lines 70 - 71)

Re: Review Request 53832: Fixing broken link for the app frameowrks development guide page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53832/#review156209 --- Patch looks great! Reviews applied: [53832] Passed command: expo

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53473: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bu

Review Request 53848: Added support for pulling Docker images by digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53848/ --- Review request for mesos. Bugs: MESOS-3505 https://issues.apache.org/jira/b

Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/ --- Review request for mesos. Bugs: MESOS-3505 https://issues.apache.org/jira/b

Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53850/ --- Review request for mesos. Bugs: MESOS-3505 https://issues.apache.org/jira/b

Re: Review Request 53541: WIP: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review156189 --- Nice work with the subclassed NestedContainerObjectApprover. I'd r