Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Nov. 21, 2016, 7:18 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 138 > > > > > > You should bounds-check the path here since, `sun_path` is only 108 > > bytes. Also,

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review156441 --- Patch looks great! Reviews applied: [53644, 53645] Passed

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 21, 2016, 4:46 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 21, 2016, 4:35 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53262: Added DNT to Powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53262/#review156433 --- Patch looks great! Reviews applied: [53262] Passed command:

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/ --- (Updated Nov. 21, 2016, 11:17 a.m.) Review request for mesos, Avinash

Review Request 53262: Added DNT to Powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53262/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 53624: Add a content type option to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/#review156432 --- src/cli/execute.cpp (line 807)

Re: Review Request 53644: Added parse function for v1::TaskInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53644/ --- (Updated Nov. 21, 2016, 9:57 a.m.) Review request for mesos, Avinash

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > include/mesos/v1/allocator/allocator.proto, lines 21-22 > > > > > > These changes seem unrelated to this change i.e., java protos > > generation. We prefer

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/#review156430 --- Bad patch! Reviews applied: [53939, 53837, 53938, 53936, 53704]

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review156427 --- 3rdparty/libprocess/include/process/address.hpp (line 124)

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- (Updated Nov. 20, 2016, 11:09 p.m.) Review request for mesos, Benjamin

Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/ --- (Updated Nov. 20, 2016, 11:04 p.m.) Review request for mesos, Benjamin

Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/ --- Review request for mesos. Repository: mesos Description --- For now,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 20, 2016, 11:02 p.m.) Review request for mesos, Benjamin

Re: Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/ --- (Updated Nov. 20, 2016, 10:37 p.m.) Review request for mesos, Benjamin

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156426 --- Bad review! Reviews applied: [53837, 53936, 53704, 53462, 53461,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 20, 2016, 9:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53372: MESOS-5662: Fixed parent class SetUpTestCase calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53372/#review156425 --- Ship it! I would cleanup the commit summary/description a bit

Re: Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/ --- (Updated Nov. 20, 2016, 9:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 --- Nice first patch and welcome to the community! - Can you update

Re: Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/ --- (Updated Nov. 20, 2016, 8:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 20, 2016, 8:35 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 53936: Added agent flags to enable/disable launching an io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.

Re: Review Request 53704: Added a level of indirection for logger through an IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/ --- (Updated Nov. 20, 2016, 8:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53654: Avoided unnecessary copies of `HttpConnection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53654/#review156422 --- Ship it! LGTM, thanks for the cleanup. - Anand Mazumdar On

Re: Review Request 53934: Always initialize all ObjectApprover member vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53934/#review156420 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 20, 2016,

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 20, 2016, 7:19 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 53934: Always initialize all ObjectApprover member vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53934/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.

Re: Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/ --- (Updated Nov. 20, 2016, 6:52 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 53610: Added health checks documentation.

> On Nov. 10, 2016, 2:44 p.m., Gastón Kleiman wrote: > > docs/health-checks.md, line 49 > > > > > > "an executor knows what a task means"? Will kill that phrase entirely. > On Nov. 10, 2016, 2:44 p.m., Gastón

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/#review156418 --- Patch looks great! Reviews applied: [46227, 52980, 46228, 46229,

Re: Review Request 53610: Added health checks documentation.

> On Nov. 9, 2016, 5:32 p.m., haosdent huang wrote: > > docs/health-checks.md, line 29 > > > > > > s/functionality/functionalities/g I believe it is fine to use singular here. That's what my dictionary says: "the

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/ --- (Updated Nov. 20, 2016, 4:51 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46228: Create persistent volume with a supplied user.

> On Nov. 15, 2016, 8 p.m., Greg Mann wrote: > > src/slave/slave.cpp, lines 2848-2850 > > > > > > What's the rationale for including the sticky bit here? I wonder if the > > gain in security is worth the

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/ --- (Updated Nov. 20, 2016, 4:51 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46228: Create persistent volume with a supplied user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/ --- (Updated Nov. 20, 2016, 4:50 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52980/ --- (Updated Nov. 20, 2016, 4:50 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/ --- (Updated Nov. 20, 2016, 4:50 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

> On Nov. 18, 2016, 8:56 a.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 371 > > > > > > Still want these timeout variables? Refer @gaston's comment at

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 20, 2016, 9:18 a.m.) Review request for mesos, Benjamin Hindman,