Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote: > > src/checks/checker.cpp > > Line 86 (original), 89 (patched) > > > > > > please no abbreviations like this, it is unclear what this function > > does. Is it

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 8, 2018, 10:49 p.m., Gaston Kleiman wrote: > > src/checks/checker_process.cpp > > Lines 333-339 (patched) > > > > > > In my opinion the following is easier to understand: > > > > ``` > > #ifdef

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote: > > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ? > > Akash Gupta wrote: > Yeah, I think it will fix that issue, but I have to confirm it. Please do! And if it does fix it, adjust the ticket reference according

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/ --- (Updated Feb. 12, 2018, 11:56 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/#review197253 --- PASS: Mesos patch 65348 was successfully built and tested. Review

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/#review197254 --- Patch looks great! Reviews applied: [65348] Passed command: expo

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 243-249 (patched) > > > > > > I think it is safe to use this function because it is only accessed >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197256 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 654 (patched) <

Re: Review Request 65548: Added `Event::Update` and `v1::scheduler::TaskStatus` ostream operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65548/#review197257 --- Ship it! Ship It! - Qian Zhang On Feb. 8, 2018, 2:57 a.m., G

Re: Review Request 65549: Improved some default executor log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65549/#review197258 --- Ship it! Ship It! - Qian Zhang On Feb. 10, 2018, 2:34 p.m.,

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/ --- (Updated Feb. 12, 2018, 1:24 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 65160: Removed some redundant `get` calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/ --- (Updated Feb. 12, 2018, 3:07 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65161/ --- (Updated Feb. 12, 2018, 3:07 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/ --- (Updated Feb. 12, 2018, 3:07 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 197-240 (patched) > > > > > > I would still merge these two functions. Since it is for internal use

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review197261 --- PASS: Mesos patch 65545 was successfully built and tested. Review

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/#review197267 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/ --- (Updated Feb. 12, 2018, 4:55 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197276 --- Ship it! Ship It! - Andrei Budnik On Feb. 9, 2018, 12:55 p.m

Re: Review Request 65569: Install ping for docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65569/#review197278 --- Ship it! Ship It! - James Peach On Feb. 9, 2018, 10:51 a.m.,

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/#review197279 --- PASS: Mesos patch 65162 was successfully built and tested. Review

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

> On Feb. 8, 2018, 8:22 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 2186 (patched) > > > > > > s/Leader detector indicated no master elected/No master was elected/ > > > > More importantly,

Re: Review Request 65504: Made master set `launch_executor` in the RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65504/#review197286 --- Fix it, then Ship it! src/master/master.cpp Lines 4920-4924 (o

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/#review197287 --- Ship it! I thought I'd finished reviewing because I reached the

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On Feb. 10, 2018, 2:22 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/uri_disk_profile.cpp > > Line 248 (original), 242 (patched) > > > > > > This should be removed to support missing profiles from

Re: Review Request 65160: Removed some redundant `get` calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/#review197291 --- Ship it! I noticed that this didn't apply the automated reviewe

Re: Review Request 65162: Removed some redundant `get` calls.

> On Feb. 12, 2018, 11:05 a.m., Andrew Schwartzmeyer wrote: > > I thought I'd finished reviewing because I reached the bottom of the page, > > but it's split across 5 pages. > > > > However, this was done automatically, and the first page of changes all > > appear sane. Moreover, the chain pas

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65161/#review197290 --- Ship it! 3rdparty/libprocess/include/process/gtest.hpp Lines 4

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated Feb. 12, 2018, 7:07 p.m.) Review request for mesos, James DeFelice, Ji

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 8, 2018, 2:49 p.m., Gaston Kleiman wrote: > > src/checks/checker_process.cpp > > Lines 333-339 (patched) > > > > > > In my opinion the following is easier to understand: > > > > ``` > > #ifdef

Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote: > > I am wondering whether it wouldn't be simpler to have the site setup just > > generate output for the currently checked-out version and dump that into > > some version-specific output folder. We could then have some CI setup > > execute

Review Request 65613: Fixed a bug where MockSlave `id` is not properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65613/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 65449: Fixed an bug where executor info lingers on master if failed to launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65449/#review197293 --- Fix it, then Ship it! src/slave/slave.cpp Line 1909 (original)

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197299 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65549: Improved some default executor log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65549/#review197302 --- Ship it! Ship It! - Vinod Kone On Feb. 10, 2018, 6:34 a.m.,

Re: Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197300 --- Fix it, then Ship it! Description: s/fail-launched deafult/defa

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/ --- (Updated Feb. 12, 2018, 11:48 a.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197298 --- Mostly LGTM... some suggestions: src/launcher/default_executor.c

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 7, 2018, 6:19 p.m., Benjamin Mahler wrote: > > src/tests/mock_slave.cpp > > Lines 107-108 (original), 107-109 (patched) > > > > > > What's going on here? > > Meng Zhu wrote: > For the agent failover te

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 9, 2018, 5:17 p.m., Benjamin Mahler wrote: > > src/tests/mesos.cpp > > Line 391 (original), 400 (patched) > > > > > > I realize this is a copy/paste, but do you know why we don't start() > > when mock is t

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197306 --- PASS: Mesos patch 64211 was successfully built and tested. Review

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/#review197307 --- Patch looks great! Reviews applied: [65160, 65161, 65162] Passed

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197304 --- Fix it, then Ship it! src/launcher/default_executor.cpp Line 3

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 7:57 p.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Line 1479 (original), 1492 (patched) > > > > > > This booleans seems like a remnant of the time when the default > > executo

Re: Review Request 65449: Fixed an bug where executor info lingers on master if failed to launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65449/ --- (Updated Feb. 12, 2018, 12:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65552: Added a regression test for MESOS-8468.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/#review197312 --- src/tests/default_executor_tests.cpp Lines 3276 (patched)

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197314 --- src/launcher/default_executor.cpp Line 786 (original), 788 (patch

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197315 --- PASS: Mesos patch 65497 was successfully built and tested. Review

Re: Review Request 65160: Removed some redundant `get` calls in stout.

> On Feb. 12, 2018, 8:12 p.m., Andrew Schwartzmeyer wrote: > > I noticed that this didn't apply the automated reviewer to any Windows-only > > files. On the one hand, I have clean-up patches in progress that would be > > no fun to rebase afterward, on the other hand, why were those files > > i

Re: Review Request 65593: Added a test to check default executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197319 --- PASS: Mesos patch 65593 was successfully built and tested. Review

Re: Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/#review197320 --- Ship it! LGTM. src/launcher/default_executor.cpp Line 377 (or

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/#review197321 --- Ship it! This shouldn't cause any problems on non-Windows (and

Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote: > > I am wondering whether it wouldn't be simpler to have the site setup just > > generate output for the currently checked-out version and dump that into > > some version-specific output folder. We could then have some CI setup > > execute

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 12, 2018, 10:50 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/ --- (Updated Feb. 12, 2018, 10:50 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/ --- (Updated Feb. 12, 2018, 3:08 p.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 65162: Removed some redundant `get` calls.

> On Feb. 12, 2018, 8:05 p.m., Andrew Schwartzmeyer wrote: > > I thought I'd finished reviewing because I reached the bottom of the page, > > but it's split across 5 pages. > > > > However, this was done automatically, and the first page of changes all > > appear sane. Moreover, the chain pass

Re: Review Request 65548: Added `Event::Update` and `v1::scheduler::TaskStatus` ostream operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65548/ --- (Updated Feb. 12, 2018, 3:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- (Updated Feb. 12, 2018, 3:13 p.m.) Review request for mesos, Anand Mazumdar, Qi

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 12, 2018, 11:16 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65552: Added a regression test for MESOS-8468.

> On Feb. 12, 2018, 12:35 p.m., Joseph Wu wrote: > > src/tests/default_executor_tests.cpp > > Lines 3450-3461 (patched) > > > > > > Is it possible for the following race to occur? > > > > * Executor launche

Re: Review Request 65552: Added a regression test for MESOS-8468.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/ --- (Updated Feb. 12, 2018, 3:24 p.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

> On Feb. 12, 2018, 12:13 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 349 (original), 349 (patched) > > > > > > Not yours, but I think we can kill this. I think this was added pre > > mult

Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs: MESOS-67

Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher plugins on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65618/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs: MESOS-67

Review Request 65619: Windows: Modified build system to build hadoop plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65619/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs: MESOS-67

Review Request 65620: Windows: Enabled `HadoopFetcherPlugin.*` tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65620/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs: MESOS-67

Re: Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/ --- (Updated Feb. 12, 2018, 11:35 p.m.) Review request for mesos, Andrew Schwartzme

Review Request 65616: Removed outdated executor-wide launched flag from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65616/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 11:57 a.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Line 1479 (original), 1492 (patched) > > > > > > This booleans seems like a remnant of the time when the default > > execut

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 12, 2018, 3:41 p.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 12:37 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 786 (original), 788 (patched) > > > > > > If a launch for nested container fails, don't we get `NotFound`? This didn't

Re: Review Request 65616: Removed outdated executor-wide launched flag from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65616/#review197330 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/#review197331 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 3

Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher plugins on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65618/#review197332 --- src/uri/fetcher.hpp Lines 40-49 (original), 40-50 (patched)

Re: Review Request 65619: Windows: Modified build system to build hadoop plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65619/#review197333 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 3

Re: Review Request 65620: Windows: Enabled `HadoopFetcherPlugin.*` tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65620/#review197334 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 3

Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher plugins on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65618/#review197335 --- I looked at MESOS-5473, and I had previously closed it because it

Re: Review Request 65449: Fixed an bug where executor info lingers on master if failed to launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65449/ --- (Updated Feb. 12, 2018, 4:11 p.m.) Review request for mesos, Benjamin Mahler, C

Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- Review request for mesos. Bugs: MESOS-8498 https://issues.apache.org/jira/b

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 13, 2018, 12:24 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/#review197336 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 2

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197337 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 2

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197338 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 8, 2018, 9:

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197340 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 8, 2018, 9:

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/#review197339 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 8, 2018, 9:

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197341 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 3

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197343 --- src/tests/containerizer/docker_common.hpp Lines 1-18 (patched)

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review197342 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197344 --- src/tests/containerizer/docker_common.hpp Lines 126 (patched)

Re: Review Request 65620: Windows: Enabled `HadoopFetcherPlugin.*` tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65620/#review197345 --- PASS: Mesos patch 65620 was successfully built and tested. Review

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review197347 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 4, 2018, 4:

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review197346 --- This patch looks like it's still pending updates (i.e. it has open

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197348 --- src/checks/checks_runtime.hpp Lines 1-15 (patched)

Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher plugins on Windows.

> On Feb. 13, 2018, 12:08 a.m., Andrew Schwartzmeyer wrote: > > I looked at MESOS-5473, and I had previously closed it because it didn't > > make sense. > > > > Would you open a new issue: "Enable Docker fetcher plugin on Windows" and > > update the comments here? Done, MESOS-8570: Enable Doc

Re: Review Request 65619: Windows: Modified build system to build hadoop plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65619/ --- (Updated Feb. 13, 2018, 12:57 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/ --- (Updated Feb. 13, 2018, 12:58 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 65620: Windows: Enabled `HadoopFetcherPlugin.*` tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65620/ --- (Updated Feb. 13, 2018, 12:58 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher plugins on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65618/ --- (Updated Feb. 13, 2018, 12:59 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 12:55 a.m., Vinod Kone wrote: > > src/docker/executor.cpp > > Lines 280 (patched) > > > > > > when can this be None()? > > Qian Zhang wrote: > According to this comment > https://github.com/

  1   2   >