[GitHub] asfgit closed pull request #319: Fixed incorrect RPM build settings.

asfgit closed pull request #319: Fixed incorrect RPM build settings. URL: https://github.com/apache/mesos/pull/319 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210918 --- PASS: Mesos patch 69452 was successfully built and tested.

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

> On Nov. 27, 2018, 3:33 p.m., Benno Evers wrote: > > src/tests/api_tests.cpp > > Lines 3688 (patched) > > > > > > To be honest, I don't completely understand if this is creating some > > special "unclean

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 28, 2018, 12:40 a.m.) Review request for mesos, Alexander

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/#review210916 --- PASS: Mesos patch 69463 was successfully built and tested.

Re: Review Request 69157: Fixed handling for offer operation updates.

> On Nov. 27, 2018, 11:40 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 8037 (original), 8037 (patched) > > > > > > Hmm it looks like Chun-Hung's comment was resolved, but this line still > > uses

Re: Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210897 --- src/slave/slave.cpp Lines 8016-8037 (original), 8016-8037

Re: Review Request 69464: Made the `createTask` helper work for both v0 and v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69464/#review210915 --- Ship it! Ship It! - Benjamin Mahler On Nov. 27, 2018, 11:05

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210914 --- src/master/master.hpp Lines 2594-2609 (original), 2596-2619

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210891 --- The basic approach still looks good to me, so this review mostly

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/ --- (Updated Nov. 27, 2018, 11:07 p.m.) Review request for mesos, Alexander

Review Request 69464: Made the `createTask` helper work for both v0 and v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69464/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 27, 2018, 11:01 p.m.) Review request for mesos, Alexander

Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

> On Nov. 27, 2018, 9:02 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Line 2599 (original), 2600-2604 (patched) > > > > > > Hm.. based on this comment, should we only be sending in the > >

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

> On Nov. 27, 2018, 9:16 p.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 3850 (patched) > > > > > > Maybe a TODO to simplify this test by having a test scheduler that > > knows how to launch

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

> On Nov. 27, 2018, 9:16 p.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 3850 (patched) > > > > > > Maybe a TODO to simplify this test by having a test scheduler that > > knows how to launch

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210905 --- Ship it! Thanks for the test! Have you run it in repetition to

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210904 --- Thanks for jumping on this and producing a fix! Some small edit

Re: Review Request 69458: Persisted the operation updates we sent out.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69458/#review210898 --- PASS: Mesos patch 69458 was successfully built and tested.

Re: Review Request 69157: Fixed handling for offer operation updates.

> On Nov. 20, 2018, 8:05 p.m., Chun-Hung Hsiao wrote: > > Could you update the commit message accordingly? Do you have a suggestion? - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

> On Nov. 20, 2018, 4:24 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8192-8201 (patched) > > > > > > We can get rid of this snippet and simply use `providerId`. Or, > > validate that

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/ --- (Updated Nov. 27, 2018, 7:03 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 69458: Persisted the operation updates we sent out.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69458/ --- Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Nov. 20, 2018, 2:57 a.m., Chun-Hung Hsiao wrote: > > include/mesos/scheduler/scheduler.proto > > Line 140 (original), 140 (patched) > > > > > > It seems more consistent with `TaskStatus` if we put `slave_id`

Re: Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- (Updated Nov. 27, 2018, 6:59 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/ --- (Updated Nov. 27, 2018, 7 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69449: Added the `DISCARD` blkio cgroup operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69449/#review210892 --- Ship it! Ship It! - Gilbert Song On Nov. 26, 2018, 12:38

Re: Review Request 69454: Added the autoconf `tar-pax` option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69454/#review210886 --- PASS: Mesos patch 69454 was successfully built and tested.