Re: Review Request 70441: Made CSI volume managers no longer maintain a list of services.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70441/#review214567 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214566 --- Patch looks great! Reviews applied: [70449] Passed command: expo

Re: Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70446/#review214565 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70398: [WIP] Fixed the URI fetcher image fetch test failure on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70398/#review214564 --- Ship it! Ship It! - Qian Zhang On April 6, 2019, 5:42 a.m.,

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214563 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/ --- (Updated April 11, 2019, 1:30 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/ --- (Updated April 10, 2019, 5:28 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/#review214561 --- Fix it, then Ship it! src/slave/http.cpp Lines 794 (patched) <

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214560 --- Fix it, then Ship it! LGTM modulo test code that I'll let Greg

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/ --- (Updated April 10, 2019, 5:02 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/#review214558 --- src/slave/http.cpp Lines 793 (patched)

Review Request 70450: Special cased HEARTBEAT call handling in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. Repository

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/ --- (Updated April 10, 2019, 11:55 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70449: Avoid publishing resources during HTTP executor resubscriptions.

> On April 10, 2019, 11:38 p.m., Vinod Kone wrote: > > I didn't look at the test. > > > > Also, typo in the description. s/resubscriptions/resubscribes/ I meant to use a noun ;) but sure let me change it. - Chun-Hung --- This is an aut

Re: Review Request 70449: Avoid publishing resources during HTTP executor resubscriptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214556 --- I didn't look at the test. Also, typo in the description. s/resub

Re: Review Request 70449: Avoid publishing resources during HTTP executor resubscriptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/ --- (Updated April 10, 2019, 11:36 p.m.) Review request for mesos, Benjamin Bannier

Review Request 70449: Avoid publishing resources during HTTP executor resubscriptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Vinod Kone. Bugs: ME

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214555 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70446/#review214554 --- are you going to add this option to the docker plugin? - Gilbert

Re: Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70446/#review214553 --- Ship it! Ship It! - Gilbert Song On April 10, 2019, 2:32 a.m

Re: Review Request 70443: Added an optional parameter `outputFileName` to the fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70443/#review214552 --- Ship it! Ship It! - Gilbert Song On April 10, 2019, 2:28 a.m

Re: Review Request 70445: Allowed caller to specify output file name for curl fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70445/#review214551 --- Ship it! Ship It! - Gilbert Song On April 10, 2019, 2:31 a.m

Re: Review Request 70444: Added an parameter `outputFileName` to the fetcher plugin interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70444/#review214550 --- Ship it! Ship It! - Gilbert Song On April 10, 2019, 2:30 a.m

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/#review214549 --- Patch looks great! Reviews applied: [70080, 70081, 70084] Passed

Re: Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70378/#review214548 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/#review214545 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70443: Added an optional parameter `outputFileName` to the fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70443/#review214544 --- Ship it! Ship It! - Gilbert Song On April 10, 2019, 2:28 a.m

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214543 --- Patch looks great! Reviews applied: [70408, 70377, 70379] Passed

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/#review214541 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/ --- (Updated April 10, 2019, 6:26 p.m.) Review request for mesos, Gilbert Song, Gre

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

> On April 4, 2019, 9:53 p.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 1194-1195 (patched) > > > > > > I'd write something like this: > > > > ``` > > Validates that the principal provi

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/ --- (Updated April 10, 2019, 3:35 p.m.) Review request for mesos and Gastón Kleiman

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/#review214532 --- Patch looks great! Reviews applied: [70387, 70388] Passed comman

Re: Review Request 70377: Added tests to check that framework cannot change its principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 10, 2019, 3:31 p.m.) Review request for mesos and Gastón Kleiman

Re: Review Request 70408: Deduplicated common validation code in Master::subscribe()'s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70408/ --- (Updated April 10, 2019, 3:29 p.m.) Review request for mesos and Gastón Kleiman

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/ --- (Updated April 10, 2019, 1:59 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 70387: Updated the bundled glog to 0.4.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70387/ --- (Updated April 10, 2019, 1:59 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/#review214531 --- FAIL: Failed to apply the dependent review: 70387. Failed command

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/ --- (Updated April 10, 2019, 12:40 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70446/#review214530 --- Patch looks great! Reviews applied: [70443, 70444, 70445, 70446]

Re: Review Request 70387: Updated the bundled glog to 0.4.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70387/ --- (Updated April 10, 2019, 12:39 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214526 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70446/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9715

Review Request 70445: Allowed caller to specify output file name for curl fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70445/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9715

Review Request 70444: Added an parameter `outputFileName` to the fetcher plugin interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70444/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9715

Review Request 70443: Added an optional parameter `outputFileName` to the fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70443/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9715

Re: Review Request 70439: Fixed `AgentFailoverHTTPExecutorUsingResourceProviderResources` flake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70439/#review214525 --- Ship it! Ship It! - Benjamin Bannier On April 10, 2019, 6:08

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214523 --- Patch looks great! Reviews applied: [70411, 70412] Passed comman