Re: Review Request 70686: Added a unit test for master operation authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70686/ --- (Updated May 22, 2019, 4:09 a.m.) Review request for mesos, Benjamin Bannier, G

Re: Review Request 70686: Added a unit test for master operation authorization.

> On May 21, 2019, 12:07 p.m., Benjamin Bannier wrote: > > src/tests/master_authorization_tests.cpp > > Lines 3317-3320 (patched) > > > > > > If you get rid of the `vector` `evolve` function in r/70683/ we'd > > cr

Re: Review Request 70683: Added helpers for evolving operation-related proto messages.

> On May 21, 2019, 12:07 p.m., Benjamin Bannier wrote: > > src/internal/evolve.hpp > > Lines 106-114 (original), 122-133 (patched) > > > > > > This helper doesn't seem to fit well, and we'd only use this helper in >

Re: Review Request 70683: Added a helper to devolve offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70683/ --- (Updated May 22, 2019, 4:06 a.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 70622: Added a unit test to verify if SLRP allows changes in volume context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70622/ --- (Updated May 22, 2019, 3:15 a.m.) Review request for mesos and Benjamin Bannier

Re: Review Request 70622: Added a unit test to verify if SLRP allows changes in volume context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70622/#review215441 --- Bad review! Reviews applied: [70622, 70621, 70620] Error: 2019-0

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/ --- (Updated May 22, 2019, 3:03 a.m.) Review request for mesos and Benjamin Bannier

Re: Review Request 70620: Made SLRP allow changes in volume context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/ --- (Updated May 22, 2019, 2:58 a.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70665/#review215438 --- Ship it! Ship It! - Benjamin Mahler On May 21, 2019, 1:40 p.

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

> On May 14, 2019, 11:37 a.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Line 1253 (original), 1244 (patched) > > > > > > It would be great to have some testing that `getVolumePath -> > > par

Re: Review Request 70678: Add containerizer support for masking paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70678/#review215433 --- Fix it, then Ship it! Good stuff! LGTM overall with some nits.

Re: Review Request 70696: Renamed sets of role names from 'roles' into 'roleNames'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70696/#review215430 --- Patch looks great! Reviews applied: [70693, 70694, 70695, 70696]

Re: Review Request 70628: Return 409 if `UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70628/#review215425 --- Ship it! Ship It! - Benjamin Bannier On May 11, 2019, 1:07 a

Review Request 70694: Renamed `suppressedRoles` in the allocator implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70694/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Repository: mesos Des

Review Request 70695: Renamed `*Roles` into `*RoleNames` in the allocator code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70695/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9701 ht

Review Request 70696: Renamed sets of role names from 'roles' into 'roleNames'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70696/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9701 ht

Review Request 70693: Renamed `role` into `roleName` throughout HierarchicalAllocatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70693/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9701 ht

Re: Review Request 70689: Improved log messages for SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70689/#review215412 --- Bad review! Reviews applied: [70689] Error: 2019-05-21 16:42:34

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215411 --- Patch looks great! Reviews applied: [70532, 70663, 70664, 70665,

Review Request 70691: Added more comments regarding `message QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70691/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 70690: Added `repeated QuotaConfig` to `QuotaStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70690/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70689: Improved log messages for SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70689/#review215410 --- Ship it! Ship It! - Jan-Philip Gehrcke On May 21, 2019, 2:33

Review Request 70689: Improved log messages for SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70689/ --- Review request for mesos and Jan-Philip Gehrcke. Repository: mesos Descriptio

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 21, 2019, 2:10 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 21, 2019, 1:56 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated May 21, 2019, 1:54 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 21, 2019, 1:54 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70670: Simplified the `Framework::update()` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70670/ --- (Updated May 21, 2019, 1:53 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70669/ --- (Updated May 21, 2019, 1:49 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70668/ --- (Updated May 21, 2019, 1:47 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

> On May 20, 2019, 6:19 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 667 (patched) > > > > > > Why did this need to be passed separately? Is there some reason > > `framework->pid` can't be used?

Re: Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70665/ --- (Updated May 21, 2019, 1:40 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70685: Removed the `TaskStatusUpdateIsTerminalState` matcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70685/#review215407 --- Ship it! Ship It! - Benjamin Bannier On May 21, 2019, 12:34

Re: Review Request 70620: Made SLRP allow changes in volume context.

> On May 14, 2019, 12:04 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 923 (original), 930 (patched) > > > > > > Let's create a dedicated error message. > > Chun-Hung Hsiao wr

Re: Review Request 70686: Added a unit test for master operation authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70686/#review215405 --- Fix it, then Ship it! This is a very exhaustive test, but sligh

Re: Review Request 70683: Added helpers for evolving operation-related proto messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70683/#review215403 --- Fix it, then Ship it! src/internal/evolve.hpp Lines 106-114 (o

Re: Review Request 70684: Changed the `*TaskIdEq` test matchers to take a `TaskID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70684/#review215404 --- Ship it! - Benjamin Bannier On May 21, 2019, 12:32 a.m., Chun

Re: Review Request 70618: Store framework sorters inside RoleInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/#review215402 --- After some thought, I think we should not do the refactoring at th

Re: Review Request 70679: Fixed comment to reflect the existence of sorters other than DRF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70679/#review215401 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Line 1862

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215400 --- Ship it! - Meng Zhu On May 20, 2019, 9:26 a.m., Andrei Sekret

Re: Review Request 70626: Refactored `untrackReservations()` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70626/#review215399 --- Ship it! Ship It! - Meng Zhu On May 20, 2019, 9:27 a.m., And