Re: Review Request 72161: Added patch for RapidJSON.

> On Feb. 28, 2020, 12:59 a.m., Benjamin Bannier wrote: > > Is the plan to upstream this patch? We usually try to enable building > > against unbundled dependencies and depending on custom behavior makes that > > impossible. My hunch would be to not make functional changes like the one > > in

Re: Review Request 72202: Fixed the broken PathTest.PathIteration on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72202/#review219808 --- Patch looks great! Reviews applied: [72201, 72202] Passed

Review Request 72202: Fixed the broken PathTest.PathIteration on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72202/ --- Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu. Bugs:

Review Request 72201: Fixed the broken PathTest.Relative on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72201/ --- Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu. Bugs:

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219804 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 716

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/#review219803 --- Fix it, then Ship it!

Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71955/#review219801 --- Please change the commit message to past-tense. - Greg Mann On

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219798 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 474

Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71955/#review219800 --- Ship it! Ship It! - Greg Mann On Jan. 6, 2020, 8:49 a.m.,

Re: Review Request 71952: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/#review219796 --- src/common/protobuf_utils.cpp Lines 398 (patched)

Re: Review Request 71952: Set resource limits when updating executor container.

> On Feb. 28, 2020, 5:25 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 11198 (patched) > > > > > > The similarity of this function body to some of the code in > > https://reviews.apache.org/r/71858/ is

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71951/#review219794 --- Ship it! Ship It! - Greg Mann On Jan. 5, 2020, 2:07 p.m.,

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219793 --- Ship it! Ship It! - Greg Mann On March 4, 2020, 1:43 a.m.,

Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/#review219792 ---

Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71886/#review219791 --- Fix it, then Ship it!

Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71885/#review219790 --- Ship it! Ship It! - Greg Mann On Jan. 5, 2020, 2:03 p.m.,

Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71884/#review219789 --- Ship it! Ship It! - Greg Mann On Jan. 5, 2020, 2:02 p.m.,