/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
Diff: https://reviews.apache.org/r/66657/diff/2/
Changes: https://reviews.apache.org/r/66657/diff/1-2/
Testing
---
Removed `~/.mesos/config.toml` and ran `mesos config show`.
Thanks,
Armand Grillet
(cli.tests.task.TestTaskPlugin) ... ok
--
Ran 6 tests in 13.934s
OK
```
Thanks,
Armand Grillet
(cli.tests.task.TestTaskPlugin) ... ok
--
Ran 6 tests in 13.934s
OK
```
Thanks,
Armand Grillet
--
Ran 5 tests in 9.656s
OK
```
Thanks,
Armand Grillet
-cli-tests` successfully.
Thanks,
Armand Grillet
(cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok
--
Ran 5 tests in 9.656s
OK
```
Thanks,
Armand Grillet
://reviews.apache.org/r/68714/diff/2/
Changes: https://reviews.apache.org/r/68714/diff/1-2/
Testing
---
None, I don't know how to test this script outside of Jenkins.
Thanks,
Armand Grillet
---
Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.
Diffs
-
support/jenkins/reviewbot.sh 57ae5a347e0b5834510766f2a9a5aa7f33fd21b9
Diff: https://reviews.apache.org/r/68714/diff/1/
Testing
---
None.
Thanks,
Armand Grillet
x27;s rename this file `.isort.cfg` according to the otpions offered by
https://github.com/timothycrosley/isort/wiki/isort-Settings
src/python/lib/tox.ini
Lines 22 (patched)
<https://reviews.apache.org/r/68654/#comment292673>
Let's use the latest version, `4.3.4`.
- Armand Gril
---
Tested manually, unit test in preparation.
Thanks,
Armand Grillet
Description
---
Added Robin Goegge to contributors list.
Diffs
-
docs/contributors.yaml 630ba4b2aa8cd2371b78b79f8e52c11fa230a4f6
Diff: https://reviews.apache.org/r/68686/diff/1/
Testing
---
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208488
---
Ship it!
Ship It!
- Armand Grillet
On Sept. 10, 2018, 6:36
is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> ---
>
> (Updated Sept. 7, 2018, 6:55 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin
&
nstead?
support/mesos-build/ubuntu-16.04.dockerfile
Lines 62 (patched)
<https://reviews.apache.org/r/68538/#comment292443>
Let's cut here.
- Armand Grillet
On Sept. 7, 2018, 6:55 p.m., Robin Gögge wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208465
---
Ship it!
Ship It!
- Armand Grillet
On sep. 7, 2018, 6:55
request.
Thanks,
Armand Grillet
)
<https://reviews.apache.org/r/68608/#comment291999>
Please update the docs.
support/python3/mesos-style.py
Line 196 (original), 199 (patched)
<https://reviews.apache.org/r/68608/#comment292000>
`i` is not `int`.
- Armand Grillet
On Sept. 3, 2018, 5:33 p.m., Armand G
on)
support/python3/push-commits.py:159:0: C0330: Wrong continued indentation (add
1 space).
'push',
^| (bad-continuation)
support/python3/push-commits.py:160:0: C0330: Wrong continued indentation (add
1 space).
remote,
^| (bad-continuation)
support/python3/push-commits.py:161:0: C0330: Wrong continued indentation (add
1 space).
'master:master'])
^| (bad-continuation)
```
After:
```
Checking 47 Python files
Total errors found: 0
```
Thanks,
Armand Grillet
,
Armand Grillet
/68566/diff/1/
Testing
---
Linted different files in the two modules.
Thanks,
Armand Grillet
,
Armand Grillet
python 3.6 in a later commit,
the last thing we want to lint when using Python 2 are the Python 2 suppport
scripts. This patch is thus correct.
- Armand Grillet
On Aug. 29, 2018, 4:14 p.m., Kevin Klues wrote:
>
> ---
> This is an auto
Python 3.7 and I have used versions that
include fixes for those.
Thanks,
Armand Grillet
scripts and saw that the error describe in MESOS-9186 is gone.
Multiple packages had issues with Python 3.7 and I have used versions that
include fixes for those.
Thanks,
Armand Grillet
sers/Armand/Code/apache-mesos/support/pylint.config
* Module mesos.http
E: 25, 0: Unable to import 'urlparse' (import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 4
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207878
---
Ship it!
Ship It!
- Armand Grillet
On Aug. 24, 2018, 3:40
.
```
Thanks,
Armand Grillet
port-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 2
```
Thanks,
Armand Grillet
import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 4
```
Thanks,
Armand Grillet
MESOS_GTEST_RUNNER_FLAGS can be used to set a default
set of flags. Flags passed on the command line always have precedence over
these defaults.
```
Thanks,
Armand Grillet
econd argument seems to be misssing to call
`verify_review(review_request, handler)`.
- Armand Grillet
On July 18, 2018, 8:36 a.m., Dragos Schebesch wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/67504/#comment290030>
Should be `python3`.
- Armand Grillet
On July 19, 2018, 3:39 p.m., Dragos Schebesch wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/67502/#comment290034>
Pylint complains that there are too many local variables, you can remove
`latest_diff_url` to have only 15 vars in the file.
- Armand Grillet
On July 19, 2018, 3:48 p.m., Dragos Schebesch
commit header and message should contain no
line that are more than 72 characters.
support/python3/get-review-ids.py
Lines 1 (patched)
<https://reviews.apache.org/r/67503/#comment290026>
Should be `python3`.
- Armand Grillet
On July 19, 2018, 3:48 p.m., Dragos Schebesch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68238/#review206902
---
Ship it!
Ship It!
- Armand Grillet
On Aug. 6, 2018, 6:10
src/python/lib/mesos/http.py
Lines 345 (patched)
<https://reviews.apache.org/r/67185/#comment290007>
Should these match the parameter names from `request()`?
- Armand Grillet
On June 28, 2018, 6:17 a.m., Eric Chung wrote:
>
> --
), 7 (patched)
<https://reviews.apache.org/r/67894/#comment289874>
Changes to that file can be removed following the Mesos CLI update to
Python 3.
- Armand Grillet
On July 12, 2018, 8:09 a.m., Eric Chung wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/#review206653
---
Ship it!
Ship It!
- Armand Grillet
On July 31, 2018, 2:40
tps://reviews.apache.org/r/68120/#comment289721>
This is the first time we use a ternary operator in this file but we use
some in `app.js` and it makes sense to use it here.
- Armand Grillet
On July 31, 2018, 2:40 a.m., Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206381
---
Ship it!
Ship It!
- Armand Grillet
On July 19, 2018, 3:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67995/#review206261
---
Ship it!
Ship It!
- Armand Grillet
On juil. 20, 2018, 7:07
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206125
---
On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
>
> ---
>
: https://reviews.apache.org/r/67910/diff/1-2/
Testing
---
Run the two `mesos-style.py` and `build-virtualenv` with `MESOS_SUPPORT_PYTHON`
set to 3 or not. Checked that the python intepreter installed in the virtual
environment was correct.
Thanks,
Armand Grillet
-virtualenv` then checked
`.virtualenv` content.
Thanks,
Armand Grillet
/1/
Testing
---
Run the two `mesos-style.py` and `build-virtualenv` with `MESOS_SUPPORT_PYTHON`
set to 3 or not. Checked that the python intepreter installed in the virtual
environment was correct.
Thanks,
Armand Grillet
otal errors found: 0
[MESOS-9073 a3509d402] Test.
1 file changed, 1 insertion(+), 1 deletion(-)
```
Thanks,
Armand Grillet
350ef909e3e7a1c927140cf4475547d704ac2ad5
Diff: https://reviews.apache.org/r/67906/diff/1/
Testing
---
Used `mesos-style` to check that tox was correctly running.
Thanks,
Armand Grillet
://reviews.apache.org/r/67855/diff/2/
Changes: https://reviews.apache.org/r/67855/diff/1-2/
Testing
---
Checked that this commit trigerred the script (I am using Python 3 by default).
Thanks,
Armand Grillet
are %s review requests that need verification`/`%s review requests
need verification`.
support/python3/verify-reviews.py
Lines 284 (patched)
<https://reviews.apache.org/r/67505/#comment288825>
Put the final space at the beginning of the next line inst
che.org/r/67504/#comment288812>
Put the final space at the beginning of the second line instead.
support/python3/post-build-result.py
Lines 92 (patched)
<https://reviews.apache.org/r/67504/#comment288817>
s/`Main method to post`/`Posts`.
- Arma
Add a newline after the `""""`.
support/python3/get-review-ids.py
Lines 42 (patched)
<https://reviews.apache.org/r/67503/#comment288806>
Missing period.
support/python3/get-review-ids.py
Lines 49 (patched)
<https://reviews.apache.org/r/67503/#comment28880
reply, visit:
> https://reviews.apache.org/r/67502/
> ---
>
> (Updated June 14, 2018, 11:13 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Refactored API functionality into
O(dragoshsch)`.
support/python3/common.py
Lines 160 (patched)
<https://reviews.apache.org/r/67502/#comment288796>
We generally set which contributor should take care of the todo, here it
should thus be `TODO(dragoshsch)`.
- Armand Grillet
On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
port/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f
Diff: https://reviews.apache.org/r/67853/diff/2/
Changes: https://reviews.apache.org/r/67853/diff/1-2/
Testing
---
Ran `build-virtualenv` with python 2 and 3.
Thanks,
Armand Grillet
5877ad283d3b2cbb5fc46cf712ebaf7a6bccc66d
Diff: https://reviews.apache.org/r/67856/diff/1/
Testing
---
Ran `support/build-virtualenv` successfully.
Thanks,
Armand Grillet
/diff/1/
Testing
---
Checked that this commit trigerred the script (I am using Python 3 by default).
Thanks,
Armand Grillet
7f
Diff: https://reviews.apache.org/r/67853/diff/1/
Testing
---
Ran `build-virtualenv` with python 2 and 3.
Thanks,
Armand Grillet
ly running.
Thanks,
Armand Grillet
: https://reviews.apache.org/r/67842/diff/2/
Changes: https://reviews.apache.org/r/67842/diff/1-2/
Testing
---
In `src/python/cli_new/`:
```
$ source activate
$ mesos-cli-tests
```
Removed one of the binary and tried again to check that the error was correct.
Thanks,
Armand Grillet
/cli_new/`:
```
$ source activate
$ mesos-cli-tests
```
Removed one of the binary and tried again to check that the error was correct.
Thanks,
Armand Grillet
PYTHON=python3 ../configure --disable-python --enable-new-cli` returns
`configure: error: Mesos requires Python < 3.0`.
Thanks,
Armand Grillet
:
```
configure: /usr/bin/python
configure: python3
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205620
---
Ship it!
Ship It!
- Armand Grillet
On July 2, 2018, 6:03
/diff/2-3/
Testing
---
```
$ PYTHON=yolo PYTHON_VERSION=3 ../configure --disable-java --disable-python
--enable-new-cli
...
configure: error: only specify one of PYTHON or PYTHON_VERSION
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67580/#review204731
---
Ship it!
Ship It!
- Armand Grillet
On June 13, 2018, 5:31
3>
Line too long.
support/python3/verify-reviews.py
Line 255 (original), 240 (patched)
<https://reviews.apache.org/r/67505/#comment287285>
Missing docstring.
support/python3/verify-reviews.py
Lines 259 (patched)
<https://reviews.apache.org/r/67505/#comment287284>
on3/post-build-result.py
Lines 55 (patched)
<https://reviews.apache.org/r/67504/#comment287280>
Missing docstring.
support/python3/post-build-result.py
Lines 81 (patched)
<https://reviews.apache.org/r/67504/#comment287279>
Missing docstring.
- Armand Grillet
On June 8
ng an output file should result in having the
dependent review IDs printed which is done in the last for loop of
`support/python3/common.py`.
support/python3/get-review-ids.py
Lines 35 (patched)
<https://reviews.apache.org/r/67503/#comment287274>
Missing docstring.
- Armand Grille
147 (patched)
<https://reviews.apache.org/r/67502/#comment287271>
This could be more descriptive, e.g. `This patch has been updated since its
last review, needs verification`. Also, sometimes devs rebase the review
request but the diff is empty and in that case the diff should not ne
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/#review204666
---
Ship it!
Ship It!
- Armand Grillet
On June 12, 2018, 5:41
he the CLI tests were run, that the content of the directory
build/src/cli was as expected, and that build/src/mesos was correctly running.
Thanks,
Armand Grillet
://reviews.apache.org/r/67487/diff/2/
Changes: https://reviews.apache.org/r/67487/diff/1-2/
Testing
---
In `build`:
```
$ ../configure --disable-java --enable-new-cli
$ GTEST_FILTER="" nice make -j16 check
```
Thanks,
Armand Grillet
([$PYTHON_3])
```
My machine runs Python 2 when using `python` but `python3` is available. The
result of `configure` was:
```
configure: /usr/bin/python
configure: python3
```
Thanks,
Armand Grillet
src/Makefile.am 9032453ba0b6d69d1d6f168b671dd199bd0258c7
Diff: https://reviews.apache.org/r/67487/diff/1/
Testing
---
In `build`:
```
$ ../configure --disable-java --enable-new-cli
$ GTEST_FILTER="" nice make -j16 check
```
Thanks,
Armand Grillet
,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67464/#review204403
---
Ship it!
Ship It!
- Armand Grillet
On June 5, 2018, 11:15
stants.cpp
Total errors found: 0
Total errors found: 0
No JavaScript files to lint
No Python files to lint
[MESOS-8979 3c596291f] Test.
Date: Wed Jun 6 09:38:59 2018 +0200
1 file changed, 1 insertion(+)
```
Thanks,
Armand Grillet
153ded2994daad6ffb610866d499603af5a53b0a
support/python3/push-commits.py 82a700418341731833f165a24054f0879648ea92
Diff: https://reviews.apache.org/r/67463/diff/1/
Testing
---
Removed part of the content of `push-commits.py` and run it using Python 3.
Thanks,
Armand Grillet
using `python` but `python3` is available. The
result of `configure` was:
```
configure: /usr/bin/python
configure: python3
```
Thanks,
Armand Grillet
`configure`, I've checked the output.
```
$ ../configure
...
configure: /usr/bin/python
configure: 2.7
$ PYTHON_VERSION=4 ../configure
...
configure: python4
configure: 4
$ PYTHON=yolo ../configure
...
configure: yolo
configure:
```
Thanks,
Armand Grillet
Diff: https://reviews.apache.org/r/67411/diff/1/
Testing
---
```
$ PYTHON=yolo PYTHON_VERSION=3 ../configure --disable-java --disable-python
--enable-new-cli
...
configure: error: only specify one of PYTHON or PYTHON_VERSION
```
Thanks,
Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67348/#review203962
---
Ship it!
Ship It!
- Armand Grillet
On mai 29, 2018, 7:48
that it was the last issue of that type
in python3/mesos-style.py.
Diffs
-
support/python3/mesos-style.py c0e918c611020a4dbba4c65bd4ac849a716f63e2
Diff: https://reviews.apache.org/r/67340/diff/1/
Testing
---
Thanks,
Armand Grillet
/
Testing
---
Thanks,
Armand Grillet
ed
python3/post-reviews type error.
Press enter to continue or 'Ctrl-C' to skip.
Review request #67321 posted.
https://reviews.apache.org/r/67321/
https://reviews.apache.org/r/67321/diff/
```
Thanks,
Armand Grillet
ure --enable-new-cli --disable-java
$ GTEST_FILTER="" nice make -j16
```
Completed successfully.
Thanks,
Armand Grillet
tps://reviews.apache.org/r/67292/#comment286129>
Please change to be `MESOS_SUPPORT_PYTHON`.
support/check-python3.py
Lines 38 (patched)
<https://reviews.apache.org/r/67292/#comment286128>
Please change to be `MESOS_SUPPORT_PYTHON`.
- Armand Grillet
On May 24, 2018, 6:58 p.m., Andrew S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/#review203812
---
Ship it!
Ship It!
- Armand Grillet
On May 24, 2018, 6:58
easy to fix (we just need to add
`.decode("utf-8")` but detecting all of them requires to use the scripts.
Please do so and create issues.
Thanks,
Armand Grillet
nd` with and without
`export MESOSSUPPORTPYTHON=3` (rebuilding the virtualenv was also done
following this change) to see if the correct Python files were linted.
Thanks,
Armand Grillet
on3.py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
$ python3 check-python3.py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
```
Thanks,
Armand Grillet
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67247/#review203682
-----------
On mai 22, 2018, 12:39 après-midi, Armand Grillet wrote:
>
> ---
to use the scripts.
Please do so and create issues.
Thanks,
Armand Grillet
: https://reviews.apache.org/r/67099/diff/2/
Changes: https://reviews.apache.org/r/67099/diff/1-2/
Testing (updated)
---
Tested the support scripts manually and used the git hooks.
Thanks,
Armand Grillet
py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
```
Thanks,
Armand Grillet
see, the number of errors found by cpplint is the same as before.
I have also used cpplint separately by running `python3 support/cpplint` on a
few C++ files to see that it was running as expected.
Thanks,
Armand Grillet
DC/OS clusters (the assets
being available under
`http://.com/mesos/assets/css/bootstrap-3.3.6.min.css` but
`index.html` pulling them from
`http://.com/assets/css/bootstrap-3.3.6.min.css` due to the `../`.
Thanks,
Armand Grillet
50
Diff: https://reviews.apache.org/r/67127/diff/2/
Changes: https://reviews.apache.org/r/67127/diff/1-2/
Testing
---
Thanks,
Armand Grillet
-
Thanks,
Armand Grillet
ted cpplint from upstream."
support/cpplint.patch:8: trailing whitespace.
+
```
Also applies for a dozen other lines in the file.
- Armand Grillet
On May 14, 2018, 3:32 p.m., Benjamin Bannier wrote:
>
> ---
>
101 - 200 of 549 matches
Mail list logo
