---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/#review203575
---
Ship it!
Ship It!
- Gaston Kleiman
On May 21, 2018, 3:13
Song, Greg Mann, and Vinod Kone.
Repository: mesos
Description
---
Added/updated tests to check per framework metrics.
Diffs
-
src/tests/master_tests.cpp d5ce52c0eb1ba333d1b3dd35518545c13d828ce6
Diff: https://reviews.apache.org/r/66883/diff/1/
Testing
---
Thanks,
Gaston
, Gaston Kleiman, Greg Mann, Jie Yu,
and Vinod Kone.
Repository: mesos
Description
---
Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.
Diffs (updated)
-
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp
/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66882/diff/3/
Changes: https://reviews.apache.org/r/66882/diff/2-3/
Testing
---
Thanks,
Gaston Kleiman
tps://reviews.apache.org/r/66822/#comment284775>
Thsi map should be named `call_types` for consistency with all the maps in
`Master::Metrics`.
- Gaston Kleiman
On April 30, 2018, 11:45 a.m., Gilbert Song wrote:
>
> ---
> This is a
/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66882/diff/2/
Changes: https://reviews.apache.org/r/66882/diff/1-2/
Testing
---
Thanks,
Gaston Kleiman
ent(const Type& type);
private:
hashmap counters;
const lambda::function keyNameGenerator;
}
```
- Gaston Kleiman
On April 30, 2018, 11:45 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically
src/master/metrics.hpp
Lines 226-227 (patched)
<https://reviews.apache.org/r/66821/#comment284602>
This is done in https://reviews.apache.org/r/66882/, can we squash both
patches?
- Gaston Kleiman
On April 30, 2018, 11:41 a.m., Gilbert
tps://reviews.apache.org/r/66819/#comment284601>
This constructor should be implemented in this patch.
The implementation is introduced in https://reviews.apache.org/r/66820/
with extra parameters.
- Gaston Kleiman
On April 27, 2018, 11:39 a.m., Gilbert Song
---
Prevented master::drop() from sending operation updates to v0 framework.
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
e159573b550b07f5315878a6eabb3b84080bf15a
src/tests/operation_reconciliation_tests.cpp
9717e8454a7d4654c58b903a8420aee2b0cea8a2
Diff: https://reviews.apache.org/r/66992/diff/2/
Changes: https://reviews.apache.org/r/66992/diff/1-2/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
9717e8454a7d4654c58b903a8420aee2b0cea8a2
Diff: https://reviews.apache.org/r/66992/diff/1/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
-----------
On May 7, 2018, 11:54 a.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
>
://reviews.apache.org/r/66924/diff/3/
Changes: https://reviews.apache.org/r/66924/diff/2-3/
Testing
---
`make check` on GNU/Linux.
The test in this patch fails without the corresponding master change, but
succeeds with it applied.
Thanks,
Gaston Kleiman
fb1d8bdf9ba09cace3ceb202dc70c0d201f2784e
Diff: https://reviews.apache.org/r/66939/diff/3/
Changes: https://reviews.apache.org/r/66939/diff/2-3/
Testing
---
Thanks,
Gaston Kleiman
://reviews.apache.org/r/66924/diff/2/
Changes: https://reviews.apache.org/r/66924/diff/1-2/
Testing
---
`make check` on GNU/Linux.
The test in this patch fails without the corresponding master change, but
succeeds with it applied.
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66965/#review202494
---
Ship it!
Ship It!
- Gaston Kleiman
On May 4, 2018, 3:35 p.m
st.ROOT_ReconcileDroppedOperation` whether the
update is correctly forwarded to the scheduler.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202436
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66938/#review202413
---
Ship it!
Ship It!
- Gaston Kleiman
On May 3, 2018, 4:14 p.m
applied.
Thanks,
Gaston Kleiman
https://reviews.apache.org/r/66939/diff/2/
Changes: https://reviews.apache.org/r/66939/diff/1-2/
Testing
---
Thanks,
Gaston Kleiman
Description
---
Improved validation messages for some operations.
Diffs
-
src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
Diff: https://reviews.apache.org/r/66939/diff/1/
Testing
---
Thanks,
Gaston Kleiman
tps://reviews.apache.org/r/66938/#comment284199>
We should call `error()` here so that the framework is gracefully teared
down instead of triggering a segfault.
- Gaston Kleiman
On May 3, 2018, 3:07 p.m., Greg Mann wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/#review202367
---
Ship it!
Ship It!
- Gaston Kleiman
On April 27, 2018, 3:15
/master_slave_reconciliation_tests.cpp
Lines 371-372 (patched)
<https://reviews.apache.org/r/66908/#comment284084>
Nit: many of the tests we already have do this instead:
```
FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO;
frameworkInfo.set_roles(0, DEFAULT_TEST_ROLE);
```
- Gaston K
` on GNU/Linux
Thanks,
Gaston Kleiman
s://reviews.apache.org/r/66644/#comment283334>
Ditto indentation.
src/tests/partition_tests.cpp
Lines 452-456 (patched)
<https://reviews.apache.org/r/66644/#comment283335>
Ditto indentation.
- Gaston Kleiman
On April 23, 2018, 11:11 a.
s issue, but Review Board doesn't let me publish the
draft ¯_(?)_/¯.
- Gaston Kleiman
On April 20, 2018, 5:03 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
ckwards compat for this library, can we just
> > update the signature of `send`?
>
> Gaston Kleiman wrote:
> Would the libmesos binary then be compatible? Or would frameworks then
> have to be recompiled using this new header in order to use new libmesos
> binaries?
>
/storage_local_resource_provider_tests.cpp
2872f1aec1a7b94fc302a533f5ae9e1be9658087
Diff: https://reviews.apache.org/r/66468/diff/5/
Changes: https://reviews.apache.org/r/66468/diff/4-5/
Testing
---
The new tests passed 1000 iterations on GNU/Linux.
Thanks,
Gaston Kleiman
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
://reviews.apache.org/r/66696/diff/4/
Changes: https://reviews.apache.org/r/66696/diff/3-4/
Testing
---
Thanks,
Gaston Kleiman
: https://reviews.apache.org/r/66466/diff/2/
Changes: https://reviews.apache.org/r/66466/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
The tests added by https://reviews.apache.org/r/66468/ use this helper with an
`OperationID`.
Thanks,
Gaston Kleiman
Diff: https://reviews.apache.org/r/66467/diff/2/
Changes: https://reviews.apache.org/r/66467/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
The tests added by https://reviews.apache.org/r/66468/ use this helper.
Thanks,
Gaston Kleiman
://reviews.apache.org/r/66465/diff/2/
Changes: https://reviews.apache.org/r/66465/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
The tests added by https://reviews.apache.org/r/66468/ use these statements.
Thanks,
Gaston Kleiman
: https://reviews.apache.org/r/66464/diff/6/
Changes: https://reviews.apache.org/r/66464/diff/5-6/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
https://reviews.apache.org/r/66468/ adds new tests.
Thanks,
Gaston Kleiman
://reviews.apache.org/r/66462/diff/5/
Changes: https://reviews.apache.org/r/66462/diff/4-5/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
/r/66463/diff/2/
Changes: https://reviews.apache.org/r/66463/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
https://reviews.apache.org/r/66459/diff/2/
Changes: https://reviews.apache.org/r/66459/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67
Diff: https://reviews.apache.org/r/66461/diff/3/
Changes: https://reviews.apache.org/r/66461/diff/2-3/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
.
Diffs (updated)
-
src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
Diff: https://reviews.apache.org/r/66679/diff/3/
Changes: https://reviews.apache.org/r/66679/diff/2-3/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
2d96ee754b3fdcfb18a7516f30abf0086fa75137
docs/scheduler-http-api.md 3929c33781a152428338c4cdaf7dbc47da7c875e
Diff: https://reviews.apache.org/r/66696/diff/3/
Changes: https://reviews.apache.org/r/66696/diff/2-3/
Testing
---
Thanks,
Gaston Kleiman
e ignored) when
reconciling operations. It is there for when we support ERPS.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66696/#review201466
-----------
://reviews.apache.org/r/66696/diff/1-2/
Testing
---
Thanks,
Gaston Kleiman
.
Thanks,
Gaston Kleiman
is dropped.
Diffs (updated)
-
src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
Diff: https://reviews.apache.org/r/66679/diff/2/
Changes: https://reviews.apache.org/r/66679/diff/1-2/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
---
Updated Scheduler HTTP API doc for operation feedback.
Diffs
-
docs/scheduler-http-api.md 3929c33781a152428338c4cdaf7dbc47da7c875e
Diff: https://reviews.apache.org/r/66696/diff/1/
Testing
---
Thanks,
Gaston Kleiman
767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
Diff: https://reviews.apache.org/r/66679/diff/1/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
which it is not necessary.
src/tests/persistent_volume_tests.cpp
Lines 502 (patched)
<https://reviews.apache.org/r/66220/#comment282539>
Nit: `Offer offer = offersBeforeCreate->at(0);`
If this test is split into smaller ones, then you can also probable make
`offer` a cons
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66615/#review201257
---
Ship it!
Ship It!
- Gaston Kleiman
On April 16, 2018, 9:51
> On April 16, 2018, 10:38 a.m., Gaston Kleiman wrote:
> > src/master/validation.cpp
> > Lines 2348-2351 (patched)
> > <https://reviews.apache.org/r/66050/diff/10/?file=2002407#file2002407line2348>
> >
> > Isn't it easier to do th
tps://reviews.apache.org/r/66344/#comment282375>
The agent should retry this update for as long as possible, so it should
set a status UUID.
- Gaston Kleiman
On March 28, 2018, 2:41 p.m., Zhitao Li wrote:
>
> ---
> This is an automatica
---
>
> (Updated April 16, 2018, 10:31 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and
> Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The Docker containerizer tests a
#comment282365>
Isn't it easier to do the following?
```
if (growVoluem.addition.scalar.value() <= 0) {
...
```
- Gaston Kleiman
On April 16, 2018, 10:09 a.m., Zhitao Li wrote:
>
> ---
>
/containerizer/docker_containerizer_tests.cpp
Line 378 (original)
<https://reviews.apache.org/r/66637/#comment282358>
The default networking is `HOST`, so this line shouldn't be removed.
- Gaston Kleiman
On April 16, 2018, 9:5
---
On April 9, 2018, 9:18 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> ---
>
> (Updated
aster/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
Diff: https://reviews.apache.org/r/66464/diff/4/
Changes: https://reviews.apache.org/r/66464/diff/3-4/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
https://reviews.apache.org/r/66468/ adds new tests.
Thanks,
Gaston Kleiman
other tests.
- Gaston Kleiman
On April 13, 2018, 4:57 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
://reviews.apache.org/r/66462/diff/3-4/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
l. To reply, visit:
https://reviews.apache.org/r/66462/#review200957
-------
On April 11, 2018, 10:58 a.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-ma
://reviews.apache.org/r/66462/diff/2-3/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
; >
> > If this is mesos Response rather than http::Response, aren't we losing
> > information about which http code came back? (e.g. 400, 401, etc).
>
> Gaston Kleiman wrote:
> If the request is not successful and the http code is neither 200 nor
> 202
/scheduler.cpp ecef916ffd0797a13552525ff2cda0f99ca57e74
Diff: https://reviews.apache.org/r/66460/diff/3/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
https://reviews.apache.org/r/66468/diff/3-4/
Testing
---
The new tests passed 1000 iterations on GNU/Linux.
Thanks,
Gaston Kleiman
; >
> > If this is mesos Response rather than http::Response, aren't we losing
> > information about which http code came back? (e.g. 400, 401, etc).
>
> Gaston Kleiman wrote:
> If the request is not successful and the http code is neither 200 nor
> 202
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66460/#review200842
-------
On April 6, 2018, 2:17 p.m., Gaston Kleiman wrote:
>
> ---
&
> On April 9, 2018, 5:08 p.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 364-365 (patched)
> > <https://reviews.apache.org/r/66468/diff/1/?file=1994432#file1994432line364>
> >
> > Is there a reason not to do this with
-CREATION
src/tests/storage_local_resource_provider_tests.cpp
2872f1aec1a7b94fc302a533f5ae9e1be9658087
Diff: https://reviews.apache.org/r/66468/diff/3/
Changes: https://reviews.apache.org/r/66468/diff/2-3/
Testing
---
The new tests passed 1000 iterations on GNU/Linux.
Thanks,
Gaston
^~~~
```
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66489/#review200833
-------
On April 6, 2018, 5:16 p.m., Gaston Kleiman wrote:
>
> -
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200769
-----------
On April 9, 2018, 5:30 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically gen
1000 iterations on GNU/Linux.
Thanks,
Gaston Kleiman
/storage_local_resource_provider_tests.cpp
2872f1aec1a7b94fc302a533f5ae9e1be9658087
Diff: https://reviews.apache.org/r/66468/diff/1/
Testing
---
The new tests passed 1000 iterations on GNU/Linux.
Thanks,
Gaston Kleiman
> On April 9, 2018, 12:04 p.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 5097 (patched)
> > <https://reviews.apache.org/r/66464/diff/1/?file=1992581#file1992581line5102>
> >
> > s/reconcileOperations/std::move(reconcileOperations)/
>
>
aster/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
Diff: https://reviews.apache.org/r/66464/diff/2/
Changes: https://reviews.apache.org/r/66464/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
https://reviews.apache.org/r/66468/ adds new tests.
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200680
---
On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
>
> --
L692-L701
Why should it be different for the Scheduler API?
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200680
-------
On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
>
semantically equivalent to a get method on a hashmap, so an `Option` seems to
be a better fit.
- Gaston Kleiman
On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
f598ea11b64bdbface5bf1f124a02ea876196b67
Diff: https://reviews.apache.org/r/66489/diff/1/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
Diff: https://reviews.apache.org/r/66461/diff/2/
Changes: https://reviews.apache.org/r/66461/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/66461/#review200669
-------
On April 6, 2018, 5:16 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail.
://reviews.apache.org/r/66460/diff/3/
Changes: https://reviews.apache.org/r/66460/diff/2-3/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
se is a
stream.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66460/#review200670
-------
On April 6, 2018, 2 p.m., Gasto
Diff: https://reviews.apache.org/r/66460/diff/2/
Changes: https://reviews.apache.org/r/66460/diff/1-2/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66460/#review200661
---
On April 4, 2018, 4:53 p.m., Gaston Kleiman wrote:
>
> --
/r/66468/ use this helper.
Thanks,
Gaston Kleiman
/66468/ use this helper with an
`OperationID`.
Thanks,
Gaston Kleiman
these statements.
Thanks,
Gaston Kleiman
/66464/diff/1/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
https://reviews.apache.org/r/66468/ adds new tests.
Thanks,
Gaston Kleiman
/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb
src/tests/master_tests.cpp be7a3cc6126d2fe7c56c49b3da5f6f4bf29657f5
Diff: https://reviews.apache.org/r/66463/diff/1/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c
src/slave/slave.cpp b17854788ceb63f3748380c546a13531e86f0dda
Diff: https://reviews.apache.org/r/66462/diff/1/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
-tests` on GNU/Linux
Thanks,
Gaston Kleiman
Thanks,
Gaston Kleiman
s` on GNU/Linux
Thanks,
Gaston Kleiman
resources will be added to the
framework.
Diffs
-
src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c
Diff: https://reviews.apache.org/r/66458/diff/1/
Testing
---
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66365/#review200239
-------
On April 2, 2018, 10:15 a.m., Gaston Kleiman wrote:
>
> --
e.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a
Diff: https://reviews.apache.org/r/66365/diff/2/
Changes: https://reviews.apache.org/r/66365/diff/1-2/
Testing
---
Tests still pass on GNU/Linux.
Thanks,
Gaston Kleiman
---
Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers.
Diffs
-
src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45
Diff: https://reviews.apache.org/r/66367/diff/1/
Testing
---
Existing tests pass on GNU/Linux.
Thanks,
Gaston Kleiman
pass on GNU/Linux.
Thanks,
Gaston Kleiman
1 - 100 of 454 matches
Mail list logo
