Lines 1109 (patched)
<https://reviews.apache.org/r/72126/#comment307869>
This agent is reachable right? It just doesn't have a cooperative executor.
- Joseph Wu
On Feb. 12, 2020, 7:16 p.m., Benjamin Mahler wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72125/#review219659
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 12, 2020, 7:15 p.m
o, the
DrainSlaveMessage would be sent when/if the agent comes back).
- Joseph Wu
On Feb. 12, 2020, 6:05 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72116/#review219551
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 11, 2020, 12:54 p.m
/openssl_socket.hpp
2d0259d5fa20140c61bb2c699b69214d3e436e16
3rdparty/libprocess/src/ssl/openssl_socket.cpp
74f9fe2443efa37c0b6c7f77120b140f5ac0b53b
Diff: https://reviews.apache.org/r/72014/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
a6563fb50e4356e51e958d262979b7ed7221f028
Diff: https://reviews.apache.org/r/72016/diff/1/
Testing
---
make check (two tests now fail)
Thanks,
Joseph Wu
to check for readable bytes.
Diffs
-
3rdparty/libprocess/src/ssl/openssl_socket.cpp
74f9fe2443efa37c0b6c7f77120b140f5ac0b53b
Diff: https://reviews.apache.org/r/72017/diff/1/
Testing
---
make check (tests enabled with the previous review now pass)
Thanks,
Joseph Wu
tests (Windows)
Thanks,
Joseph Wu
---
Oops, I forgot to add this to the autotools build (which I don't run in
development :( )
Thanks,
Joseph Wu
forgot to add this to the autotools build (which I don't run in
development :( )
Thanks,
Joseph Wu
---
cmake --build . --target check
Thanks,
Joseph Wu
le this transparently for
us, but a unit test would make sure of this.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review219029
-------
--build . --target libprocess-tests
libprocess-tests
```
Running libprocess-tests yields:
```
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
```
Thanks,
Joseph Wu
is a listening
socket.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71665/#review219009
---
On Dec. 16, 2019, 1:58 p.
SERT_SOME(client);
AWAIT_ASSERT_READY(client->connect(
network::inet::Address(net::IP::parse("216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
: https://reviews.apache.org/r/71664/diff/5/
Changes: https://reviews.apache.org/r/71664/diff/4-5/
Testing
---
cmake --build . --target process
A tiny bit of testing next patch.
Thanks,
Joseph Wu
ocess-tests
Thanks,
Joseph Wu
---
```
cmake --build . --target libprocess-tests
libprocess-tests
```
Running libprocess-tests yields:
```
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
```
Thanks,
Joseph Wu
ate_path().string()}
});
Try client = Socket::create(SocketImpl::Kind::SSL);
ASSERT_SOME(client);
AWAIT_ASSERT_READY(client->connect(
network::inet::Address(net::IP::parse("216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
(updated)
-
3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71664/diff/4/
Changes: https://reviews.apache.org/r/71664/diff/3-4/
Testing
---
cmake --build . --target process
A tiny bit of testing next patch.
Thanks,
Joseph Wu
/openssl_socket.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71660/diff/4/
Changes: https://reviews.apache.org/r/71660/diff/3-4/
Testing
---
cmake .. -ENABLE_SSL=1 # No Libevent here!
Thanks,
Joseph Wu
881dab1da4f8dfa7826d82398a989fd23cc2262e
Diff: https://reviews.apache.org/r/71661/diff/2/
Changes: https://reviews.apache.org/r/71661/diff/1-2/
Testing
---
cmake --build . --target process
Thanks,
Joseph Wu
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71664/#review218800
-----------
On Nov. 19, 2019, 12:16 p.m., Joseph Wu wrote:
>
> --
h the same thing with dispatches and chained continuations,
> > so we could also just use `dispatch()` directly instead of `loop()`, that
> > might be the simplest thing to do.
> >
> > WDYT?
>
> Joseph Wu wrote:
> I think a UPID/actor is required
h the same thing with dispatches and chained continuations,
> > so we could also just use `dispatch()` directly instead of `loop()`, that
> > might be the simplest thing to do.
> >
> > WDYT?
>
> Joseph Wu wrote:
> I think a UPID/actor is required
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218948
---
On Nov. 19, 2019, 4:29 p.m., Joseph Wu wrote:
>
> ---
> This is an auto
gt;
> >
> > Why vlog this failure case but not the others? Should we have logging
> > for all these cases, or none?
This log was also copied from libevent. I can add more logging where it makes
sense to.
- Joseph
--------
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71664/#review218804
-----------
On Nov. 19, 2019, 12:16 p.m., Joseph Wu wrote:
>
> ---
> This is an automat
ke --build . --target libprocess-tests
libprocess-tests
```
Running libprocess-tests yields:
```
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
```
Thanks,
Joseph Wu
arget libprocess-tests
libprocess-tests
Thanks,
Joseph Wu
s.cpp
05dc5ec2fdc74a989689e4378bef775bcf2b7a87
Diff: https://reviews.apache.org/r/71790/diff/1/
Testing
---
cmake --build . --target libprocess-tests
libprocess-tests
Thanks,
Joseph Wu
threads), so we need some guards here.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71664/#review218661
---------
/src/ssl/socket_wrapper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71664/diff/3/
Changes: https://reviews.apache.org/r/71664/diff/2-3/
Testing
---
cmake --build . --target process
A tiny bit of testing next patch.
Thanks,
Joseph Wu
35b12ddedec6f85b75adefa80d38fa439cd6b2d3
Diff: https://reviews.apache.org/r/71659/diff/3/
Changes: https://reviews.apache.org/r/71659/diff/2-3/
Testing
---
Requires a libprocess build change too (next patch).
Thanks,
Joseph Wu
dparty/libprocess/src/ssl/socket_wrapper.cpp
Lines 657-663 (patched)
<https://reviews.apache.org/r/71666/#comment306401>
Consider not blocking, but instead just trying to send the shutdown bits
once.
- Joseph Wu
On Nov. 11, 2019, 11:41 a.m., Jos
ject used by libprocess instead.
- Joseph Wu
On Oct. 30, 2019, 6:29 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Diff: https://reviews.apache.org/r/71659/diff/2/
Changes: https://reviews.apache.org/r/71659/diff/1-2/
Testing
---
Requires a libprocess build change too (next patch).
Thanks,
Joseph Wu
://reviews.apache.org/r/71660/diff/3/
Changes: https://reviews.apache.org/r/71660/diff/2-3/
Testing
---
cmake .. -ENABLE_SSL=1 # No Libevent here!
Thanks,
Joseph Wu
bfe94b185075c10d2202d0a11f1d0025d10f3fcf
Diff: https://reviews.apache.org/r/71764/diff/1/
Testing
---
TODO (I don't usually run the Autotools build)
Thanks,
Joseph Wu
`SocketImpl` is useful for all the
areas that use Socket objects. This obstraction lets us parameterize tons of
our tests for SSL and non-SSL.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/
GetParam() = "SSL"
[ FAILED ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
```
Thanks,
Joseph Wu
rse("216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
tocol
[ FAILED ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = "SSL"
[ FAILED ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
```
Thanks,
Joseph Wu
dDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
[ FAILED ] SSLTest.ShutdownThenSend
```
Thanks,
Joseph Wu
quot;216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
indefinitely)
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
[ FAILED ] SSLTest.ShutdownThenSend
```
Thanks,
Joseph Wu
);
AWAIT_ASSERT_READY(client->connect(
network::inet::Address(net::IP::parse("216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
://reviews.apache.org/r/71664/diff/1-2/
Testing
---
cmake --build . --target process
A tiny bit of testing next patch.
Thanks,
Joseph Wu
/diff/2/
Changes: https://reviews.apache.org/r/71660/diff/1-2/
Testing
---
cmake .. -ENABLE_SSL=1 # No Libevent here!
Thanks,
Joseph Wu
response = http::get(url);
AWAIT_READY(response);
EXPECT_EQ(http::Status::OK, response->code);
```
Thanks,
Joseph Wu
client = Socket::create(SocketImpl::Kind::SSL);
ASSERT_SOME(client);
AWAIT_ASSERT_READY(client->connect(
network::inet::Address(net::IP::parse("216.58.194.206").get(), 443),
openssl::create_tls_client_config(None(;
```
Thanks,
Joseph Wu
tiny bit of testing next patch.
Thanks,
Joseph Wu
/socket_wrapper.hpp PRE-CREATION
3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71660/diff/1/
Testing
---
cmake .. -ENABLE_SSL=1 # No Libevent here!
Thanks,
Joseph Wu
---
cmake --build . --target process
Thanks,
Joseph Wu
lities.cpp
c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
Diff: https://reviews.apache.org/r/71663/diff/1/
Testing
---
cmake --build . (Windows)
Thanks,
Joseph Wu
/windows/poll_socket.cpp
e2a84694ac554b4c23242fd93d93800c0334a943
Diff: https://reviews.apache.org/r/71662/diff/1/
Testing
---
cmake --build . --target process (Windows)
Thanks,
Joseph Wu
35b12ddedec6f85b75adefa80d38fa439cd6b2d3
Diff: https://reviews.apache.org/r/71659/diff/1/
Testing
---
Requires a libprocess build change too (next patch).
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/#review217931
---
Ship it!
Ship It!
- Joseph Wu
On Sept. 23, 2019, 5:41 p.m
f the commit description
s/completely in lie of/completely in lieu of/
The typo is also present in the next review ;)
- Joseph Wu
On Sept. 19, 2019, 6:44 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-
pdated)
-
3rdparty/stout/tests/CMakeLists.txt e3291c72d1875f5b196dd5ea2ba20e7d53881b87
Diff: https://reviews.apache.org/r/71511/diff/2/
Changes: https://reviews.apache.org/r/71511/diff/1-2/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
pdated)
-
3rdparty/libprocess/src/tests/CMakeLists.txt
b4ec9907d16c89b45562f4fa33c9f3d2913f6991
Diff: https://reviews.apache.org/r/71512/diff/2/
Changes: https://reviews.apache.org/r/71512/diff/1-2/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
eviews.apache.org/r/71510/diff/1-2/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
adjusting the default for `WIN32` be possible?
> >
> > In any case not an important regression, feel free to drop.
>
> Joseph Wu wrote:
> It should still be possible to override the `TEST_DRIVER` here. The
> reason for the `TEST_RUNNER` temporary variable is to tra
FIG` part. And I
believe that was cmake extending the binary search path automatically.
Note: On Windows, if you have an executable like `test.exe`, you can run it
while omitting the `.exe`.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/
/71512/diff/1/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
477b5ccd411db482a8877e596f520342
Diff: https://reviews.apache.org/r/71510/diff/1/
Testing
---
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
(Windows)
Thanks,
Joseph Wu
for the Windows
build.
Diffs (updated)
-
CMakeLists.txt a1ca5c28819b946b10a3533f4793896c676d4682
Diff: https://reviews.apache.org/r/71507/diff/2/
Changes: https://reviews.apache.org/r/71507/diff/1-2/
Testing
---
cmake --build . --target dist
Thanks,
Joseph Wu
rated e-mail. To reply, visit:
https://reviews.apache.org/r/71507/#review217830
-------
On Sept. 18, 2019, 12:26 p.m., Joseph Wu wrote:
>
> ---
> This is
a1ca5c28819b946b10a3533f4793896c676d4682
Diff: https://reviews.apache.org/r/71507/diff/1/
Testing
---
cmake --build . --target dist
Thanks,
Joseph Wu
s.cpp d6cc31bf89954c5a440142b378560cdc0286df23
Diff: https://reviews.apache.org/r/71481/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71480/#review217713
---
Ship it!
Ship It!
- Joseph Wu
On Sept. 12, 2019, 4:18 p.m
://reviews.apache.org/r/71478/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/#review217496
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 29, 2019, 5 a.m
: mesos
Description
---
Added node draining to 1.9.0 CHANGELOG.
Diffs
-
CHANGELOG 1c631978385925433e12f8854c47b6f4056cb577
Diff: https://reviews.apache.org/r/71378/diff/1/
Testing
---
Thanks,
Joseph Wu
docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7
docs/standalone-containers.md PRE-CREATION
Diff: https://reviews.apache.org/r/65112/diff/2/
Changes: https://reviews.apache.org/r/65112/diff/1-2/
Testing
---
Previewed the docs via the website generator.
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/#review217466
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 27, 2019, 12:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217465
---
Ship it!
Ship It!
- Joseph Wu
On July 30, 2019, 2:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217464
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217463
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217462
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 19, 2019, 12:20 a.m
)
<https://reviews.apache.org/r/71205/#comment304726>
s/mlink/mklink/
- Joseph Wu
On Aug. 27, 2019, 1:08 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217460
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:48 a.m
t/gitlint
Lines 35-48 (patched)
<https://reviews.apache.org/r/71204/#comment304725>
Do we need these chunks?
- Joseph Wu
On Aug. 14, 2019, 4:24 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated
tps://reviews.apache.org/r/70096/#comment304721>
s/mlink/mklink/
- Joseph Wu
On Aug. 14, 2019, 4:25 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71318/diff/4/
Changes: https://reviews.apache.org/r/71318/diff/3-4/
Testing
---
make check
Thanks,
Joseph Wu
Thanks,
Joseph Wu
/
Testing
---
make check
Thanks,
Joseph Wu
/diff/1-2/
Testing
---
make check
Thanks,
Joseph Wu
te operation subclass (MarkSlaveUnreachable).
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71316/#review217362
---
PRE-CREATION
Diff: https://reviews.apache.org/r/71316/diff/2/
Changes: https://reviews.apache.org/r/71316/diff/1-2/
Testing
---
make check
Thanks,
Joseph Wu
before.
Diffs (updated)
-
src/tests/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71315/diff/2/
Changes: https://reviews.apache.org/r/71315/diff/1-2/
Testing
---
make check
Thanks,
Joseph Wu
The two variants mean we'll be
serializing the agent draining protobufs to/from JSON. Most of these protobufs
are not used anywhere else too.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https:
/
Testing
---
make check
Thanks,
Joseph Wu
/71318/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71317/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
-CREATION
Diff: https://reviews.apache.org/r/71316/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
src/tests/api_tests.cpp e202cd330d424efef783d39b74db5f856bd34895
src/tests/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71314/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
1 - 100 of 2923 matches
Mail list logo
