Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review101290 --- LGTM - Paul Brett On Sept. 24, 2015, 3:15 a.m., Jian Qiu wrote

Review Request 38728: Cgroups Test Filters aborts test.

, Paul Brett

Re: Review Request 38528: Disable perf test when perf version is not support.

version of perf to be installed, however the Parse test does not. Could we use the supported() test to disable all events matching both ROOT and Perf? - Paul Brett On Sept. 20, 2015, 2:49 a.m., haosdent huang wrote: > > --- > T

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97551 --- On Sept. 2, 2015, 11:33 p.m., Paul Brett wrote: > > -

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

supported perf output formats. Diffs (updated) - src/tests/containerizer/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

to both of them. I'll make that clear. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97360 --- On

Re: Review Request 37462: Add support for version detection and parsing.

to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

dated) - src/linux/perf.cpp dac7061471a0fa05de12cb530bcd5c63a6a71eee Diff: https://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97320 ------- On Sept. 1, 2015, 7:49 p.m., Paul Brett wrote: > > --- > This is an a

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

currently using the version of perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Review Request 37976: Simplify perf by removing unused sampling capabilities.

/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37976/diff/ Testing --- Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

gt; Diffs > - > > src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 > > Diff: https://reviews.apache.org/r/37416/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Paul Brett > >

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

416/#comment151479> It would be a rare event but not completly unexpected. After all, perf can be upgraded while mesos is running. - Paul Brett On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: > > --- > This is an automati

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

versions. Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

/ Testing --- sudo make check Perf tests may fail on many machines because the tests are currently using the version of perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

the supported perf versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37460: Prevent perf test failures from killing the test harness.

6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37460/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

reply, visit: https://reviews.apache.org/r/37416/#review95809 --- On Aug. 20, 2015, 4:39 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

iple versions of perf output. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95809 --- On Aug

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

y, visit: https://reviews.apache.org/r/37417/#review95777 ------- On Aug. 18, 2015, 11:01 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37417/ > -

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37424: Timeout the perf future if the process does not complete.

/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

. Repository: mesos Description --- Convert Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37424: Timeout the perf future if the process does not complete.

--- sudo make check Thanks, Paul Brett

Re: Review Request 37424: Timeout the perf future if the process does not complete.

; So the idea here is now your callers use a .after() which does a > > discard(). I'll move the timeout to the calling sites where required. - Paul --- This is an automatically generated e-mail. To reply, visit: https://r

Re: Review Request 37417: Convert Perf event validator to use new shared object.

. Repository: mesos Description --- Convert Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37423: Split out common functions for running "perf" into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

valid and version operations. Diffs (updated) - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37423/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37490: Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness.

mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.

--- sudo make check Thanks, Paul Brett

Review Request 37466: Update perf tests to including testing the supported perf output formats.

/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37462: Add support for version detection and parsing.

://issues.apache.org/jira/browse/MESOS-2834 Repository: mesos Description --- Add support for version detection and parsing. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37462/diff/ Testing --- sudo make check Thanks, Paul

Review Request 37460: Prevent perf test failures from killing the test harness.

--- sudo make check Thanks, Paul Brett

Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- Factor out the token extraction rules in prepartion for extending them to cope with multiple versions. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37417: Convert Perf event validator to use new shared object.

Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37424: Timeout the perf future if the process does not complete.

--- Timeout the perf future if the process does not complete. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37424/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37423: Split out common functions for running "perf" into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

x/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37423/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

/containerizer/isolators/network/port_mapping.cpp 6d635d4dd902fd3863cce689a7791f12d22c3e0c Diff: https://reviews.apache.org/r/37399/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37399: Ignore no statistics condition for containers with no qdisc.

://reviews.apache.org/r/37399/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37147: Timeout perf stat command if it does not complete.

, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

Diff: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

://reviews.apache.org/r/37106/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

Diff: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94148 --- On Aug. 4, 2015, 4:57 p.m., Paul Brett wrote: > > ---

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37045: Convert Linux perf sampler to use process:await().

make check Thanks, Paul Brett

Review Request 37000: Refactor Subprocess logic in linux/perf.cpp to use common subroutine.

/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 36947: Fix new/delete mismatch in stout test.

/36947/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

pending on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

. Diffs (updated) - src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36380/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

x/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

27; output versions depending on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91346 ------- On July 10, 2015, 8:52 p.m., Paul Brett wrote: > > --- > This is an automatically generated e

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

378/#comment144721> Get version number from 'perf --version' not os::release. src/linux/perf.cpp (line 623) <https://reviews.apache.org/r/36378/#comment144720> We should get the version number from 'perf --version' not os::release in case a mismatched perf i

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

usage is in multiple locations in the file. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91253 --- On July

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

multiple output versions depending on kernel version. Diffs (updated) - src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36380/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

versions depending on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

n(3.0.0) sorts as less that Version(2.6.41). - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91253 --- On July 10,

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91262 --- On July 9, 2015, 11:08 p.m., Paul Brett wrote: > > --- > This is an aut

Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

Diff: https://reviews.apache.org/r/36380/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36336: Expose major, minor and patch components from stout Version

t; > primary/secondary/tertiary? The former is a widely accepted format. > > Paul Brett wrote: > g++ defines _GNU_SOURCE (required for libstdc++). This #includes > sysmacros.h which #define major and minor as macros for makedev. > > Ben Mahler wrote: > If you

Re: Review Request 36336: Expose major, minor and patch components from stout Version

://reviews.apache.org/r/36336/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36336: Expose major, minor and patch components from stout Version

t; > primary/secondary/tertiary? The former is a widely accepted format. > > Paul Brett wrote: > g++ defines _GNU_SOURCE (required for libstdc++). This #includes > sysmacros.h which #define major and minor as macros for makedev. > > Ben Mahler wrote: > If you

Re: Review Request 36336: Expose major, minor and patch components from stout Version

t; > primary/secondary/tertiary? The former is a widely accepted format. > > Paul Brett wrote: > g++ defines _GNU_SOURCE (required for libstdc++). This #includes > sysmacros.h which #define major and minor as macros for makedev. > > Ben Mahler wrote: > If you

Re: Review Request 36336: Expose major, minor and patch components from stout Version

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91047 --- On July 8, 2015, 10:50 p.m., Paul Brett wrote: > > --- > This is an automati

Re: Review Request 36336: Expose major, minor and patch components from stout Version

y, visit: https://reviews.apache.org/r/36336/#review91023 --- On July 8, 2015, 10:50 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 36336: Expose major, minor and patch components from stout Version

sysmacros.h header implicitly which define these for makedev. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb Diff: https://reviews.apache.org/r/36336/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

ng.md 8889fb165cc70bc382be0c99de8d7748328abf57 Diff: https://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

----- On July 8, 2015, 12:59 a.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36281/ > -

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 Diff: https://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

1001779line24> > > > > Do these dependencies need to be added to getting-started.md? I don't believe so since this is not a default configuration. - Paul --- This is an automatically generated e-mail. To reply, visit:

  1   2   3   >