Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-28 Thread Vijay Srinivasaraghavan
; python build too in a follow up review? (See my comments later on how you > > can use review dependencies if you are new to ReviewBoard) > > Vijay Srinivasaraghavan wrote: > Thanks Anand. I have made the python binding changes locally on my > machine. Do you want me to creat

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-28 Thread Vijay Srinivasaraghavan
; python build too in a follow up review? (See my comments later on how you > > can use review dependencies if you are new to ReviewBoard) > > Vijay Srinivasaraghavan wrote: > Thanks Anand. I have made the python binding changes locally on my > machine. Do you want me to creat

Re: Review Request 54014: Fixed missing protobuf java package definition.

2016-11-22 Thread Vijay Srinivasaraghavan
73d45b37a7afc47366a4a01a36912f30b47c30b1 Diff: https://reviews.apache.org/r/54014/diff/ Testing --- Ran "make check" Thanks, Vijay Srinivasaraghavan

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-22 Thread Vijay Srinivasaraghavan
/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 Diff: https://reviews.apache.org/r/53825/diff/ Testing --- Built mesos and confirmed jar file containing new java PB wrappers for V1 API. Ran standard unit test (make tests) Thanks, Vijay Srinivasaraghavan

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-22 Thread Vijay Srinivasaraghavan
; python build too in a follow up review? (See my comments later on how you > > can use review dependencies if you are new to ReviewBoard) > > Vijay Srinivasaraghavan wrote: > Thanks Anand. I have made the python binding changes locally on my > machine. Do you want me to creat

Review Request 54014: Fixed missing protobuf java package definition.

2016-11-22 Thread Vijay Srinivasaraghavan
--- Ran "make check" Thanks, Vijay Srinivasaraghavan

Review Request 54015: Added V1 API protos to python bindings.

2016-11-22 Thread Vijay Srinivasaraghavan
://issues.apache.org/jira/browse/MESOS-6597 Repository: mesos Description --- Added V1 API protos to python bindings. Diffs - src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 Diff: https://reviews.apache.org/r/54015/diff/ Testing --- Ran "make check" Than

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-22 Thread Vijay Srinivasaraghavan
://reviews.apache.org/r/53825/diff/ Testing --- Built mesos and confirmed jar file containing new java PB wrappers for V1 API. Ran standard unit test (make tests) Thanks, Vijay Srinivasaraghavan

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-20 Thread Vijay Srinivasaraghavan
src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac Diff: https://reviews.apache.org/r/53825/diff/ Testing (updated) --- Built mesos and confirmed jar file containing new java PB wrappers for V1 API. Ran standard unit test (make tests) Thanks, Vijay Srinivasaraghavan

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-20 Thread Vijay Srinivasaraghavan
eviews.apache.org/r/53825/#review156423 --- On Nov. 21, 2016, 4:35 a.m., Vijay Srinivasaraghavan wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-20 Thread Vijay Srinivasaraghavan
) - include/mesos/v1/allocator/allocator.proto 73d45b37a7afc47366a4a01a36912f30b47c30b1 src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac Diff: https://reviews.apache.org/r/53825/diff/ Testing --- Thanks, Vijay Srinivasaraghavan

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-20 Thread Vijay Srinivasaraghavan
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 --- On Nov. 18, 2016, 8:04 a.m., Vijay Srinivasaraghavan wrote: > > -

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-18 Thread Vijay Srinivasaraghavan
? - Vijay Srinivasaraghavan On Nov. 18, 2016, 8:04 a.m., Vijay Srinivasaraghavan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-18 Thread Vijay Srinivasaraghavan
protos generation for all V1 proto files. Diffs (updated) - include/mesos/v1/allocator/allocator.proto 73d45b37a7afc47366a4a01a36912f30b47c30b1 src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac Diff: https://reviews.apache.org/r/53825/diff/ Testing --- Thanks, Vijay

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-16 Thread Vijay Srinivasaraghavan
5a47c93388234a68c3c486a021ccdbe3213c5bac Diff: https://reviews.apache.org/r/53825/diff/ Testing --- Thanks, Vijay Srinivasaraghavan

Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

2016-11-16 Thread Vijay Srinivasaraghavan
, Vijay Srinivasaraghavan