Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90802 --- Question about MESOS-2832, but otherwise looks good.

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/ --- (Updated July 7, 2015, 11:05 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90821 --- Updated the review to use a new optional boolean flag. The docker

Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/ --- Review request for mesos, Benjamin Hindman and Joerg Schad. Bugs: MESOS-2996

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90796 --- Ship it! Looks good but see the issue below about moving this

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90812 --- src/slave/containerizer/docker.hpp (line 239)

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90814 --- src/slave/containerizer/docker.cpp (line 1544)

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90826 --- Ship it! Barring Adams comment.

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Till Toenshoff
On July 7, 2015, 10:58 p.m., Joerg Schad wrote: src/slave/containerizer/docker.cpp, line 1544 https://reviews.apache.org/r/36282/diff/1/?file=1001811#file1001811line1544 Wouldn't it be easier --especially considering Adam's comment about MESOS-2832 and the

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90811 --- src/slave/containerizer/docker.cpp (line 1552)

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Joerg Schad
On July 7, 2015, 10:58 p.m., Joerg Schad wrote: src/slave/containerizer/docker.cpp, line 1544 https://reviews.apache.org/r/36282/diff/1/?file=1001811#file1001811line1544 Wouldn't it be easier --especially considering Adam's comment about MESOS-2832 and the

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

2015-07-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90822 --- Ship it! Looks like a simpler, more generic fix. Maybe