Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 10, 2015, 7:20 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On Aug. 7, 2015, 7:14 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 4950 > > > > > > Much like when we remove a pid-based framework, we need to wipe the > > authentication related data here. Good catc

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94496 --- Ship it! I left some comments here so you could see the issues I no

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On Aug. 6, 2015, 6:39 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 4990 > > > > > > Don't we still want this since we call pid.get()? Persisted the CHECK_SOME. Removed the misleading message though as

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 7, 2015, 2:27 a.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94428 --- Thanks, I'll get the HttpConnection change committed, left some note

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 6, 2015, 4:25 p.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On Aug. 6, 2015, 4:10 p.m., Vinod Kone wrote: > > src/common/http.cpp, line 60 > > > > > > need a return here to aviod compiler warning. I am putting in a fix for that. This looks to be as a GCC bug. With -Werror=

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94413 --- src/common/http.cpp (line 60)

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 6, 2015, 4:08 a.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 5, 2015, 10:37 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 11:57 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94130 --- I'll get the exited changes committed. src/master/master.cpp (line

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On Aug. 4, 2015, 9:07 p.m., Ben Mahler wrote: > > I'll get the /call validation committed. Let's follow up to get tests added for each of the error cases in /call. - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 10 p.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94111 --- I'll get the /call validation committed. src/master/http.cpp (line

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On July 29, 2015, 7:12 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2128-2159 > > > > > > Any reason you're skipping validation (authorization) of the framework? > > Looks like we should pull out the

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 4:33 p.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On July 29, 2015, 7:12 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2128-2159 > > > > > > Any reason you're skipping validation (authorization) of the framework? > > Looks like we should pull out the

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93499 --- Looks like this needs a rebase? Wasn't able to get it applied withou

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On July 26, 2015, 4:18 p.m., Jojy Varghese wrote: > > src/master/http.cpp, line 359 > > > > > > Why not static initialization pattern : > > OK ok = { > >.type = Response::PIPE, > >.reade

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On July 26, 2015, 9:37 p.m., Jojy Varghese wrote: > > src/master/http.cpp, line 339 > > > > > > complexity of a function is measured by the nested if condition in it. > > Maybe we accomplish the same using simple

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93060 --- src/master/http.cpp (line 339)

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93048 --- src/master/http.cpp (line 359)

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93033 --- Patch looks great! Reviews applied: [36733, 36717, 36318, 36720] A

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 2:32 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7:42 a.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93022 --- Bad patch! Reviews applied: [36733, 36717, 36318] Failed command:

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7:26 a.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93021 --- Bad patch! Reviews applied: [36733] Failed command: ./support/appl

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 7 a.m.) Review request for mesos and Ben Mahler. Chan

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review92728 --- Bad patch! Reviews applied: [36717, 36318] Failed command: ./suppo

Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.ap