On Aug. 5, 2015, 3:38 a.m., Cody Maloney wrote:
configure.ac, line 548
https://reviews.apache.org/r/36811/diff/6/?file=1025039#file1025039line548
The check should come before we do the AC_SUBST. I don't want to just
move the AC_SUBST way away from the rest of the protobuf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated Aug. 7, 2015, 3:21 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review94562
---
Patch looks great!
Reviews applied: [36810, 36811]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review94176
---
configure.ac (line 544)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 30, 2015, 9:47 a.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93570
---
Patch looks great!
Reviews applied: [36810, 36811]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 7:16 a.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 7:18 a.m.)
Review request for mesos, Adam B and Niklas
On July 28, 2015, 5:58 a.m., Adam B wrote:
Did you test this with java enabled as well? What about without
`--with-protobuf=`? All four combinations still need to compile pass the
unit tests.
haosdent huang wrote:
I only run it with --disable-java and --with_protobuf, let me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 3:41 a.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93386
---
Bad patch!
Reviews applied: [36810, 36811]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 28, 2015, 4:41 p.m.)
Review request for mesos, Adam B and Niklas
On July 28, 2015, 5:58 a.m., Adam B wrote:
Did you test this with java enabled as well? What about without
`--with-protobuf=`? All four combinations still need to compile pass the
unit tests.
I only run it with --disable-java and --with_protobuf, let me test other 3
combinations.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93320
---
Bad patch!
Reviews applied: [36891]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93240
---
Did you test this with java enabled as well? What about without
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93169
---
Oh, yes, thanks!
But I'm confused by your approach, can you please
On July 27, 2015, 7:29 p.m., Marco Massenzio wrote:
configure.ac, lines 1093-1096
https://reviews.apache.org/r/36811/diff/1/?file=1021876#file1021876line1093
did you really mean to move and then comment out these lines? shouldn't
they be uncommented here?
Sorry for upload the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93026
---
Patch looks great!
Reviews applied: [36810, 36811]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2480
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 25, 2015, 8:21 a.m.)
Review request for mesos and Niklas
20 matches
Mail list logo
