Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-03 Thread Srinivas Brahmaroutu
> On Aug. 2, 2016, 1:31 a.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 70 > > > > > > Oh. This is especially pertinent given that you seem to remove this > > line in #49874. I cannot

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-03 Thread Srinivas Brahmaroutu
> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote: > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake, line 51 > > > > > > You're right to split this out, but just for my own education, was > > there a specific reason

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-03 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 3, 2016, 4:40 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-02 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 2, 2016, 3:35 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review144435 --- src/slave/cmake/SlaveConfigure.cmake (line 70)

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-08-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review144432 --- Can you please rebase against the `master` branch so I can apply

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-16 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 16, 2016, 8:33 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 13, 2016, 12:37 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 12, 2016, 4:30 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-12 Thread Srinivas Brahmaroutu
> On July 12, 2016, 4:28 a.m., Alex Clemmer wrote: > > src/CMakeLists.txt, line 477 > > > > > > I'll copy my earlier comment and open up an issue here just to make it > > clear that I consider it a ship-blocker: >

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review141841 --- src/CMakeLists.txt (line 477)

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-11 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 11, 2016, 8:39 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review141755 --- Changing the linking structure of this project has a few very

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-11 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 11, 2016, 3:47 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-09 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 10, 2016, 2:10 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-09 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 10, 2016, 1:49 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

2016-07-09 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 10, 2016, 1 a.m.) Review request for mesos, Alex Clemmer and