Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 10:38 a.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 70 (patched) > > > > > > What do you think of introducing a `QuotaTree` with which we can > > encapsulate all this

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 31, 2017, 10:18 p.m.) Review request for mesos and Michael

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review170761 --- Ship it! src/master/quota_handler.cpp Lines 77-89 (original),

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 30, 2017, 2:06 a.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 28, 2017, 11:06 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 605-618 (patched) > > > > > > Couldn't this be just: > > > > ```cpp > > vector

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 28, 2017, 4:06 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 605-618 (patched) > > > > > > Couldn't this be just: > > > > ```cpp > > vector

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 28, 2017, 11:42 p.m.) Review request for mesos and Michael

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 28, 2017, 11:06 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 111-115 (patched) > > > > > > Is this `CHECK` here to require that we only `insert` once per > > `role`...? If yes, it

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review170328 --- Fix it, then Ship it! src/master/quota_handler.cpp Lines

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 17, 2017, 2:10 a.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 16, 2017, 6:54 a.m., Jay Guo wrote: > > What should be the correct behavior for following case: > > - parent role `/a` is quota'd with `cpus:2;mem:1024` > > - child role `/a/b` is quota'd with `cpus:1;mem:512` > > - `Framework1` subscribes to role `/a` > > - `Framework2` subscribes to

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 16, 2017, 4:53 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 16, 2017, 2:54 p.m., Jay Guo wrote: > > What should be the correct behavior for following case: > > - parent role `/a` is quota'd with `cpus:2;mem:1024` > > - child role `/a/b` is quota'd with `cpus:1;mem:512` > > - `Framework1` subscribes to role `/a` > > - `Framework2` subscribes to

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review169098 --- What should be the correct behavior for following case: - parent

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 10:38 a.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 78 (patched) > > > > > > The general pattern for `validate` I think is to return an > > `Option`. In this case, we could

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 10, 2017, 10:03 p.m.) Review request for mesos and Michael

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 6:38 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 78 (patched) > > > > > > The general pattern for `validate` I think is to return an > > `Option`. In this case, we could

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 9, 2017, 9:39 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 583-605 (patched) > > > > > > I think we should be able to use `strings::tokenize(request.url.path,

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review168670 --- src/master/quota_handler.cpp Lines 141 (patched)

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 10, 2017, 5:04 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 9, 2017, 9:39 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 583-605 (patched) > > > > > > I think we should be able to use `strings::tokenize(request.url.path,

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review168525 --- Fix it, then Ship it! src/master/quota_handler.cpp Lines

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 9, 2017, 4:44 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 6:38 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 70 (patched) > > > > > > What do you think of introducing a `QuotaTree` with which we can > > encapsulate all this stuff?

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review168318 --- src/master/quota_handler.cpp Lines 70 (patched)

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review167200 --- Bad review! Reviews applied: [57167, 57166, 56805, 57165, 57164]

Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- Review request for mesos and Michael Park. Repository: mesos Description