Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 24, 2017, 8:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review175836 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp Lines 538

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review175745 --- Ship it! Ship It! - Chun-Hung Hsiao On May 22, 2017, 6:04

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review175669 --- Bad patch! Reviews applied: [59018, 59017, 59016, 59141, 59015,

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 22, 2017, 11:04 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 12, 2017, 4:20 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-12 Thread Gilbert Song
> On May 10, 2017, 5:56 p.m., Vinod Kone wrote: > > Chatted offline, and leave a TODO for refactoring `getAuthHeader()`. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174584 --- src/uri/fetchers/docker.cpp Line 492 (original), 502 (patched)

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Gilbert Song
> On May 10, 2017, 11:12 a.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 328 (patched) > > > > > > Why are we using `secretValue` instead of `config` as in other places? > > Also, it seems to

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Chun-Hung Hsiao
> On May 10, 2017, 6:12 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 328 (patched) > > > > > > Why are we using `secretValue` instead of `config` as in other places? > > Also, it seems to

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174511 --- Please rebase to the latest master and resolve the conflicts.

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174490 --- Bad patch! Reviews applied: [59018, 59017, 59016, 59141, 59015,

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 10, 2017, 5:48 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-10 Thread Gilbert Song
> On May 5, 2017, 2:42 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 693 (patched) > > > > > > Is it a good idea to overload the "password" field in a URI as a docker > > config carrier? >

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-05 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174075 --- src/uri/fetchers/docker.cpp Lines 693 (patched)

Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

2017-05-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till