Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review198107 --- Fix it, then Ship it! src/checks/checker_process.cpp Lines

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 21, 2018, 2:08 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197830 --- Ship it! Ship It! - Joseph Wu On Feb. 12, 2018, 3:16 p.m.,

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197754 --- PASS: Mesos patch 65127 was successfully built and tested.

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197341 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018,

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 12, 2018, 11:16 p.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197127 --- src/checks/checker_process.cpp Lines 1017-1020 (patched)

Re: Review Request 65127: Windows: Enabled docker health checks.

> On Feb. 2, 2018, 9:53 p.m., Andrew Schwartzmeyer wrote: > > src/checks/checker_process.hpp > > Lines 47 (patched) > > > > > > Should we tag this so a push to their image doesn't break us? I'm not sure how to solve

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 8, 2018, 5:51 p.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196735 --- src/checks/checker_process.hpp Lines 45 (patched)

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 30, 2018, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

> On Jan. 22, 2018, 9:55 p.m., Joseph Wu wrote: > > src/checks/checker_process.cpp > > Lines 479-481 (original), 479-487 (patched) > > > > > > This is a bit unexpected. Considering that these arguments will be > >

Re: Review Request 65127: Windows: Enabled docker health checks.

> On Jan. 22, 2018, 9:55 p.m., Joseph Wu wrote: > > src/checks/checker_process.cpp > > Lines 479-481 (original), 479-487 (patched) > > > > > > This is a bit unexpected. Considering that these arguments will be > >

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 29, 2018, 6:33 p.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 29, 2018, 6:33 p.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196057 --- src/checks/checker_process.cpp Lines 887-888 (original)

Re: Review Request 65127: Windows: Enabled docker health checks.

> On Jan. 22, 2018, 9:55 p.m., Joseph Wu wrote: > > src/checks/checker_process.cpp > > Lines 479-481 (original), 479-487 (patched) > > > > > > This is a bit unexpected. Considering that these arguments will be > >

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195942 --- This patch will likely need a few tweaks based on how the

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 17, 2018, 12:09 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195510 --- src/checks/checker_process.cpp Lines 990-1004 (patched)

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 16, 2018, 4:41 p.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195330 --- PASS: Mesos patch 65127 was successfully built and tested.

Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer.