Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated April 5, 2018, 3:35 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated April 4, 2018, 12:20 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 21, 2018, 1:55 p.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Lines 5137-5138 (patched) > > > > > > Just curious, why do you break the assigment into two lines here but > > not below? ;)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated March 21, 2018, 2:40 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199703 --- Ship it! src/tests/slave_tests.cpp Lines 5137-5138 (patched)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated March 21, 2018, 11:38 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199606 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated March 16, 2018, 12:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 14, 2018, 5:08 p.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Line 4982 (original), 5022 (patched) > > > > > > Is it guaranteed that this lambda will finish before > >

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199267 --- src/tests/slave_tests.cpp Lines 5179 (patched)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199223 --- src/tests/slave_tests.cpp Lines 4158-4160 (patched)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 1, 2018, 11:19 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5455 (patched) > > > > > > Is this necessary? Perhaps we could eliminate the `Future > > failure;`? > > Meng Zhu wrote: >

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 1, 2018, 7:19 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5455 (patched) > > > > > > Is this necessary? Perhaps we could eliminate the `Future > > failure;`? > > Meng Zhu wrote: >

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 1, 2018, 11:19 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 4870-4878 (patched) > > > > > > To avoid flakiness, should we register these expectations before the > > call to

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review198462 --- src/tests/slave_tests.cpp Lines 4870-4878 (patched)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review197658 --- Patch looks great! Reviews applied: [65679] Passed command:

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review197656 --- PASS: Mesos patch 65679 was successfully built and tested.

Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos