Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- (Updated March 20, 2019, 11:24 p.m.) Review request for mesos, Benjamin

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

> On March 20, 2019, 8:55 p.m., Joseph Wu wrote: > > include/mesos/scheduler/scheduler.proto > > Lines 220-228 (original), 223-231 (patched) > > > > > > Is there some reason why the un-versioned protobufs do not

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213851 --- Fix it, then Ship it! Minor question, but other LGTM.

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- (Updated March 15, 2019, 10:35 p.m.) Review request for mesos, Benjamin

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213754 --- Ship it! Ship It! - Gastón Kleiman On March 15, 2019, 3:35

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213751 --- Thanks for the update! This is looking pretty good. We also have

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- (Updated March 14, 2019, 5:24 p.m.) Review request for mesos, Benjamin

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213712 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- (Updated March 14, 2019, 1:41 a.m.) Review request for mesos, Benjamin

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213696 --- Patch looks great! Reviews applied: [70200] Passed command:

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213691 --- src/master/master.cpp Line 9557 (original), 9557-9564 (patched)

Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao,