/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a
src/tests/containerizer/mock_containerizer.hpp
0adcb01e6c12d6cc4abed1f14fa2df833ffc6569
Diff: https://reviews.apache.org/r/56721/diff/8/
Changes: https://reviews.apache.org/r/56721/diff/7-8/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/55334/diff/8-9/
Testing
---
Thanks,
Zhitao Li
e61a85df6ec5308ccd2832e66df803b0ad7b53ee
Diff: https://reviews.apache.org/r/55335/diff/6/
Changes: https://reviews.apache.org/r/55335/diff/5-6/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
(patched)
<https://reviews.apache.org/r/62742/#comment263907>
It seems like this TODO has already been addressed? Is there still a
condition which we need it?
- Zhitao Li
On Oct. 3, 2017, 4 a.m., Jie Yu wrote:
>
> ---
,
Zhitao Li
iff/7/?file=1791112#file1791112line598>
> >
> > what does this comment mean?
I thought about tracking disk space size of sweeping directory (disk usage or
something else), but I realized that any prolonged non-empty sweeping directory
is pretty much a bug, so I guess I'll
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review186320
---
On Oct. 3, 2017, 5:13 p.m., Zhitao Li wrote:
>
> -
---
Thanks,
Zhitao Li
/60511/diff/4-5/
Testing
---
Thanks,
Zhitao Li
gt;config` could be updated one more time if some rootfs is
provisioned.
- Zhitao Li
On Sept. 26, 2017, 7:09 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
://reviews.apache.org/r/55334/diff/10/
Changes: https://reviews.apache.org/r/55334/diff/9-10/
Testing
---
Thanks,
Zhitao Li
/56721/diff/11/
Changes: https://reviews.apache.org/r/56721/diff/10-11/
Testing
---
Thanks,
Zhitao Li
ll.
2. Manually tested that images previous pulled but not running can be purged
through new operator API call while active images (running or being pulled) are
not affected.
Thanks,
Zhitao Li
,
Zhitao Li
,
Zhitao Li
/60511/diff/5-6/
Testing
---
Thanks,
Zhitao Li
?
3rdparty/grpc-1.4.2.patch
Lines 34 (patched)
<https://reviews.apache.org/r/62876/#comment264741>
trailing whitespace?
3rdparty/grpc-1.4.2.patch
Lines 186 (patched)
<https://reviews.apache.org/r/62876/#comment264742>
ditto
- Zhitao Li
On Oct. 11, 2017, 12:49 a.m., Chun-Hung
exclusive.
This implementation guarantees starvation free for `lock()` by queuing up
`rlock()` when some `lock()` is already in queue.
Diffs
-
3rdparty/libprocess/include/process/rwmutex.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/62911/diff/1/
Testing
---
Thanks,
Zhitao Li
d9ca23de13100619dbb6a9c0b53f78ea30d390f1
3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/62912/diff/1/
Testing
---
Thanks,
Zhitao Li
/provisioner/provisioner.cpp
450a3b32d69d2882973a6ed4e94e169a0256056b
Diff: https://reviews.apache.org/r/62997/diff/1/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/56721/diff/12/
Changes: https://reviews.apache.org/r/56721/diff/11-12/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/62853/diff/2/
Changes: https://reviews.apache.org/r/62853/diff/1-2/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/60471/diff/6/
Changes: https://reviews.apache.org/r/60471/diff/5-6/
Testing
---
Thanks,
Zhitao Li
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e
src/slave/containerizer/mesos/provisioner/provisioner.cpp
450a3b32d69d2882973a6ed4e94e169a0256056b
Diff: https://reviews.apache.org/r/62997/diff/2/
Changes: https://reviews.apache.org/r/62997/diff/1-2/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
,
Zhitao Li
,
Zhitao Li
support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c
support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6
Diff: https://reviews.apache.org/r/62911/diff/2/
Changes: https://reviews.apache.org/r/62911/diff/1-2/
Testing
---
Thanks,
Zhitao Li
94c7a722aab6c36174f117f0b6239cb988e476a9
3rdparty/libprocess/include/process/rwmutex.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/62911/diff/3/
Changes: https://reviews.apache.org/r/62911/diff/2-3/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
(unlocked) {
> > grab read lock
> > } else if (read locked and no waiters) {
> > grab read lock
> > } else {
> > queue
> > }
> > ```
> >
> > Also it's probably better to explain the priority sema
-4/
Testing
---
Thanks,
Zhitao Li
/62912/diff/3/
Changes: https://reviews.apache.org/r/62912/diff/2-3/
Testing
---
Thanks,
Zhitao Li
eply, visit:
https://reviews.apache.org/r/55335/#review186191
---
On Sept. 26, 2017, 8:14 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To re
/
Testing
---
Thanks,
Zhitao Li
f357710cb19aec3654b0604f7909d068eaf20095
src/tests/containerizer/provisioner_docker_tests.cpp
920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60511/diff/6/
Testing
---
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63170/#review188770
---
Ship it!
Ship It!
- Zhitao Li
On Oct. 19, 2017, 9:20 p.m
78fdd21f8b7ede4beedff31ba2b488ffebd4ea31
src/slave/containerizer/mesos/paths.hpp
a03f15e01e8eb8a1326baad8d7db96a79d785482
src/slave/containerizer/mesos/paths.cpp
0c61c20c345a327ec469b382558aaeed0280e754
Diff: https://reviews.apache.org/r/55334/diff/11/
Testing
---
Thanks,
Zhitao Li
agent from 1.3.1 build with oversubscription enabled to a
master with this patch, and verifies that master can properly update over
subscribed resources.
Without this patch master crashes like in MESOS-8090.
Thanks,
Zhitao Li
Description
---
If calls to these checks fails, log related resources objects which
causes the failure.
Diffs
-
src/master/allocator/sorter/drf/sorter.hpp
77e52dec735d276389643f7f356cd763b2f785e9
Diff: https://reviews.apache.org/r/63332/diff/1/
Testing
---
Thanks,
Zhitao Li
r.hpp
77e52dec735d276389643f7f356cd763b2f785e9
Diff: https://reviews.apache.org/r/63332/diff/2/
Changes: https://reviews.apache.org/r/63332/diff/1-2/
Testing
---
Thanks,
Zhitao Li
/diff/3/
Changes: https://reviews.apache.org/r/63332/diff/2-3/
Testing
---
Thanks,
Zhitao Li
77e52dec735d276389643f7f356cd763b2f785e9
Diff: https://reviews.apache.org/r/63332/diff/4/
Changes: https://reviews.apache.org/r/63332/diff/3-4/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/63332/diff/5/
Changes: https://reviews.apache.org/r/63332/diff/4-5/
Testing (updated)
---
Compile it on Linux.
Thanks,
Zhitao Li
---------
On Oct. 20, 2017, 4:41 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55334/
> -
------
On Oct. 17, 2017, 5:04 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
: https://reviews.apache.org/r/55334/diff/11-12/
Testing
---
Thanks,
Zhitao Li
/12-13/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/55335/diff/7/
Changes: https://reviews.apache.org/r/55335/diff/6-7/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
fbd2887800ccfd64c8628c5d6fd77a511c8f91d5
Diff: https://reviews.apache.org/r/59687/diff/3/
Changes: https://reviews.apache.org/r/59687/diff/2-3/
Testing
---
Thanks,
Zhitao Li
ing
---
Thanks,
Zhitao Li
Zhitao Li
On Oct. 19, 2017, 4:28 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56721/
> ---
> On Oct. 30, 2017, 6:17 p.m., Zhitao Li wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp
> > Lines 578 (patched)
> > <https://reviews.apache.org/r/56721/diff/13/?file=1863873#file1863873line578>
> >
> > To capture the discussion fr
ld have to clean that up one more time.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review189625
--------
---
Thanks,
Zhitao Li
eaks the current provisioner and store abstraction.
- Zhitao Li
On Oct. 27, 2017, 6:03 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
/55334/diff/13-14/
Testing
---
Thanks,
Zhitao Li
/diff/14-15/
Testing
---
Thanks,
Zhitao Li
/8/
Changes: https://reviews.apache.org/r/55335/diff/7-8/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e
src/slave/containerizer/mesos/provisioner/provisioner.cpp
450a3b32d69d2882973a6ed4e94e169a0256056b
Diff: https://reviews.apache.org/r/62997/diff/4/
Changes: https://reviews.apache.org/r/62997/diff/3-4/
Testing
---
Thanks,
Zhitao Li
cd140f4263621a0a33a34b7e062a9ca6cf426e7a
src/tests/containerizer/mock_containerizer.hpp
0adcb01e6c12d6cc4abed1f14fa2df833ffc6569
Diff: https://reviews.apache.org/r/56721/diff/15/
Changes: https://reviews.apache.org/r/56721/diff/14-15/
Testing
---
Thanks,
Zhitao Li
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review190636
-------
On Nov. 10, 2017, 7:34 p.m., Zhitao Li wrote:
>
> ---
>
s://reviews.apache.org/r/56721/#review190783
-----------
On Nov. 10, 2017, 7:34 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail.
s://reviews.apache.org/r/56721/#review190783
-----------
On Nov. 10, 2017, 7:34 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56721/
> --
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e
src/slave/containerizer/mesos/provisioner/provisioner.cpp
450a3b32d69d2882973a6ed4e94e169a0256056b
Diff: https://reviews.apache.org/r/62997/diff/5/
Changes: https://reviews.apache.org/r/62997/diff/4-5/
Testing
---
Thanks,
Zhitao Li
cd140f4263621a0a33a34b7e062a9ca6cf426e7a
src/tests/containerizer/mock_containerizer.hpp
0adcb01e6c12d6cc4abed1f14fa2df833ffc6569
Diff: https://reviews.apache.org/r/56721/diff/16/
Changes: https://reviews.apache.org/r/56721/diff/15-16/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/55334/diff/16/
Changes: https://reviews.apache.org/r/55334/diff/15-16/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review191117
-------
On Nov. 16, 2017, 4 a.m., Zhitao Li wrote:
>
> ---
> This is
active images (running or being pulled) are
not affected.
Thanks,
Zhitao Li
/mesos_containerizer_tests.cpp
ce67def65aa65188aff10f5316fcd8b745d0abf2
src/tests/containerizer/provisioner_docker_tests.cpp
832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/9/
Changes: https://reviews.apache.org/r/60471/diff/8-9/
Testing
---
Thanks,
Zhitao Li
334/diff/16/
Testing
---
Thanks,
Zhitao Li
/nested_mesos_containerizer_tests.cpp
d9b1173ad6860ed06e24285551aab9117eddbc96
Diff: https://reviews.apache.org/r/59687/diff/4/
Changes: https://reviews.apache.org/r/59687/diff/3-4/
Testing
---
Thanks,
Zhitao Li
test and run it?
Sorry missed this one.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review191230
---
On No
Diff: https://reviews.apache.org/r/59687/diff/5/
Changes: https://reviews.apache.org/r/59687/diff/4-5/
Testing
---
Thanks,
Zhitao Li
ing
---
Thanks,
Zhitao Li
,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63900/#review191304
---
Ship it!
Ship It!
- Zhitao Li
On Nov. 17, 2017, 6:54 a.m
://reviews.apache.org/r/62853/diff/3/
Changes: https://reviews.apache.org/r/62853/diff/2-3/
Testing
---
Thanks,
Zhitao Li
.
Thanks,
Zhitao Li
:
https://reviews.apache.org/r/56722/#review191277
-------
On Nov. 17, 2017, 4:48 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56722/#review191277
-------
On Nov. 17, 2017, 4:48 p.m., Zhitao Li wrote:
>
> --
---
Thanks,
Zhitao Li
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review191286
---
On Nov. 17, 2017, 4:51 p.m., Zhitao Li wrot
,
Zhitao Li
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e
src/slave/containerizer/mesos/provisioner/provisioner.cpp
450a3b32d69d2882973a6ed4e94e169a0256056b
Diff: https://reviews.apache.org/r/62997/diff/6/
Changes: https://reviews.apache.org/r/62997/diff/5-6/
Testing
---
Thanks,
Zhitao Li
/9/
Changes: https://reviews.apache.org/r/55335/diff/8-9/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
c6f1ec0b000781270b7c79d5e776575c6df778aa
src/tests/containerizer/mock_containerizer.hpp
5befcccecdb76f3b70993642128745a0134ffa65
Diff: https://reviews.apache.org/r/56721/diff/18/
Testing
---
Thanks,
Zhitao Li
(running or being pulled) are
not affected.
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/62853/diff/4/
Changes: https://reviews.apache.org/r/62853/diff/3-4/
Testing
---
Thanks,
Zhitao Li
98adcfcfba4e5ee975b7ed0c073758ec2726763d
src/tests/containerizer/provisioner_docker_tests.cpp
832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/12/
Changes: https://reviews.apache.org/r/60471/diff/11-12/
Testing
---
Thanks,
Zhitao Li
quot;` are gone.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/64265/#comment270909>
`required` fields are generally harder to handler during upgrade once we
introduce them. Can we find sane way to declare them `optional`? (Mayor be use
comment to indicate what non-zero actual value is used when not set?)
- Zhitao Li
On Dec. 2, 2
often
have different cycles.
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/64267/#comment270911>
I think adding an early return is more readable
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64269/#review192653
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64270/#review192654
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64268/#review192655
---
Ship it!
Ship It!
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m
Add a VLOG for else case?
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
task again, we should get an error because the image is pruned in store cache
nor available in "registrY" anymore.
- Zhitao Li
On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically
401 - 500 of 929 matches
Mail list logo
