[GitHub] spark pull request: [SPARK-7100][MLLib] Fix persisted RDD leak in ...

2015-04-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5669#issuecomment-97033634 This test actually passed, but Jenkins failed to post. LGTM. data: {body: [Test build #723 has

[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...

2015-04-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5737#issuecomment-97035568 LGTM. CC @mateiz for a quick look, as the original author. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-97077121 [Test build #31141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31141/consoleFull) for PR 4419 at commit

[GitHub] spark pull request: [SPARK-7097][SQL]: Partitioned tables should o...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5668#issuecomment-97027355 [Test build #31139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31139/consoleFull) for PR 5668 at commit

[GitHub] spark pull request: [SPARK-7156][SQL] add randomSplit to DataFrame...

2015-04-28 Thread kaka1992
Github user kaka1992 commented on the pull request: https://github.com/apache/spark/pull/5711#issuecomment-97054424 Can I add InMemoryRelation upon the base logicalPlan? Then I could create several randomSplit plans with the same data. @rxin I'm not sure if this way would break

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-28 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-97085929 @zzcclp the 1.4.0 deadline is Friday, I believe. I fixed the merge conflicts and resolved the MiMa issue (as far as I know), it still passes local tests for me.

[GitHub] spark pull request: [SPARK-4705] Handle multiple app attempts even...

2015-04-28 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/5432#discussion_r29231506 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -125,30 +138,85 @@ private[history] class HistoryPage(parent:

[GitHub] spark pull request: [SPARK-4705] Handle multiple app attempts even...

2015-04-28 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/5432#discussion_r29232245 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -159,52 +167,52 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-7133][SQL] Implement struct, array, and...

2015-04-28 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/5744 [SPARK-7133][SQL] Implement struct, array, and map field accessor It's the first step: generalize UnresolvedGetField to support all map, struct, and array TODO: add apply in Scala and

[GitHub] spark pull request: SPARK-6954. [YARN] ExecutorAllocationManager c...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5704#issuecomment-97189288 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-6954. [YARN] ExecutorAllocationManager c...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5704#issuecomment-97189292 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-6954. [YARN] ExecutorAllocationManager c...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5704#issuecomment-97189250 [Test build #31149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31149/consoleFull) for PR 5704 at commit

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5473#discussion_r29282354 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingJobProgressListener.scala --- @@ -40,6 +47,30 @@ private[streaming] class

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-04-28 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-97190904 OK, so I am testing with the t.renew method. It will take an hour or so (I have the renewal interval set to 10 mins). Once it is done, I will push the update.

[GitHub] spark pull request: [SPARK-7183][Network] Fix memory leak of Trans...

2015-04-28 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/5743#issuecomment-97192903 This is a reasonable solution, but I think that the actual issue that TransportRequestHandler has a list of streamIds at all. I think a different solution would be to

[GitHub] spark pull request: [SPARK-3454] separate json endpoints for data ...

2015-04-28 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-97192934 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-04-28 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-97193106 as you say the token has a renew method. It hands you back the expiration on that renew. you can store that expiration. Are you changing to renew for 7 days

[GitHub] spark pull request: [SPARK-6612] [MLLib] [PySpark] Python KMeans p...

2015-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5647#discussion_r29283073 --- Diff: python/pyspark/mllib/clustering.py --- @@ -95,6 +106,13 @@ def predict(self, x): best_distance = distance return

[GitHub] spark pull request: [SPARK-7045] [MLlib] Avoid intermediate repres...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5748#issuecomment-97193731 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7045] [MLlib] Avoid intermediate repres...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5748#issuecomment-97193722 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7045] [MLlib] Avoid intermediate repres...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5748#issuecomment-97193688 [Test build #31150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31150/consoleFull) for PR 5748 at commit

[GitHub] spark pull request: [SPARK-7188] added python support for math Dat...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5750#issuecomment-97194459 [Test build #31156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31156/consoleFull) for PR 5750 at commit

[GitHub] spark pull request: [SPARK-6612] [MLLib] [PySpark] Python KMeans p...

2015-04-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5647#issuecomment-97194284 @FlytxtRnD That tiny issue is the only one I see. After that, I think this PR will be good to go. Thanks! --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-7188] added python support for math Dat...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5750#issuecomment-97194475 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7188] added python support for math Dat...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5750#issuecomment-97194477 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-04-28 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-97194597 I am just doing the renew to get the expiration. That keeps the logic the same - always login using keytab and get new tokens rather than having different code

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-97262577 [Test build #31182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31182/consoleFull) for PR 4537 at commit

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5725#discussion_r29300182 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -207,7 +210,23 @@ private[spark] class Executor( // Run the

[GitHub] spark pull request: [SPARK-3454] separate json endpoints for data ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-97271246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3454] separate json endpoints for data ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-97271247 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-97277906 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5725#discussion_r29303890 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -30,6 +30,7 @@ private[spark] object SQLConf { val DEFAULT_SIZE_IN_BYTES =

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-97277905 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [TESTING ONLY] [DO] [NOT] [MERGE]

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5765#issuecomment-97277941 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-97277895 [Test build #31190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31190/consoleFull) for PR 5694 at commit

[GitHub] spark pull request: [TESTING ONLY] [DO] [NOT] [MERGE]

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5765#issuecomment-97277921 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7007][core] Add a metric source for Exe...

2015-04-28 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/5589#issuecomment-97279582 Hi @andrewor14 , thanks a lot for your comments, I will change the code accordingly. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4419#discussion_r29305239 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -208,3 +225,224 @@ class EMLDAOptimizer extends LDAOptimizer{

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-97282236 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-97282227 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283159 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283157 [Test build #31207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31207/consoleFull) for PR 4960 at commit

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283160 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97284000 [Test build #31202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31202/consoleFull) for PR 5725 at commit

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97284005 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283954 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283965 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7056][Streaming] Make the Write Ahead L...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5645#issuecomment-97283992 [Test build #31210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31210/consoleFull) for PR 5645 at commit

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97284068 [Test build #31211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31211/consoleFull) for PR 4960 at commit

[GitHub] spark pull request: [SPARK-7056][Streaming] Make the Write Ahead L...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5645#issuecomment-97284177 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7215] made coalesce and repartition a p...

2015-04-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5762#discussion_r29306234 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -310,6 +310,10 @@ case class Distinct(child:

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97284007 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7138][Streaming] Add method to BlockGen...

2015-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5695 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7133][SQL] Implement struct, array, and...

2015-04-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5744#issuecomment-97286701 We should definitely keep the old function for compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-7156][SQL] support RandomSplit in DataF...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5761#issuecomment-97246445 [Test build #31184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31184/consoleFull) for PR 5761 at commit

[GitHub] spark pull request: [SPARK-7156][SQL] support RandomSplit in DataF...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5761#issuecomment-97247809 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7156][SQL] support RandomSplit in DataF...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5761#issuecomment-97247896 [Test build #31186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31186/consoleFull) for PR 5761 at commit

[GitHub] spark pull request: [SPARK-3376] Add in-memory shuffle option.

2015-04-28 Thread mikeringenburg
Github user mikeringenburg commented on the pull request: https://github.com/apache/spark/pull/5403#issuecomment-97247933 In response to @sryza's second question, I'm very interested in this PR, and would be happy to volunteer to help out wherever it's needed, including maintenance

[GitHub] spark pull request: [SPARK-7156][SQL] support RandomSplit in DataF...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5761#issuecomment-97247839 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-97247950 @hhbyyh Thanks for the update! It's looking good, but there are some cleanups to do. There are quite a few more I'd like to do, but since they are mostly Scala style

[GitHub] spark pull request: [SPARK-7138][Streaming] Add method to BlockGen...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5695#issuecomment-97254470 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7138][Streaming] Add method to BlockGen...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5695#issuecomment-97254531 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7133][SQL] Implement struct, array, and...

2015-04-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5744#issuecomment-97257795 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97263417 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97263416 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5725#issuecomment-97263384 **[Test build #31173 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31173/consoleFull)** for PR 5725 at commit

[GitHub] spark pull request: [SPARK-6756] [MLLIB] add toSparse, toDense, nu...

2015-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5756#discussion_r29301064 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -116,6 +116,39 @@ sealed trait Vector extends Serializable { *

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-97268385 @jkbradley Thanks. I'll start to work based on current comments. Meanwhile, it's most welcome if you can send the PR. (I'm not sure how should I operate, can I just

[GitHub] spark pull request: [SPARK-6627] Finished rename to ShuffleBlockRe...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5764#issuecomment-97270104 [Test build #31194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31194/consoleFull) for PR 5764 at commit

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5725#discussion_r29301548 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -207,7 +210,23 @@ private[spark] class Executor( // Run the

[GitHub] spark pull request: [SPARK-7215] made coalesce and repartition a p...

2015-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/5762#discussion_r29301550 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -245,6 +245,19 @@ case class Distinct(partial: Boolean, child:

[GitHub] spark pull request: [SPARK-6965] [MLLIB] StringIndexer handles num...

2015-04-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5753#issuecomment-97273307 LGTM I'll merge this into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6479][Block Manager]Create off-heap blo...

2015-04-28 Thread zhzhan
Github user zhzhan commented on the pull request: https://github.com/apache/spark/pull/5430#issuecomment-97273011 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7076][SPARK-7077][SPARK-7080][SQL] Use ...

2015-04-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5725#discussion_r29303752 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala --- @@ -265,7 +283,49 @@ case class GeneratedAggregate(

[GitHub] spark pull request: [SPARK-6314][CORE] handle JsonParseException f...

2015-04-28 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/5736#issuecomment-97282994 Thanks to @andrewor14 and @vanzin's comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283008 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97282993 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-97283039 [Test build #31207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31207/consoleFull) for PR 4960 at commit

[GitHub] spark pull request: [SPARK-6923] [SQL] Hive MetaStore API cannot a...

2015-04-28 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5733#discussion_r29306623 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -157,6 +157,14 @@ private[hive] class

[GitHub] spark pull request: [SPARK-7208] [ml] [python] Added Matrix, Spars...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5759#issuecomment-97286107 [Test build #31214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31214/consoleFull) for PR 5759 at commit

[GitHub] spark pull request: [SPARK-7183][Network] Fix memory leak of Trans...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5743#issuecomment-97288428 [Test build #31219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31219/consoleFull) for PR 5743 at commit

[GitHub] spark pull request: [Core][test][minor] replace try finally block ...

2015-04-28 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/5739#issuecomment-97287644 Hi @vanzin , the way you suggested may not able to get exception threw from `try` block, so that some sibling exceptions may not able to be suppressed. --- If

[GitHub] spark pull request: [SPARK-7183][Network] Fix memory leak of Trans...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5743#issuecomment-97288321 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7183][Network] Fix memory leak of Trans...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5743#issuecomment-97288286 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3454] separate json endpoints for data ...

2015-04-28 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-97245702 Lemme summarize what I've addressed: * I changed the way jersey uses jackson to clean up the dependencies. It leads to a setup that doesn't fit the standard

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-97253799 Also, there are a few to-do items: * unit tests * This is the big item. Do you have an idea of how you plan to test this? Some things, such as getters and

[GitHub] spark pull request: [SPARK-7215] made coalesce and repartition a p...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5762#issuecomment-97267665 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6943][WIP] Show RDD DAG visualization o...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5729#issuecomment-97267900 **[Test build #31179 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31179/consoleFull)** for PR 5729 at commit

[GitHub] spark pull request: [SPARK-6756] [MLLIB] add toSparse, toDense, nu...

2015-04-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5756#issuecomment-97268597 LGTM other than those small comments, and the MIMA issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-7215] made coalesce and repartition a p...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5762#issuecomment-97268850 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3454] separate json endpoints for data ...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-97271241 [Test build #31183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31183/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: [SPARK-7138][Streaming] Add method to BlockGen...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5695#issuecomment-97272468 [Test build #31188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31188/consoleFull) for PR 5695 at commit

[GitHub] spark pull request: [SPARK-7138][Streaming] Add method to BlockGen...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5695#issuecomment-97272491 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7208] [ml] [python] Added Matrix, Spars...

2015-04-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5759#issuecomment-97273547 [Test build #731 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/731/consoleFull) for PR 5759 at commit

[GitHub] spark pull request: [SPARK-6965] [MLLIB] StringIndexer handles num...

2015-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6756] [MLLIB] add toSparse, toDense, nu...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5756#issuecomment-97273551 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6479][Block Manager]Create off-heap blo...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5430#issuecomment-97273552 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6756] [MLLIB] add toSparse, toDense, nu...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5756#issuecomment-97273533 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6479][Block Manager]Create off-heap blo...

2015-04-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5430#issuecomment-97273537 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-04-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/4419#discussion_r29303059 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -208,3 +225,224 @@ class EMLDAOptimizer extends LDAOptimizer{

  1   2   3   4   5   6   7   8   9   10   >