[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-05 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10037#discussion_r46767133 --- Diff: R/pkg/R/generics.R --- @@ -623,6 +623,10 @@ setGeneric("getItem", function(x, ...) { standardGeneric("getItem") }) #' @rdname column

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10160#discussion_r46767022 --- Diff: R/pkg/R/DataFrame.R --- @@ -677,25 +677,44 @@ setMethod("unique", #' collect(sample(df, TRUE, 0.5)) #'} setMethod("sample", -

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162280722 @cloud-fan Thanks.. i have moved the test to analysis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-05 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10037#issuecomment-162281940 Thanks @sun-rui @felixcheung for the clarifications and @yanboliang for the change. LGTM. Merging this to master, branch-1.6 --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10037 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162184096 **[Test build #47222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47222/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-12084][Core]Fix codes that uses ByteBuf...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10083#issuecomment-162194497 @vanzin @zsxwing it looked like enough of an important fix to go into 1.6.x -- any strong objections to that? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-162194399 It looks like this is only for YARN client mode. I actually think the reference in `SparkConf` should be removed. It's not otherwise documented, so no I don't think we

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162207582 **[Test build #47225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47225/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10154#discussion_r46759351 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala --- @@ -128,11 +152,36 @@ private[ui] class ExecutorsPage(

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-05 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162211879 @vanzin yes, I think you said is right. Now i add REST API for executor list. Can you take a look again? Thanks. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162211965 **[Test build #47225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47225/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162211985 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-162211929 **[Test build #2173 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2173/consoleFull)** for PR 10154 at commit

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162211988 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-162212722 **[Test build #2173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2173/consoleFull)** for PR 10154 at commit

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162212702 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162194663 **[Test build #47223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47223/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-10299][ML] word2vec should allow users ...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8513#issuecomment-162200774 I'm OK with this but I'm only uncertain about merging for 1.6.0. Eh, 1.7.0? 2.0.0? it just matters because of the version label in `@since`. I had preferred writing

[GitHub] spark pull request: add support of arbitrary length sentence by us...

2015-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46759178 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -281,16 +280,17 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-162212321 Merged to master, as https://github.com/apache/spark/commit/a0af0e351e45a8be47a6f65efd132eaa4a00c9e4 was --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162183718 cc @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/spark/pull/10158 [SPARK-12041] [ML] [PySpark] Add columnSimilarities to IndexedRowMatrix Add `columnSimilarities` to IndexedRowMatrix for PySpark spark.mllib.linalg. You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162184124 **[Test build #47222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47222/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162184126 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162184127 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162194673 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162194675 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: add support of arbitrary length sentence by us...

2015-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46759159 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -520,7 +537,7 @@ class Word2VecModel private[spark] ( * @return

[GitHub] spark pull request: add support of arbitrary length sentence by us...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-162206668 @ygcao back up a moment and read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark first. You need to update this PR and connect it to the JIRA.

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162209515 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162209506 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10154#discussion_r46759338 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala --- @@ -117,6 +119,28 @@ private[ui] class ExecutorsPage( val

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10154#discussion_r46759346 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala --- @@ -128,11 +152,36 @@ private[ui] class ExecutorsPage(

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10156#discussion_r46766446 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1143,4 +1143,10 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10156#discussion_r46766481 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1143,4 +1143,10 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/10160#discussion_r46766729 --- Diff: R/pkg/R/DataFrame.R --- @@ -677,25 +677,44 @@ setMethod("unique", #' collect(sample(df, TRUE, 0.5)) #'} setMethod("sample",

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/10160#discussion_r46766732 --- Diff: R/pkg/R/DataFrame.R --- @@ -677,25 +677,44 @@ setMethod("unique", #' collect(sample(df, TRUE, 0.5)) #'} setMethod("sample",

[GitHub] spark pull request: [SPARK-11994][Mllib] Word2VecModel load and sa...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11824] [WEBUI] WebUI does not render de...

2015-12-05 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/10159 [SPARK-11824] [WEBUI] WebUI does not render descriptions with 'bad' HTML, throws console error Don't warn when description isn't valid HTML since it may properly be like "SELECT ... where foo <=

[GitHub] spark pull request: [SPARK-10797] RDD's coalesce should not write ...

2015-12-05 Thread ehnalis
Github user ehnalis commented on the pull request: https://github.com/apache/spark/pull/8979#issuecomment-162234560 @JoshRosen, how's your refactoring? Should I rebase to PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162237893 **[Test build #47229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47229/consoleFull)** for PR 9940 at commit

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162237942 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162237940 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162212701 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162218363 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162218361 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162233127 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162233128 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162216716 **[Test build #47227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47227/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-11955][SQL] Mark particular fields in m...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162225702 **[Test build #47229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47229/consoleFull)** for PR 9940 at commit

[GitHub] spark pull request: [SPARK-11824] [WEBUI] WebUI does not render de...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10159#issuecomment-162232354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11824] [WEBUI] WebUI does not render de...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10159#issuecomment-162232355 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11994][Mllib] Word2VecModel load and sa...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9989#issuecomment-162212899 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9972#issuecomment-162213544 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11988] [ML] [MLLIB] Update JPMML to 1.2...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9972 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-12-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8785#issuecomment-162213600 @tribbloid are you still working on this? I had an outstanding question or two here --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-162218333 **[Test build #47227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47227/consoleFull)** for PR 10158 at commit

[GitHub] spark pull request: [SPARK-11824] [WEBUI] WebUI does not render de...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10159#issuecomment-162219420 **[Test build #47228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47228/consoleFull)** for PR 10159 at commit

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10160 [SPARK-12158] [R] [SQL] Fix 'sample' functions that break R unit test cases The existing sample functions miss the parameter 'seed', however, the corresponding function interface in `generics`

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162231986 **[Test build #47230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47230/consoleFull)** for PR 10160 at commit

[GitHub] spark pull request: [SPARK-11824] [WEBUI] WebUI does not render de...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10159#issuecomment-162232304 **[Test build #47228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47228/consoleFull)** for PR 10159 at commit

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162233087 **[Test build #47230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47230/consoleFull)** for PR 10160 at commit

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-162173968 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-162173970 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-162173861 **[Test build #47220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47220/consoleFull)** for PR 10157 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162175330 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162175288 **[Test build #47221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47221/consoleFull)** for PR 10156 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162175328 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9981#issuecomment-162171566 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9981#issuecomment-162171536 **[Test build #47219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47219/consoleFull)** for PR 9981 at commit

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9981#issuecomment-162171565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12080] [SparkCore] Kryo - Support multi...

2015-12-05 Thread Botnaim
Github user Botnaim commented on the pull request: https://github.com/apache/spark/pull/10078#issuecomment-162176027 What's the status of merging ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4231][MLLIB][Examples] MAP calculation ...

2015-12-05 Thread debasish83
Github user debasish83 commented on the pull request: https://github.com/apache/spark/pull/5869#issuecomment-162240882 @srowen actually I am not sure if MAP calculation got added in ML pipeline or not...I will look into it and if someone else already added it, I will close the PR

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-05 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-162252793 Sounds good. If you can add that maxRatePerPartition handling this would be ready to go from my point of view On Dec 5, 2015 3:59 PM, "Jason White"

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-05 Thread ygcao
Github user ygcao commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46763785 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -520,7 +537,7 @@ class Word2VecModel private[spark] ( * @return

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162254231 **[Test build #47231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47231/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10150#issuecomment-162257194 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-05 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/10161 [SPARK-12160][MLLIB] Use SQLContext.getOrCreate in MLlib Switched from using SQLContext constructor to using getOrCreate, mainly in model save/load methods. This covers all instances in

[GitHub] spark pull request: [SPARK-11715][SPARKR] Add R support corr for C...

2015-12-05 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9680#issuecomment-162258164 LGTM. @felixcheung I think the current resolution of not adding `cor` until we can support it is fine by me. Its better to not mask existing functions unless we can

[GitHub] spark pull request: [SPARK-11715][SPARKR] Add R support corr for C...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162258723 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/10037#discussion_r46765017 --- Diff: R/pkg/R/generics.R --- @@ -623,6 +623,10 @@ setGeneric("getItem", function(x, ...) { standardGeneric("getItem") }) #' @rdname column

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10150#issuecomment-162257197 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10150#issuecomment-162257155 **[Test build #47232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47232/consoleFull)** for PR 10150 at commit

[GitHub] spark pull request: [SPARK-11774][SPARKR] Implement struct(), enco...

2015-12-05 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9804#issuecomment-162257685 LGTM. Thanks @sun-rui -- Sorry for the delay in reviewing this. Merging this to master and branch-1.6 --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-11774][SPARKR] Implement struct(), enco...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12034][SPARKR] Eliminate warnings in Sp...

2015-12-05 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10030#issuecomment-162260113 I'm sorry @sun-rui -- looks like some other merge again conflicts. Could you ping this thread once its up to date ? I will merge this PR asap after that. --- If your

[GitHub] spark pull request: [SPARK-12115] [SparkR] Change numPartitions() ...

2015-12-05 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10123#issuecomment-162260167 LGTM. Merging this. Thanks @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-05 Thread JasonMWhite
Github user JasonMWhite commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-162260106 `maxRatePerPartition` now respects the limit set by `maxRateLimitPerPartition`, if it is set. Let me know if you think any additional tests are needed. --- If

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/10037#discussion_r46765043 --- Diff: R/pkg/R/generics.R --- @@ -623,6 +623,10 @@ setGeneric("getItem", function(x, ...) { standardGeneric("getItem") }) #' @rdname

[GitHub] spark pull request: [branch-1.5][SPARK-11821] Propagate Kerberos k...

2015-12-05 Thread woj-i
Github user woj-i closed the pull request at: https://github.com/apache/spark/pull/9837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162161856 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9981#issuecomment-162163215 **[Test build #47219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47219/consoleFull)** for PR 9981 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162167532 **[Test build #47218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47218/consoleFull)** for PR 10156 at commit

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-162168151 **[Test build #47220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47220/consoleFull)** for PR 10157 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162168663 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9981#discussion_r46755970 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -149,12 +149,12 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-11619][SQL] cannot use UDTF in DataFram...

2015-12-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9981#discussion_r46755983 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -176,6 +176,15 @@ class DataFrameSuite extends QueryTest with

  1   2   >