Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195243785
Discussion:
in dev/lint-r.R:
{code}
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
devtools::install_github("jimhester/lintr")
}
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11640#issuecomment-195243779
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195243624
**[Test build #52913 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52913/consoleFull)**
for PR 11652 at commit
[`22d85d5`](https://gi
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/11653
DataFrame -> Dataset in Java MaxAbsScaler example
## What changes were proposed in this pull request?
Fix build failure introduced in #11392
## How was this patch tested?
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11653#issuecomment-195246455
**[Test build #52914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52914/consoleFull)**
for PR 11653 at commit
[`d3f8100`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195246883
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195246878
**[Test build #52913 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52913/consoleFull)**
for PR 11652 at commit
[`22d85d5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195246885
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195248388
I like the principle, but passing around an error message as an arg to
`SparkEnv` makes this tiny aspect leak too much into the API. If it's just to
be able to report wh
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-195248289
**[Test build #52915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52915/consoleFull)**
for PR 11596 at commit
[`bea871f`](https://gi
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/11654
[HOTFIX][SQL] Fixes compilation failure caused by conflicts between PR
#11392 and PR #11443
## What changes were proposed in this pull request?
PR #11392 was merged after PR #11443, whic
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195249462
@liancheng I've opened a PR already for this #11653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195250052
**[Test build #52916 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52916/consoleFull)**
for PR 11654 at commit
[`f416d02`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11653#issuecomment-195250215
**[Test build #52914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52914/consoleFull)**
for PR 11653 at commit
[`d3f8100`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-195250466
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-195250446
**[Test build #52915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52915/consoleFull)**
for PR 11596 at commit
[`bea871f`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-195250469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195250651
**[Test build #52909 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52909/consoleFull)**
for PR 11647 at commit
[`c75e602`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195251580
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11653#issuecomment-195250892
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195251569
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11653#issuecomment-195250903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195252149
it sames something wrong in JavaMaxAbsScalerExample...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195252458
@liancheng I'm merging #11653 now, so this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195254363
@MLnick Thanks! Closing this in favor of #11653.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/11654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195254744
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195254726
Cool - sorry about that, Jenkins had passed for PR #11392 but before PR
#11443 was merged :(
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195254910
**[Test build #52916 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52916/consoleFull)**
for PR 11654 at commit
[`f416d02`](https://g
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/11618#issuecomment-195254941
@gatorsmile instead of having a special rule for join, we can probably
infer all possible filters based on constraints (... something along the lines
of
https://
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195255007
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195254957
**[Test build #52908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52908/consoleFull)**
for PR 11615 at commit
[`8422f6e`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195255153
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195255010
**[Test build #52917 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52917/consoleFull)**
for PR 11651 at commit
[`a78c25b`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11654#issuecomment-195255004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195255151
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195256795
**[Test build #52907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52907/consoleFull)**
for PR 11649 at commit
[`9cba8a3`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195257438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195257436
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195257957
**[Test build #52918 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52918/consoleFull)**
for PR 11647 at commit
[`cbab017`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195258018
**[Test build #52917 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52917/consoleFull)**
for PR 11651 at commit
[`a78c25b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195258129
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11617#issuecomment-195258085
Returning a value by modifying an arg in place is exceptional, but I don't
think it's something that can never happen. This is a case where it should, and
it's done and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195258130
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195264239
I think that's fine. Is this all we can find in Python examples?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/11651#issuecomment-195265628
@srowen I think so, I have reviewed all python examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10355#discussion_r55806405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -151,7 +151,7 @@ abstract class NumericType extends AtomicType
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/11655
[SPARK-13816][Graphx] Add parameter checks for algorithms in Graphx
JIRA: https://issues.apache.org/jira/browse/SPARK-13816
## What changes were proposed in this pull request?
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11601#discussion_r55807303
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195286682
**[Test build #52919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52919/consoleFull)**
for PR 11655 at commit
[`a6122de`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195295571
**[Test build #52919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52919/consoleFull)**
for PR 11655 at commit
[`a6122de`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195295815
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195295824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11650#issuecomment-195299373
@rxin @zsxwing Would you take a look when you have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195301155
**[Test build #52920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52920/consoleFull)**
for PR 11655 at commit
[`638ef77`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195302187
I was measuring the time to finish the code snippet shown in pr
description. But I think I should only measure the time spent on `val actual =
Optimize.execute(plan)`.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11601#discussion_r55810108
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/11152#discussion_r55810591
--- Diff: docs/monitoring.md ---
@@ -229,10 +229,28 @@ for a running application, at
`http://localhost:4040/api/v1`.
A list of all application
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/11656
[SPARK-13817][BUILD][SQL] Re-enable MiMA and removes object DataFrame
## What changes were proposed in this pull request?
PR #11443 temporarily disabled MiMA check, this PR re-enables it.
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/11152#discussion_r55810810
--- Diff: docs/monitoring.md ---
@@ -273,8 +309,8 @@ for a running application, at
`http://localhost:4040/api/v1`.
Download the event logs for
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195303544
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195303760
**[Test build #52921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52921/consoleFull)**
for PR 11656 at commit
[`b46e876`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195303762
**[Test build #52922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52922/consoleFull)**
for PR 11652 at commit
[`22d85d5`](https://gi
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11601#discussion_r55810884
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195304088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195304148
**[Test build #52920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52920/consoleFull)**
for PR 11655 at commit
[`638ef77`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195304086
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195304080
**[Test build #52921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52921/consoleFull)**
for PR 11656 at commit
[`b46e876`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195304509
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11655#issuecomment-195304513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195306728
**[Test build #52918 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52918/consoleFull)**
for PR 11647 at commit
[`cbab017`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195307309
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11647#issuecomment-195307315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195308217
**[Test build #52922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52922/consoleFull)**
for PR 11652 at commit
[`22d85d5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195308327
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11652#issuecomment-195308328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11650#issuecomment-195308817
@lw-lin it's not worth bothering with a PR for something this trivial.
Consider running a bigger check for misspelling etc if you're going to. This
still costs like an h
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/11301#discussion_r55813906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -60,20 +61,20 @@ object CurrentOrigin {
def res
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-195311336
@kiszk O.K, let's focus on `Expression`s in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-195316072
https://stat.ethz.ch/R-manual/R-devel/library/base/html/Extract.data.frame.html
here for reference
---
If your project is set up for it, you can reply to this email a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195319368
**[Test build #52923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52923/consoleFull)**
for PR 11656 at commit
[`9dae7f8`](https://gi
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-195323234
@nongli , here is another example.
Spark code with two columns
sqlContext.conf.setConfString(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key,
"tru
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11178#issuecomment-195323566
@JoshRosen MiMA check is re-enabled in PR #11656.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195334485
Verified that MiMA check had been triggered and passed successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11650#issuecomment-195335583
Sure, I'll close this for now. Thanks for your time!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user lw-lin closed the pull request at:
https://github.com/apache/spark/pull/11650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195342004
LGTM. (By the way Bjorn fields a lot of support issues for Spark and this
is apparently a frequent source of questions/confusion. Great if a simple
message change can pr
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/11657
[SPARK-13823] [CORE] [STREAMING] [SQL] Always specify Charset in String <->
byte[] conversions (and remaining Coverity items)
## What changes were proposed in this pull request?
- Fixes cal
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r55822634
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -932,6 +933,33 @@ object PushPredicateThroughGenerat
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r55822686
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -268,7 +268,14 @@ package object dsl {
Aggregate
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11657#issuecomment-195346081
**[Test build #52924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52924/consoleFull)**
for PR 11657 at commit
[`1deecd8`](https://gi
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r55822929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -932,6 +933,33 @@ object PushPredicateThroughGenerat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11657#issuecomment-195347967
**[Test build #52925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52925/consoleFull)**
for PR 11657 at commit
[`8e2865e`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195361013
**[Test build #52923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52923/consoleFull)**
for PR 11656 at commit
[`9dae7f8`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195361432
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11656#issuecomment-195361433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55830076
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/11512#issuecomment-195370827
Yes its only if they explicitly System.exit. Or someone puts a System.exit
back into Spark but that shouldn't happen except on failure.
ok @jerryshao can yo
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/11500#issuecomment-195371687
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 606 matches
Mail list logo
