Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20135#discussion_r159234455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -271,33 +271,45 @@ case class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20134
In spite of reasonability, we cannot touch stable interfaces until
spark-3.0.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20046
**[Test build #85599 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85599/testReport)**
for PR 20046 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20043
Sure. No problem.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85598/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20134
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20134
**[Test build #85598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85598/testReport)**
for PR 20134 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20134
**[Test build #85598 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85598/testReport)**
for PR 20134 at commit
Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r159227953
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -79,6 +79,7 @@ private[spark] abstract class Task[T](
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20135#discussion_r159227959
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -58,7 +58,7 @@ case class Concat(children:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20135
**[Test build #85597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85597/testReport)**
for PR 20135 at commit
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20135
[SPARK-22937][SQL] SQL elt output binary for binary inputs
## What changes were proposed in this pull request?
This pr modified `elt` to output binary for binary inputs.
`elt` in the current
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159227467
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -87,19 +79,7 @@ public void remove() {
}
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20043
Sorry I think we can't make this into Spark 2.3. Recently I'm busy with
some data source v2 features that are promised for 2.3, I will come back to
this after rc1.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20043#discussion_r159227015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,7 +56,36 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159226718
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159226605
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20043
@cloud-fan Can you take a look again? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20134
**[Test build #85596 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85596/testReport)**
for PR 20134 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85596/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20134
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159224739
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159224131
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20134
**[Test build #85596 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85596/testReport)**
for PR 20134 at commit
GitHub user vinodkc opened a pull request:
https://github.com/apache/spark/pull/20134
[SPARK-22613][SQL] Make UNCACHE TABLE behaviour consistent with CACHE TABLE
## What changes were proposed in this pull request?
Added an option LAZY for UNCACHE TABLE.
Eg: UNCACHE LAZY
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159222649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -139,15 +146,25 @@ class OrcFileFormat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159222343
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -110,4 +107,22 @@ object OrcUtils extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159221957
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159221758
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159221380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159221247
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159220833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159220742
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159220570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,408 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20019
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20019
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85592/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20019
**[Test build #85592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85592/testReport)**
for PR 20019 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r159220027
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user fjh100456 commented on the issue:
https://github.com/apache/spark/pull/20076
@gatorsmile
I have added two test cases. Please review them. Thank you very much.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85595/testReport)**
for PR 20076 at commit
Github user fjh100456 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20076#discussion_r159218648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -364,7 +366,9 @@ object SQLConf {
Github user fjh100456 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20076#discussion_r159218522
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CompressionCodecPrecedenceSuite.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85594/testReport)**
for PR 20076 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20116
**[Test build #85593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85593/testReport)**
for PR 20116 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18714
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18714
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85590/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18714
**[Test build #85590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85590/testReport)**
for PR 18714 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20116
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20043
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85591/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20043
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20043
**[Test build #85591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85591/testReport)**
for PR 20043 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20116
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20116
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85589/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20116
**[Test build #85589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85589/testReport)**
for PR 20116 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20019
**[Test build #85592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85592/testReport)**
for PR 20019 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20022
@gatorsmile @cloud-fan @jiangxb1987 Thanks for the help!
---
-
To unsubscribe, e-mail:
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r159196842
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20019#discussion_r159196803
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -263,21 +263,60 @@ class
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Ping @srowen can you help review this?Thanks too much
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159192570
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala
---
@@ -45,7 +45,7 @@ object QuantileDiscretizerExample
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20043
**[Test build #85591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85591/testReport)**
for PR 20043 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20043
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18714
**[Test build #85590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85590/testReport)**
for PR 18714 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20116
**[Test build #85589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85589/testReport)**
for PR 20116 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20116
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20043
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20116
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20116
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85587/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20043
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85588/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20116
**[Test build #85587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85587/testReport)**
for PR 20116 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20043
**[Test build #85588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85588/testReport)**
for PR 20043 at commit
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r159183234
--- Diff: docs/sql-programming-guide.md ---
@@ -1339,6 +1339,13 @@ the following case-insensitive options:
This is a JDBC writer related
201 - 272 of 272 matches
Mail list logo
