[GitHub] spark issue #22433: [SPARK-25442][SQL][K8S] Support STS to run in k8s deploy...

2018-09-15 Thread suryag10
Github user suryag10 commented on the issue: https://github.com/apache/spark/pull/22433 > Does it fail in k8s or does spark k8s code error out ? > If former, why not fix “name” handling in k8s to replace unsupported characters ? Following is the error seen without the

[GitHub] spark issue #22433: [SPARK-25442][SQL][K8S] Support STS to run in k8s deploy...

2018-09-15 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/22433 Does it fail in k8s or does spark k8s code error out ? If former, why not fix “name” handling in k8s to replace unsupported characters ? --- ---

[GitHub] spark pull request #22343: [SPARK-25391][SQL] Make behaviors consistent when...

2018-09-15 Thread seancxmao
Github user seancxmao closed the pull request at: https://github.com/apache/spark/pull/22343 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22343: [SPARK-25391][SQL] Make behaviors consistent when conver...

2018-09-15 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22343 Sure, close this PR. Thank you all for your time and insights. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread suryag10
Github user suryag10 commented on the issue: https://github.com/apache/spark/pull/22433 > Thank you for your first contribution, @suryag10 . > > * Could you file a SPARK JIRA issue since this is a code change? Sure. > * Could you update the PR title like the other PRs?

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22433 Thank you for your first contribution, @suryag10 . - Could you file a SPARK JIRA issue since this is a code change? - Could you update the PR title like the other PRs? e.g. `[SPARK-XXX]

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22433 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3135/ --- --

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3135/

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22433 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky Ext...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22432#discussion_r217902367 --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala --- @@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSu

[GitHub] spark pull request #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky Ext...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22432#discussion_r217902327 --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala --- @@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSu

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22433 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3135/ ---

[GitHub] spark pull request #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky Ext...

2018-09-15 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/22432#discussion_r217902092 --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala --- @@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSuite ext

[GitHub] spark issue #21515: [SPARK-24372][build] Add scripts to help with preparing ...

2018-09-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21515 Problem solved. This script assumes the current user can run docker command without `sudo`, while it may not be true. But we can't run this script with root user as we can't add a root user in the

[GitHub] spark issue #22343: [SPARK-25391][SQL] Make behaviors consistent when conver...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22343 Could you close this PR and JIRA, @seancxmao ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addit

[GitHub] spark issue #22060: [DO NOT MERGE][TEST ONLY] Add once-policy rule check

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22060 Gentle ping, @maryannxue . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21517 Gentle ping, @ssuchter . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20405: [SPARK-23229][SQL] Dataset.hint should use planWithBarri...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20405 Gentle ping, @jaceklaskowski . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18304: [SPARK-21098] Set lineseparator csv multiline and csv wr...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18304 Gentle ping. If the issue is resolved, please close this PR, @cse68197 . --- - To unsubscribe, e-mail: reviews-unsubscr...@

[GitHub] spark pull request #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky Ext...

2018-09-15 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/22432#discussion_r217901988 --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala --- @@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSuite ext

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22433 **[Test build #96105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96105/testReport)** for PR 22433 at commit [`3a7fa57`](https://github.com/apache/spark/commit/3a

[GitHub] spark pull request #21515: [SPARK-24372][build] Add scripts to help with pre...

2018-09-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21515#discussion_r217901993 --- Diff: dev/create-release/do-release-docker.sh --- @@ -0,0 +1,143 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Founda

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22433 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21515: [SPARK-24372][build] Add scripts to help with pre...

2018-09-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21515#discussion_r217901953 --- Diff: dev/create-release/do-release-docker.sh --- @@ -0,0 +1,143 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Founda

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22433 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22433: Support STS to run in k8s deployment modes with spark de...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22433 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22433: Support STS to run in k8s cluster mode

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22433 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22433: Support STS to run in k8s cluster mode

2018-09-15 Thread suryag10
GitHub user suryag10 opened a pull request: https://github.com/apache/spark/pull/22433 Support STS to run in k8s cluster mode ## What changes were proposed in this pull request? Code is enhanced to allow the STS run in kubernetes deployment with spark deploy mode of cluster

[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs

2018-09-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22393 yes please - please double the doc created looks correct - there is no automatic test for that --- - To unsubscribe, e-mail:

[GitHub] spark issue #21515: [SPARK-24372][build] Add scripts to help with preparing ...

2018-09-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21515 UID already exists? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96101/ Test PASSed. ---

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96101/testReport)** for PR 22355 at commit [`b1c6e86`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation test c...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22418 Also, cc @dbtsai . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark pull request #22431: [SPARK-24418][FOLLOWUP][DOC] Update docs to show ...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22431 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r217901635 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1803,6 +1803,10 @@ test_that("string operators", { collect(select(df4, split_string(df4$

[GitHub] spark issue #22431: [SPARK-24418][FOLLOWUP][DOC] Update docs to show Scala 2...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22431 Thank you so much, @dbtsai ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r217901558 --- Diff: R/pkg/NAMESPACE --- @@ -275,6 +275,7 @@ exportMethods("%<=>%", "format_number", "format_string",

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r217901588 --- Diff: R/pkg/R/functions.R --- @@ -2202,6 +2208,24 @@ setMethod("from_json", signature(x = "Column", schema = "characterOrstructType")

[GitHub] spark issue #22431: [SPARK-24418][FOLLOWUP][DOC] Update docs to show Scala 2...

2018-09-15 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22431 Thanks! Merged into both branch 2.4 and master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs

2018-09-15 Thread MichaelChirico
Github user MichaelChirico commented on the issue: https://github.com/apache/spark/pull/22393 @felixcheung is that to me? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #21515: [SPARK-24372][build] Add scripts to help with preparing ...

2018-09-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21515 I hit an issue when using this script to prepare 2.4.0 rc1 ``` useradd: UID 0 is not unique The command '/bin/sh -c useradd -m -s /bin/bash -p spark-rm -u $UID spark-rm' returned a non-

[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs

2018-09-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22393 could you check the doc output manually for registerTempTable and createTable? --- - To unsubscribe, e-mail: reviews-unsubsc

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22430 I got it~ Oh, 2.3.2-rc6 is made. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-15 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r217901185 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -396,7 +396,26 @@ abstract class RDD[T: ClassTag]( * Return a new RDD containing

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-15 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r217901179 --- Diff: core/src/main/scala/org/apache/spark/rdd/MapPartitionsRDD.scala --- @@ -35,16 +35,24 @@ import org.apache.spark.{Partition, TaskContext} * @

[GitHub] spark issue #22426: [SPARK-25436] Bump master branch version to 2.5.0-SNAPSH...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22426 +1, LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96102/ Test PASSed. ---

[GitHub] spark pull request #19538: [SPARK-20393][WEBU UI][BACKPORT-2.0] Strengthen S...

2018-09-15 Thread ambauma
Github user ambauma closed the pull request at: https://github.com/apache/spark/pull/19538 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)** for PR 22355 at commit [`f23705c`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96103/ Test PASSed. ---

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)** for PR 22355 at commit [`76ca370`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22430 This is a pure test only PR. Backporting to 2.3 is optional. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22430 @gatorsmile . We need a backport to 2.3, too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark issue #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAp...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22432 cc @eyalfa @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAp...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22432 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAp...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22432 **[Test build #96104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96104/testReport)** for PR 22432 at commit [`04c3f7b`](https://github.com/apache/spark/commit/04

[GitHub] spark issue #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAp...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3134/

[GitHub] spark pull request #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite da...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22430 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22432: [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky Ext...

2018-09-15 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22432 [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAppendOnlyMapSuite due to timeout ## What changes were proposed in this pull request? SPARK-22713 uses `eventually` with the def

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22430 Thanks! Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark pull request #21515: [SPARK-24372][build] Add scripts to help with pre...

2018-09-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21515#discussion_r217900617 --- Diff: dev/create-release/do-release-docker.sh --- @@ -0,0 +1,143 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Founda

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-15 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r217900574 --- Diff: core/src/main/scala/org/apache/spark/rdd/MapPartitionsRDD.scala --- @@ -35,16 +35,24 @@ import org.apache.spark.{Partition, TaskContext} * @

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-15 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r217900563 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -396,7 +396,26 @@ abstract class RDD[T: ClassTag]( * Return a new RDD containing

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22430 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96100/ Test PASSed. ---

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22430 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22430: [SPARK-25439][TESTS][SQL] Fixes TPCHQuerySuite datatype ...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22430 **[Test build #96100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96100/testReport)** for PR 22430 at commit [`8277ff6`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchm...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22427 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Merged to master/2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Thank you, @maropu ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation test c...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22418 Could you review this test case PR, @gatorsmile , @cloud-fan , @maropu , @HyukjinKwon ? --- - To unsubscribe, e-mail: revi

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22427 Thanks for the explanation! The change looks good to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For ad

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22427 Thank you for review, @maropu . 1. Yes. It's the same. The first one limits the memory usage for write operation. The second one limits the memory usage for compression operation. 2. Ye

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96097/ Test PASSed. ---

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22429 **[Test build #96097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96097/testReport)** for PR 22429 at commit [`9b2a3e6`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #22413: [SPARK-25425][SQL] Extra options should override ...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22413 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22413 Thank you, @MaxGekk . Merged to master/2.4/2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addi

[GitHub] spark issue #22414: [SPARK-25424][SQL] Window duration and slide duration wi...

2018-09-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22414 Please write the current behaviour (you described above) in the PR description? Also, can you format the PR description, too? you don't need the link to the jira. ``` …alues should fail

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r217898513 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -35,6 +35,10 @@ case class TimeWindow( with I

[GitHub] spark issue #22424: [SPARK-25303][STREAMING] For checkpointed DStreams, remo...

2018-09-15 Thread nikunjb
Github user nikunjb commented on the issue: https://github.com/apache/spark/pull/22424 @dongjoon-hyun @tdas Can you please help review this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For a

[GitHub] spark issue #22423: [SPARK-25302][STREAMING] Checkpoint the reducedStream in...

2018-09-15 Thread nikunjb
Github user nikunjb commented on the issue: https://github.com/apache/spark/pull/22423 @dongjoon-hyun @tdas Can you please help review this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For a

[GitHub] spark issue #22427: [SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to ...

2018-09-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22427 Just a question; I'm not familiar with both internal logics though, these parameters (`Memory buffer for writing` and `Compression chunk size`) are internally treated in the same manner? Also, they a

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96098/ Test PASSed. ---

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22413 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22413 **[Test build #96098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96098/testReport)** for PR 22413 at commit [`325b9c4`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)** for PR 22355 at commit [`76ca370`](https://github.com/apache/spark/commit/76

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3133/

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)** for PR 22355 at commit [`f23705c`](https://github.com/apache/spark/commit/f2

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3132/

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22426: [SPARK-25436] Bump master branch version to 2.5.0...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22426 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22417: [SPARK-25426][SQL] Remove the duplicate fallback ...

2018-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22417 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22426: [SPARK-25436] Bump master branch version to 2.5.0-SNAPSH...

2018-09-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22426 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22355 **[Test build #96101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96101/testReport)** for PR 22355 at commit [`b1c6e86`](https://github.com/apache/spark/commit/b1

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3131/

  1   2   3   >