[GitHub] [spark] HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-05 Thread GitBox
HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#issuecomment-508893309 UPDATE: ran tests 2000 times (accumulated) without any failure among 10 machines. Still

[GitHub] [spark] AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508893610 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508893611 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508893610 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508893611 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883149 **[Test build #107294 has

[GitHub] [spark] SparkQA commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
SparkQA commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508893525 **[Test build #107294 has

[GitHub] [spark] HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-05 Thread GitBox
HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#issuecomment-508893309 UPDATE: ran tests 2000 times (accumulated) without any failure among 10 machines. Still

[GitHub] [spark] HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-05 Thread GitBox
HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#issuecomment-508893309 UPDATE: ran tests 2000 times (accumulated) without any failure among 10 machines. Still

[GitHub] [spark] HeartSaVioR commented on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-05 Thread GitBox
HeartSaVioR commented on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#issuecomment-508893309 UPDATE: ran tests 2000 times without any failure among 10 machines. Still running. I've

[GitHub] [spark] viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-05 Thread GitBox
viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#discussion_r300818212 ## File path:

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153.

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153.

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153.

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153.

[GitHub] [spark] HyukjinKwon commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz, this PR targets to fix SPARK-28153. If the suggestions can

[GitHub] [spark] rxin commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
rxin commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#discussion_r300817624 ## File path:

[GitHub] [spark] HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153.

[GitHub] [spark] rxin commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
rxin commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508891265 Perf numbers? This is an automated

[GitHub] [spark] JoshRosen commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
JoshRosen commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508891140 I haven't had a chance to confirm the Janino bugfix yet, but I don't think that's a blocker to merging this version bump: AFAIK we're

[GitHub] [spark] HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

2019-07-05 Thread GitBox
HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users URL: https://github.com/apache/spark/pull/24996#discussion_r300817205 ## File path:

[GitHub] [spark] Deegue commented on issue #25058: [SPARK-21067][SQL] Fix Thrift Server - CTAS fail with Unable to move source

2019-07-05 Thread GitBox
Deegue commented on issue #25058: [SPARK-21067][SQL] Fix Thrift Server - CTAS fail with Unable to move source URL: https://github.com/apache/spark/pull/25058#issuecomment-50032 > This is a known issue (due to the design of Hadoop FileSystem interface), you can set hadoop configuration

[GitHub] [spark] dongjoon-hyun closed pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
dongjoon-hyun closed pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815838 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815838 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815819 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815814 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815763 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815739 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r300815695 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1222 @@ +-- +--

[GitHub] [spark] AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508886914 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508886914 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508886911 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508886911 Merged build finished. Test PASSed. This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508872612 **[Test build #107293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107293/testReport)** for PR 24850

[GitHub] [spark] SparkQA commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
SparkQA commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508886816 **[Test build #107293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107293/testReport)** for PR 24850 at

[GitHub] [spark] dongjoon-hyun closed pull request #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

2019-07-05 Thread GitBox
dongjoon-hyun closed pull request #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948 This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

2019-07-05 Thread GitBox
dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948#issuecomment-508885487 Since this contains a change on `stringExpressions.scala` together, I'll merge

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

2019-07-05 Thread GitBox
dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948#issuecomment-508885487 Since this contains a change on `stringExpressions.scala` together, I'll merge

[GitHub] [spark] dongjoon-hyun commented on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948#issuecomment-508885501 Merged to master. This is

[GitHub] [spark] dongjoon-hyun commented on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948#issuecomment-508885487 Since this contains a change on `stringExpressions.scala` together, I'll merge this.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users URL: https://github.com/apache/spark/pull/24996#discussion_r300814524 ## File path:

[GitHub] [spark] HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-05 Thread GitBox
HeartSaVioR edited a comment on issue #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#issuecomment-508734451 I'm also running the test indefinitely leveraging sbt: ``` #!/bin/bash

[GitHub] [spark] SparkQA commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
SparkQA commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883149 **[Test build #107294 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883026 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883027 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883026 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-508883027 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
HyukjinKwon commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060#issuecomment-508882085 Thanks guys! This is an automated

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#discussion_r300812365 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql ## @@ -0,0 +1,358 @@ +-- +--

[GitHub] [spark] HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

2019-07-05 Thread GitBox
HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users URL: https://github.com/apache/spark/pull/24996#discussion_r300812387 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users URL: https://github.com/apache/spark/pull/24996#discussion_r300811884 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users URL: https://github.com/apache/spark/pull/24996#discussion_r300811884 ## File path:

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun edited a comment on issue #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#issuecomment-508880172 Could you update the PR description with the latest tag `REL_12_BETA2`?

[GitHub] [spark] dongjoon-hyun commented on issue #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#issuecomment-508880172 Could you update the PR description with the lastest tag `REL_12_BETA2`? Also,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#discussion_r300810982 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#discussion_r300810965 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#discussion_r300810723 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#discussion_r300810320 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second' URL: https://github.com/apache/spark/pull/25000#discussion_r300808336 ## File path:

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
dongjoon-hyun edited a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508837495 Gentle ping, @JoshRosen . It would be really great if we can get a confirmation from you.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508873460 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508873461 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508873461 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508873460 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508873300 **[Test build #107292 has

[GitHub] [spark] SparkQA removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508844217 **[Test build #107292 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508873251 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508873251 Merged build finished. Test PASSed. This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508873252 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508873252 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
SparkQA commented on issue #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#issuecomment-508872612 **[Test build #107293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107293/testReport)** for PR 24850 at

[GitHub] [spark] brkyvz commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
brkyvz commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508871773 @HyukjinKwon I can guarantee you, with this solution we may hit a separate

[GitHub] [spark] AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508869874 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508869879 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508869874 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508869879 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838460 **[Test build #107291 has

[GitHub] [spark] SparkQA commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
SparkQA commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508869628 **[Test build #107291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107291/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508868654 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508868654 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508868651 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508868651 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838463 **[Test build #107289 has

[GitHub] [spark] SparkQA commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
SparkQA commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508868418 **[Test build #107289 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508868288 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508868288 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508868284 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508868284 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] SparkQA removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835508 **[Test build #107288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107288/testReport)** for PR

[GitHub] [spark] SparkQA commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
SparkQA commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508868043 **[Test build #107288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107288/testReport)** for PR 24768 at

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300796165 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300795716 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300795593 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300795416 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300795351 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300795247 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860440 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794944 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@

  1   2   3   4   5   6   7   >