[GitHub] [spark] dongjoon-hyun commented on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

dongjoon-hyun commented on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-768628582 Hi, this breaks `branch-3.1` UTs. Please take a look at it. This is an automated message from the Apache G

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31336: [SPARK-34233][SQL] FIX NPE for char padding in binary comparison

dongjoon-hyun edited a comment on pull request #31336: URL: https://github.com/apache/spark/pull/31336#issuecomment-768628582 Hi, this breaks `branch-3.1` UTs. Please take a look at it. ``` DSV2CharVarcharTestSuite.SPARK-34233: char/varchar with null value for partitioned columns `

[GitHub] [spark] HyukjinKwon commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

HyukjinKwon commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-768630015 @razajafri, do you mind clarifying PR description? For exmaple, I thought you meant writing out to files or somewhere by: > Spark should read it as a long but write it

[GitHub] [spark] HyukjinKwon commented on pull request #31299: [SPARK-32866][K8S] Fix docker cross-build

HyukjinKwon commented on pull request #31299: URL: https://github.com/apache/spark/pull/31299#issuecomment-768631758 Thanks @holdenk for the explanation, I am good with this. This is an automated message from the Apache Git S

[GitHub] [spark] HyukjinKwon commented on pull request #31363: [SPARK-34154][YARN] Extend LocalityPlacementStrategySuite's test with a timeout

HyukjinKwon commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768635234 Oh, nice. Thanks @attilapiros! This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] HyukjinKwon commented on pull request #31363: [SPARK-34154][YARN] Extend LocalityPlacementStrategySuite's test with a timeout

HyukjinKwon commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768636101 Let's merge and monitor the builds. The changes look making sense. This is an automated message from the Apa

[GitHub] [spark] HyukjinKwon commented on pull request #31363: [SPARK-34154][YARN] Extend LocalityPlacementStrategySuite's test with a timeout

HyukjinKwon commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768636190 Merged to master, branch-3.1 and branch-3.0. This is an automated message from the Apache Git Service. To re

[GitHub] [spark] SparkQA commented on pull request #30763: [SPARK-31801][API][SHUFFLE] Register map output metadata

SparkQA commented on pull request #30763: URL: https://github.com/apache/spark/pull/30763#issuecomment-768636340 **[Test build #134568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134568/testReport)** for PR 30763 at commit [`b350258`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30763: [SPARK-31801][API][SHUFFLE] Register map output metadata

SparkQA removed a comment on pull request #30763: URL: https://github.com/apache/spark/pull/30763#issuecomment-768564792 **[Test build #134568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134568/testReport)** for PR 30763 at commit [`b350258`](https://gi

[GitHub] [spark] HyukjinKwon closed pull request #31363: [SPARK-34154][YARN] Extend LocalityPlacementStrategySuite's test with a timeout

HyukjinKwon closed pull request #31363: URL: https://github.com/apache/spark/pull/31363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

SparkQA commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768637121 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39153/ ---

[GitHub] [spark] aokolnychyi commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

aokolnychyi commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768642659 Thanks for submitting this follow-up, @HeartSaVioR! I'll take a look tomorrow. Let me also add folks who participated in the review of the original change. cc

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

dongjoon-hyun commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565709706 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -32,21 +32,29 @@ objec

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

dongjoon-hyun commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565709706 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -32,21 +32,29 @@ objec

[GitHub] [spark] viirya commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

viirya commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565712581 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/distributions/distributions.scala ## @@ -39,21 +48,29 @@ private[sql] object Unsp

[GitHub] [spark] AmplabJenkins commented on pull request #30763: [SPARK-31801][API][SHUFFLE] Register map output metadata

AmplabJenkins commented on pull request #30763: URL: https://github.com/apache/spark/pull/30763#issuecomment-768648022 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134568/ -

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

dongjoon-hyun commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565709706 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -32,21 +32,29 @@ objec

[GitHub] [spark] AmplabJenkins commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

AmplabJenkins commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768648024 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39153/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

AmplabJenkins removed a comment on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768648024 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39153/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30763: [SPARK-31801][API][SHUFFLE] Register map output metadata

AmplabJenkins removed a comment on pull request #30763: URL: https://github.com/apache/spark/pull/30763#issuecomment-768648022 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134568/ -

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768649312 **[Test build #134572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134572/testReport)** for PR 30175 at commit [`b494781`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768650065 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134572/ -

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768650053 **[Test build #134572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134572/testReport)** for PR 30175 at commit [`b494781`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768649312 **[Test build #134572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134572/testReport)** for PR 30175 at commit [`b494781`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768650065 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134572/ -

[GitHub] [spark] rdblue commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

rdblue commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565733924 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/ClusteredDistribution.java ## @@ -32,4 +32,13 @@ * Returns clust

[GitHub] [spark] rdblue commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

rdblue commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768668219 Overall, I have no problem adding this. My one reservation is that I would hope that most sources don't explicitly control parallelism and I think adding only this would cause im

[GitHub] [spark] maropu commented on a change in pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

maropu commented on a change in pull request #31368: URL: https://github.com/apache/spark/pull/31368#discussion_r565735036 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -845,17 +845,33 @@ class SessionCatalog( }

[GitHub] [spark] AmplabJenkins commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768670309 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39158/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768670309 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39158/

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768672068 **[Test build #134573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134573/testReport)** for PR 30175 at commit [`2c1e0b6`](https://github.com

[GitHub] [spark] wangyum opened a new pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

wangyum opened a new pull request #31370: URL: https://github.com/apache/spark/pull/31370 ### What changes were proposed in this pull request? This pr correct the documentation of the `concat_ws` function. ### Why are the changes needed? `concat_ws` doesn't need any str

[GitHub] [spark] SparkQA commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

SparkQA commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768683612 **[Test build #134567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134567/testReport)** for PR 31361 at commit [`a759c20`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

SparkQA removed a comment on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768564572 **[Test build #134567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134567/testReport)** for PR 31361 at commit [`a759c20`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768701247 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39159/ -

[GitHub] [spark] allisonwang-db commented on a change in pull request #31293: [SPARK-33601][SQL] Group exception messages in catalyst/parser

allisonwang-db commented on a change in pull request #31293: URL: https://github.com/apache/spark/pull/31293#discussion_r565759055 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

AmplabJenkins commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768703017 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134567/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

AmplabJenkins removed a comment on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768703017 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134567/ -

[GitHub] [spark] allisonwang-db commented on a change in pull request #31293: [SPARK-33601][SQL] Group exception messages in catalyst/parser

allisonwang-db commented on a change in pull request #31293: URL: https://github.com/apache/spark/pull/31293#discussion_r565760892 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache

[GitHub] [spark] HyukjinKwon edited a comment on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

HyukjinKwon edited a comment on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-768630015 @razajafri, do you mind clarifying PR description? For exmaple, I thought you meant writing out to files or somewhere by: > Spark should read it as a long but w

[GitHub] [spark] SparkQA commented on pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

SparkQA commented on pull request #31370: URL: https://github.com/apache/spark/pull/31370#issuecomment-768724348 **[Test build #134574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134574/testReport)** for PR 31370 at commit [`6ee4352`](https://github.com

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565757032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -0,0 +1,305 @@ +/* + * Licensed to the Apach

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565765354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -31,126 +31,28 @@ import org.apache.spark.sql.ca

[GitHub] [spark] SparkQA commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

SparkQA commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768740266 **[Test build #134571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134571/testReport)** for PR 31355 at commit [`5d56dc0`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

SparkQA removed a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768597841 **[Test build #134571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134571/testReport)** for PR 31355 at commit [`5d56dc0`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31369: [SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

SparkQA commented on pull request #31369: URL: https://github.com/apache/spark/pull/31369#issuecomment-768740599 **[Test build #134569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134569/testReport)** for PR 31369 at commit [`d019731`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31369: [SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

SparkQA removed a comment on pull request #31369: URL: https://github.com/apache/spark/pull/31369#issuecomment-768592776 **[Test build #134569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134569/testReport)** for PR 31369 at commit [`d019731`](https://gi

[GitHub] [spark] linhongliu-db commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565768669 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1763,6 +1763,21 @@ class Analyzer(override v

[GitHub] [spark] sunchao opened a new pull request #31371: [SPARK-34271][SQL] Use majorMinorPatchVersion for Hive version parsing

sunchao opened a new pull request #31371: URL: https://github.com/apache/spark/pull/31371 ### What changes were proposed in this pull request? Use `majorMinorPatchVersion` to check major & minor version in `IsolatedClientLoader.hiveVersion`. ### Why are the changes

[GitHub] [spark] linhongliu-db commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565768669 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1763,6 +1763,21 @@ class Analyzer(override v

[GitHub] [spark] linhongliu-db commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565768669 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1763,6 +1763,21 @@ class Analyzer(override v

[GitHub] [spark] maropu commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

maropu commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768744991 The issue happens in branch-3.0 only? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] sunchao commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

sunchao commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565769723 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/OrderedDistribution.java ## @@ -32,4 +32,13 @@ * Returns orderi

[GitHub] [spark] SparkQA commented on pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

SparkQA commented on pull request #31370: URL: https://github.com/apache/spark/pull/31370#issuecomment-768747729 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39160/ -

[GitHub] [spark] maropu commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

maropu commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565773596 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/join.sql ## @@ -743,20 +743,20 @@ select * from a left join b on i = x and i = y and

[GitHub] [spark] sunchao commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

sunchao commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-768750394 Interesting. This seems to overlap with [SPARK-34108](https://issues.apache.org/jira/browse/SPARK-34108) but it appears that it doesn't solve the issue in the JIRA. --

[GitHub] [spark] maropu commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

maropu commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565776437 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1559,6 +1559,14 @@ object SQLConf { .booleanConf

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

AngersZh commented on a change in pull request #31341: URL: https://github.com/apache/spark/pull/31341#discussion_r565776888 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -972,10 +972,9 @@ case class ShowColumnsCommand( *

[GitHub] [spark] linhongliu-db commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

linhongliu-db commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565777014 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1559,6 +1559,14 @@ object SQLConf { .booleanCon

[GitHub] [spark] AmplabJenkins commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

AmplabJenkins commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768753424 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134571/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31369: [SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

AmplabJenkins commented on pull request #31369: URL: https://github.com/apache/spark/pull/31369#issuecomment-768753423 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134569/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

AmplabJenkins removed a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768753424 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134571/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31369: [SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

AmplabJenkins removed a comment on pull request #31369: URL: https://github.com/apache/spark/pull/31369#issuecomment-768753423 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134569/ -

[GitHub] [spark] SparkQA commented on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

SparkQA commented on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768754128 **[Test build #134577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134577/testReport)** for PR 31354 at commit [`de3f395`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

SparkQA commented on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768754138 **[Test build #134578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134578/testReport)** for PR 31341 at commit [`fd4afee`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-768754190 **[Test build #134579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134579/testReport)** for PR 31286 at commit [`d02e32c`](https://github.com

[GitHub] [spark] maropu commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

maropu commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565779860 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1763,6 +1763,21 @@ class Analyzer(override val cata

[GitHub] [spark] maropu commented on a change in pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

maropu commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565780148 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1559,6 +1559,14 @@ object SQLConf { .booleanConf

[GitHub] [spark] maropu commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

maropu commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-768754897 Disallowing the syntax looks fine. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] SparkQA commented on pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

SparkQA commented on pull request #31370: URL: https://github.com/apache/spark/pull/31370#issuecomment-768757290 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39160/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

AmplabJenkins commented on pull request #31370: URL: https://github.com/apache/spark/pull/31370#issuecomment-768757300 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39160/ -

[GitHub] [spark] SparkQA commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

SparkQA commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768757370 **[Test build #134576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134576/testReport)** for PR 31365 at commit [`cc4645e`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31370: [SPARK-34268][SQL][DOCS] Correct the documentation of the concat_ws function

AmplabJenkins removed a comment on pull request #31370: URL: https://github.com/apache/spark/pull/31370#issuecomment-768757300 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39160/

[GitHub] [spark] SparkQA commented on pull request #31371: [SPARK-34271][SQL] Use majorMinorPatchVersion for Hive version parsing

SparkQA commented on pull request #31371: URL: https://github.com/apache/spark/pull/31371#issuecomment-768757650 **[Test build #134575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134575/testReport)** for PR 31371 at commit [`54b6b9c`](https://github.com

[GitHub] [spark] ulysses-you opened a new pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

ulysses-you opened a new pull request #31372: URL: https://github.com/apache/spark/pull/31372 ### What changes were proposed in this pull request? Add `NonSQLExpression` check int `usePrettyExpression `. ### Why are the changes needed? We should respect `NonSQLEx

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565783250 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ## @@ -668,7 +675,7 @@ class SQLContext private[sql](val sparkSession: Spark

[GitHub] [spark] SparkQA commented on pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

SparkQA commented on pull request #31372: URL: https://github.com/apache/spark/pull/31372#issuecomment-768758038 **[Test build #134580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134580/testReport)** for PR 31372 at commit [`deaa535`](https://github.com

[GitHub] [spark] maropu commented on a change in pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

maropu commented on a change in pull request #31372: URL: https://github.com/apache/spark/pull/31372#discussion_r565784546 ## File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out ## @@ -109,7 +109,7 @@ struct -- !query SELECT u

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

HeartSaVioR commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565785171 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/OrderedDistribution.java ## @@ -32,4 +32,13 @@ * Returns or

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565787279 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] maropu closed pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

maropu closed pull request #31148: URL: https://github.com/apache/spark/pull/31148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] ulysses-you commented on a change in pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

ulysses-you commented on a change in pull request #31372: URL: https://github.com/apache/spark/pull/31372#discussion_r565787380 ## File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out ## @@ -109,7 +109,7 @@ struct -- !query SEL

[GitHub] [spark] xuanyuanking commented on a change in pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

xuanyuanking commented on a change in pull request #30175: URL: https://github.com/apache/spark/pull/30175#discussion_r565787293 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSourceSuite.scala ## @@ -19,15 +19,24 @@ package o

[GitHub] [spark] maropu commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

maropu commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768764150 Thanks! Merged to master/branch-3.1! Could you backport it into branch-3.0? @cristichircu This is an automated

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768764277 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39159/ ---

[GitHub] [spark] beliefer commented on pull request #31293: [SPARK-33601][SQL] Group exception messages in catalyst/parser

beliefer commented on pull request #31293: URL: https://github.com/apache/spark/pull/31293#issuecomment-768764351 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] xuanyuanking commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

xuanyuanking commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768764326 @warrenzhu25 Thanks for the fix! It would be great to write down the RCA about why the job hanging in the description. (Thanks for pinging me @viirya) -

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

HeartSaVioR commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565789213 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/ClusteredDistribution.java ## @@ -32,4 +32,13 @@ * Returns

[GitHub] [spark] cloud-fan commented on a change in pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

cloud-fan commented on a change in pull request #31368: URL: https://github.com/apache/spark/pull/31368#discussion_r565789469 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -845,17 +845,33 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on pull request #31356: [SPARK-34257][SQL] Improve performance for last_value over unbounded window frame

cloud-fan commented on pull request #31356: URL: https://github.com/apache/spark/pull/31356#issuecomment-768766015 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-768769810 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39165/ -

[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

SparkQA commented on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768770081 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39164/ -

[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

SparkQA commented on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768771625 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39164/ ---

[GitHub] [spark] SparkQA commented on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

SparkQA commented on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768772022 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39163/ -

[GitHub] [spark] SparkQA commented on pull request #31371: [SPARK-34271][SQL] Use majorMinorPatchVersion for Hive version parsing

SparkQA commented on pull request #31371: URL: https://github.com/apache/spark/pull/31371#issuecomment-768772575 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39161/ -

[GitHub] [spark] AmplabJenkins commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768774637 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39159/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

AmplabJenkins commented on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768774636 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39164/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

AmplabJenkins removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768774637 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39159/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

AmplabJenkins removed a comment on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768774636 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39164/

[GitHub] [spark] SparkQA commented on pull request #31356: [SPARK-34257][SQL] Improve performance for last_value over unbounded window frame

SparkQA commented on pull request #31356: URL: https://github.com/apache/spark/pull/31356#issuecomment-768775784 **[Test build #134581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134581/testReport)** for PR 31356 at commit [`2da29d4`](https://github.com

<    1   2   3   4   5   6   7   8   >