[GitHub] [spark] cloud-fan commented on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
cloud-fan commented on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839804392 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] gengliangwang commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839801210 @cloud-fan @maropu Sorry for the delay. This one is ready for review now. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] srowen commented on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-12 Thread GitBox
srowen commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-839796652 Merged to master. Thanks again @luhenry for hanging in there - just wanted to be pretty sure about the change. It's a good one. @zhengruifeng this change is in. -- This i

[GitHub] [spark] srowen closed pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-12 Thread GitBox
srowen closed pull request #32415: URL: https://github.com/apache/spark/pull/32415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #32455: [SPARK-35253][SQL][BUILD] Bump up the janino version to v3.1.4

2021-05-12 Thread GitBox
srowen commented on pull request #32455: URL: https://github.com/apache/spark/pull/32455#issuecomment-839795206 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] srowen closed pull request #32455: [SPARK-35253][SQL][BUILD] Bump up the janino version to v3.1.4

2021-05-12 Thread GitBox
srowen closed pull request #32455: URL: https://github.com/apache/spark/pull/32455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #32485: [SPARK-35357][GRAPHX] Allow to turn off the normalization applied by static PageRank utilities

2021-05-12 Thread GitBox
srowen commented on pull request #32485: URL: https://github.com/apache/spark/pull/32485#issuecomment-839794229 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] srowen closed pull request #32485: [SPARK-35357][GRAPHX] Allow to turn off the normalization applied by static PageRank utilities

2021-05-12 Thread GitBox
srowen closed pull request #32485: URL: https://github.com/apache/spark/pull/32485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-05-12 Thread GitBox
srowen commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-839792934 Unless @wangyum has comments, I can merge to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [spark] cloud-fan commented on a change in pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
cloud-fan commented on a change in pull request #32520: URL: https://github.com/apache/spark/pull/32520#discussion_r631062829 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSc

[GitHub] [spark] SparkQA removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839620790 **[Test build #138448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138448/testReport)** for PR 32452 at commit [`ff94039`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839789596 **[Test build #138448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138448/testReport)** for PR 32452 at commit [`ff94039`](https://github.co

[GitHub] [spark] tgravescs commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
tgravescs commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839785104 changes look fine, assume it was manually tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [spark] cloud-fan closed pull request #32499: [SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions

2021-05-12 Thread GitBox
cloud-fan closed pull request #32499: URL: https://github.com/apache/spark/pull/32499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [spark] cloud-fan commented on pull request #32499: [SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions

2021-05-12 Thread GitBox
cloud-fan commented on pull request #32499: URL: https://github.com/apache/spark/pull/32499#issuecomment-839785448 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839780679 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138451/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839780679 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138451/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839693253 **[Test build #138451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138451/testReport)** for PR 32504 at commit [`a26b180`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839779483 **[Test build #138451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138451/testReport)** for PR 32504 at commit [`a26b180`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42974/

[GitHub] [spark] AmplabJenkins commented on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42974/ -- T

[GitHub] [spark] SparkQA commented on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839768172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138441/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839768168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138445/ -

[GitHub] [spark] SparkQA commented on pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
SparkQA commented on pull request #32520: URL: https://github.com/apache/spark/pull/32520#issuecomment-839768710 **[Test build #138454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138454/testReport)** for PR 32520 at commit [`9fe4b42`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839768169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138447/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839768168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138445/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839768169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138447/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839768172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138441/ -- This

[GitHub] [spark] maropu commented on a change in pull request #32454: [SPARK-35327][SQL][TESTS] Filters out the TPC-DS queries that can cause flaky test results

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32454: URL: https://github.com/apache/spark/pull/32454#discussion_r631021871 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -24,7 +24,7 @@ import org.apache.spark.sql.test.SharedSparkSession trait

[GitHub] [spark] maropu opened a new pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
maropu opened a new pull request #32520: URL: https://github.com/apache/spark/pull/32520 ### What changes were proposed in this pull request? This PR proposes to skip the "q6", "q34", "q64", "q74", "q75", "q78" queries in the TPCDS-related tests because the TPCDS v2.7 queries

[GitHub] [spark] SparkQA commented on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
SparkQA commented on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839752937 **[Test build #138447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138447/testReport)** for PR 32496 at commit [`f86fba6`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839579496 **[Test build #138447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138447/testReport)** for PR 32496 at commit [`f86fba6`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839573760 **[Test build #138445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138445/testReport)** for PR 32498 at commit [`89457c8`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839751330 **[Test build #138445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138445/testReport)** for PR 32498 at commit [`89457c8`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839535644 **[Test build #138441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138441/testReport)** for PR 32478 at commit [`170aff2`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839742044 **[Test build #138441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138441/testReport)** for PR 32478 at commit [`170aff2`](https://github.co

[GitHub] [spark] gengliangwang closed pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
gengliangwang closed pull request #32439: URL: https://github.com/apache/spark/pull/32439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] gengliangwang commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839739715 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839733785 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138439/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839733785 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138439/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839530771 **[Test build #138439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138439/testReport)** for PR 32439 at commit [`5027ebc`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839732396 **[Test build #138453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138453/testReport)** for PR 32292 at commit [`9b671f1`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
SparkQA commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839732336 **[Test build #138439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138439/testReport)** for PR 32439 at commit [`5027ebc`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839732034 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138440/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839732034 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138440/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839731059 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42973/

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839731022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839731059 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42973/ -- T

[GitHub] [spark] SparkQA removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839533096 **[Test build #138440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138440/testReport)** for PR 32452 at commit [`ff94039`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839730595 **[Test build #138440 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138440/testReport)** for PR 32452 at commit [`ff94039`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839729901 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138436/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839729901 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138436/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839530616 **[Test build #138436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138436/testReport)** for PR 32476 at commit [`429edcc`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
SparkQA commented on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839728640 **[Test build #138436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138436/testReport)** for PR 32476 at commit [`429edcc`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839726168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138433/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839726080 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138442/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32457: [SPARK-35329][SQL] Split generated switch code into pieces in ExpandExec

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32457: URL: https://github.com/apache/spark/pull/32457#issuecomment-839726166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138437/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839726164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138438/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839726165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42971/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839726167 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42972/

[GitHub] [spark] AmplabJenkins commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839726167 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42972/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839726164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138438/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839726168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138433/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32457: [SPARK-35329][SQL] Split generated switch code into pieces in ExpandExec

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32457: URL: https://github.com/apache/spark/pull/32457#issuecomment-839726166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138437/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839726165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42971/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839726080 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138442/ -- This

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839725538 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42971/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839540813 **[Test build #138442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138442/testReport)** for PR 32503 at commit [`d35f9a6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
SparkQA commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839724965 **[Test build #138442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138442/testReport)** for PR 32503 at commit [`d35f9a6`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839724796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] ulysses-you commented on pull request #32510: [SPARK-35376][CORE] Fallback config should override defaultValue

2021-05-12 Thread GitBox
ulysses-you commented on pull request #32510: URL: https://github.com/apache/spark/pull/32510#issuecomment-839724551 @maropu I guess it affects user. * the incorrect default value would mislead user. * seems there is no other easy way to get the default value of config in code ?

[GitHub] [spark] ulysses-you commented on a change in pull request #32510: [SPARK-35376][CORE] Fallback config should override defaultValue

2021-05-12 Thread GitBox
ulysses-you commented on a change in pull request #32510: URL: https://github.com/apache/spark/pull/32510#discussion_r630987216 ## File path: core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ## @@ -264,7 +264,9 @@ private[spark] class FallbackConfigEntry[

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839721455 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42971/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839530467 **[Test build #138433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138433/testReport)** for PR 32519 at commit [`1bcc512`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
SparkQA commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839720117 **[Test build #138433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138433/testReport)** for PR 32519 at commit [`1bcc512`](https://github.co

[GitHub] [spark] maropu commented on pull request #32510: [SPARK-35376][CORE] Fallback config should override defaultValue

2021-05-12 Thread GitBox
maropu commented on pull request #32510: URL: https://github.com/apache/spark/pull/32510#issuecomment-839713638 > A negative case is SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.defaultValue would return None. It could mislead user. The default value is related to a user? Since `SQLConf`

[GitHub] [spark] SparkQA removed a comment on pull request #32457: [SPARK-35329][SQL] Split generated switch code into pieces in ExpandExec

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32457: URL: https://github.com/apache/spark/pull/32457#issuecomment-839530666 **[Test build #138437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138437/testReport)** for PR 32457 at commit [`9e74ca6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32457: [SPARK-35329][SQL] Split generated switch code into pieces in ExpandExec

2021-05-12 Thread GitBox
SparkQA commented on pull request #32457: URL: https://github.com/apache/spark/pull/32457#issuecomment-839709787 **[Test build #138437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138437/testReport)** for PR 32457 at commit [`9e74ca6`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839530690 **[Test build #138438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138438/testReport)** for PR 32452 at commit [`b455c8d`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839703435 **[Test build #138438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138438/testReport)** for PR 32452 at commit [`b455c8d`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839699943 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42970/

[GitHub] [spark] SparkQA commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
SparkQA commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839699921 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42970/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839699943 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42970/ -- T

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839697574 **[Test build #138452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138452/testReport)** for PR 32515 at commit [`459eab0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839697159 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138444/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839697159 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138444/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839573694 **[Test build #138444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138444/testReport)** for PR 32504 at commit [`5f480e7`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839695953 **[Test build #138444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138444/testReport)** for PR 32504 at commit [`5f480e7`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
SparkQA commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839695924 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42970/ -- This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32510: [SPARK-35376][CORE] Fallback config should override defaultValue

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32510: URL: https://github.com/apache/spark/pull/32510#discussion_r630953291 ## File path: core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ## @@ -264,7 +264,9 @@ private[spark] class FallbackConfigEntry[

[GitHub] [spark] SparkQA commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839693253 **[Test build #138451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138451/testReport)** for PR 32504 at commit [`a26b180`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32510: [SPARK-35376][CORE] Fallback config should override defaultValue

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32510: URL: https://github.com/apache/spark/pull/32510#discussion_r630952745 ## File path: core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ## @@ -264,7 +264,9 @@ private[spark] class FallbackConfigEntry[

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839693179 **[Test build #138450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138450/testReport)** for PR 32515 at commit [`1aece6a`](https://github.com

[GitHub] [spark] yaooqinn commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r630951749 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] HyukjinKwon closed pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
HyukjinKwon closed pull request #32452: URL: https://github.com/apache/spark/pull/32452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] HyukjinKwon commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839686737 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32504: URL: https://github.com/apache/spark/pull/32504#discussion_r630945116 ## File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ## @@ -253,6 +253,9 @@ private[deploy] class SparkSubmitArgument

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32504: URL: https://github.com/apache/spark/pull/32504#discussion_r630944970 ## File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ## @@ -253,6 +253,9 @@ private[deploy] class SparkSubmitArgument

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32504: URL: https://github.com/apache/spark/pull/32504#discussion_r630944808 ## File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ## @@ -253,6 +253,9 @@ private[deploy] class SparkSubmitArgument

<    1   2   3   4   5   6   7   8   >