[GitHub] [spark] cloud-fan commented on a change in pull request #34470: [SPARK-37199][SQL] Add deterministic field to QueryPlan

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34470: URL: https://github.com/apache/spark/pull/34470#discussion_r741636791 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ## @@ -1931,18 +1931,29 @@ class SubquerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741633772 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -284,4 +288,141 @@ private[v2]

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741633433 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -284,4 +288,141 @@ private[v2]

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741633192 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -284,4 +288,141 @@ private[v2]

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34465: [MINOR] Document JDBC aggregate push down is for DSV2 only

2021-11-02 Thread GitBox
HyukjinKwon commented on a change in pull request #34465: URL: https://github.com/apache/spark/pull/34465#discussion_r741633327 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ## @@ -189,6 +189,7 @@ class JDBCOptions(

[GitHub] [spark] Ngone51 commented on pull request #34428: [SPARK-37151][CORE] Avoid ExecutorStateChanged sync attempt retry immediately when failed due to bad connection

2021-11-02 Thread GitBox
Ngone51 commented on pull request #34428: URL: https://github.com/apache/spark/pull/34428#issuecomment-958670018 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741633192 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -284,4 +288,141 @@ private[v2]

[GitHub] [spark] MaxGekk closed pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
MaxGekk closed pull request #34472: URL: https://github.com/apache/spark/pull/34472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] MaxGekk commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
MaxGekk commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958669174 +1, LGTM. Merging to master. Thank you, @gengliangwang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34470: [SPARK-37199][SQL] Add deterministic field to QueryPlan

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34470: URL: https://github.com/apache/spark/pull/34470#issuecomment-958024984 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA commented on pull request #34470: [SPARK-37199][SQL] Add deterministic field to QueryPlan

2021-11-02 Thread GitBox
SparkQA commented on pull request #34470: URL: https://github.com/apache/spark/pull/34470#issuecomment-958667432 **[Test build #144871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144871/testReport)** for PR 34470 at commit

[GitHub] [spark] SparkQA commented on pull request #34473: [SPARK-37202][SQL] Temp view should collect temp functions registered with catalog API

2021-11-02 Thread GitBox
SparkQA commented on pull request #34473: URL: https://github.com/apache/spark/pull/34473#issuecomment-958667430 **[Test build #144870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144870/testReport)** for PR 34473 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958667165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49338/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958667166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49339/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958667164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49337/

[GitHub] [spark] AmplabJenkins commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958667165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49338/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958667164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49337/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958667166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49339/ --

[GitHub] [spark] HyukjinKwon commented on pull request #34470: [SPARK-37199][SQL] Add deterministic field to QueryPlan

2021-11-02 Thread GitBox
HyukjinKwon commented on pull request #34470: URL: https://github.com/apache/spark/pull/34470#issuecomment-958664605 add to whitelist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
SparkQA commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958664517 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49337/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958662198 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49339/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958660090 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49338/ -- This is an automated message from the

[GitHub] [spark] linhongliu-db opened a new pull request #34473: [SPARK-37202][SQL] Temp view should collect temp functions registered with catalog API

2021-11-02 Thread GitBox
linhongliu-db opened a new pull request #34473: URL: https://github.com/apache/spark/pull/34473 ### What changes were proposed in this pull request? Add a new function wrapper called `RegisteredSimpleFunction`, so that we can identify the functions among all the expressions. Because

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741619550 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -370,6 +371,10 @@ abstract class JdbcDialect extends

[GitHub] [spark] cloud-fan commented on a change in pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r741619164 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -225,13 +226,33 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958649709 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144867/

[GitHub] [spark] AmplabJenkins commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958649709 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144867/ -- This

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958648786 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49339/ -- This is an automated message from the Apache

[GitHub] [spark] c21 commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
c21 commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-958647134 Thank you @cloud-fan for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958647104 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49338/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
SparkQA commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958646960 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49337/ -- This is an automated message from the Apache

[GitHub] [spark] c21 commented on a change in pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
c21 commented on a change in pull request #3: URL: https://github.com/apache/spark/pull/3#discussion_r741612543 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -332,6 +327,266 @@ case class

[GitHub] [spark] SparkQA removed a comment on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958632465 **[Test build #144867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144867/testReport)** for PR 34472 at commit

[GitHub] [spark] SparkQA commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
SparkQA commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958640099 **[Test build #144867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144867/testReport)** for PR 34472 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958633142 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144863/

[GitHub] [spark] AmplabJenkins commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958633142 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144863/ -- This

[GitHub] [spark] sadikovi commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
sadikovi commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958632672 Thank you . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA removed a comment on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958302374 **[Test build #144863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144863/testReport)** for PR 34451 at commit

[GitHub] [spark] SparkQA commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
SparkQA commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958632529 **[Test build #144868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144868/testReport)** for PR 34459 at commit

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958632537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] SparkQA commented on pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
SparkQA commented on pull request #34472: URL: https://github.com/apache/spark/pull/34472#issuecomment-958632465 **[Test build #144867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144867/testReport)** for PR 34472 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958632042 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144862/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958632045 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49336/

[GitHub] [spark] AmplabJenkins commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958632042 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144862/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958632045 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49336/ --

[GitHub] [spark] SparkQA removed a comment on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958302214 **[Test build #144862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144862/testReport)** for PR 34462 at commit

[GitHub] [spark] SparkQA commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
SparkQA commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958631062 **[Test build #144862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144862/testReport)** for PR 34462 at commit

[GitHub] [spark] gengliangwang commented on a change in pull request #22037: [SPARK-24774][SQL] Avro: Support logical decimal type

2021-11-02 Thread GitBox
gengliangwang commented on a change in pull request #22037: URL: https://github.com/apache/spark/pull/22037#discussion_r741597255 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala ## @@ -18,19 +18,28 @@ package

[GitHub] [spark] gengliangwang opened a new pull request #34472: [SPARK-24774][SQL][FOLLOWUP] Remove unused code in SchemaConverters.scala

2021-11-02 Thread GitBox
gengliangwang opened a new pull request #34472: URL: https://github.com/apache/spark/pull/34472 ### What changes were proposed in this pull request? As @MaxGekk pointed out in https://github.com/apache/spark/pull/22037/files#r741373793, there is some unused code in

[GitHub] [spark] cloud-fan commented on pull request #34459: [SPARK-37179][SQL] ANSI mode: Add a config to allow casting between Datetime and Numeric

2021-11-02 Thread GitBox
cloud-fan commented on pull request #34459: URL: https://github.com/apache/spark/pull/34459#issuecomment-958628880 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan closed pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
cloud-fan closed pull request #34462: URL: https://github.com/apache/spark/pull/34462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
cloud-fan commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958628079 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan closed pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
cloud-fan closed pull request #3: URL: https://github.com/apache/spark/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
cloud-fan commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-958626996 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan commented on a change in pull request #34444: [SPARK-32567][SQL] Add code-gen for full outer shuffled hash join

2021-11-02 Thread GitBox
cloud-fan commented on a change in pull request #3: URL: https://github.com/apache/spark/pull/3#discussion_r741594274 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -332,6 +327,266 @@ case class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34374: [SPARK-37104][PYTHON] Make RDD and DStream covariant

2021-11-02 Thread GitBox
HyukjinKwon commented on a change in pull request #34374: URL: https://github.com/apache/spark/pull/34374#discussion_r741592512 ## File path: python/pyspark/rdd.pyi ## @@ -60,6 +60,7 @@ from pyspark.sql._typing import RowLike from py4j.java_gateway import JavaObject # type:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

2021-11-02 Thread GitBox
AngersZh commented on a change in pull request #34308: URL: https://github.com/apache/spark/pull/34308#discussion_r741591741 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -593,6 +593,16 @@ object

[GitHub] [spark] srowen commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

2021-11-02 Thread GitBox
srowen commented on a change in pull request #34308: URL: https://github.com/apache/spark/pull/34308#discussion_r741588072 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -593,6 +593,16 @@ object QueryExecutionErrors {

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958613957 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49336/ -- This is an automated message from the

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

2021-11-02 Thread GitBox
AngersZh commented on a change in pull request #34308: URL: https://github.com/apache/spark/pull/34308#discussion_r741585626 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -593,6 +593,16 @@ object

[GitHub] [spark] mridulm commented on a change in pull request #34461: [SPARK-37023][CORE] Avoid fetching merge status when shuffleMergeEnabled is false for a shuffleDependency during retry

2021-11-02 Thread GitBox
mridulm commented on a change in pull request #34461: URL: https://github.com/apache/spark/pull/34461#discussion_r741582590 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -1174,14 +1182,43 @@ private[spark] class MapOutputTrackerWorker(conf:

[GitHub] [spark] srowen commented on a change in pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

2021-11-02 Thread GitBox
srowen commented on a change in pull request #34308: URL: https://github.com/apache/spark/pull/34308#discussion_r741582753 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ## @@ -593,6 +593,16 @@ object QueryExecutionErrors {

[GitHub] [spark] AngersZhuuuu commented on pull request #34308: [SPARK-37035][SQL] Improve error message when use parquet vectorize reader

2021-11-02 Thread GitBox
AngersZh commented on pull request #34308: URL: https://github.com/apache/spark/pull/34308#issuecomment-958606977 also ping @srowen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49335/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958606731 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144864/

[GitHub] [spark] AmplabJenkins commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-958606730 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49335/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958606731 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144864/ -- This

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958603035 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49336/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958446671 **[Test build #144864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144864/testReport)** for PR 34471 at commit

[GitHub] [spark] SparkQA commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958599302 **[Test build #144864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144864/testReport)** for PR 34471 at commit

[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-958596464 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49335/ -- This is an automated message from the

[GitHub] [spark] wangyum commented on a change in pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
wangyum commented on a change in pull request #33522: URL: https://github.com/apache/spark/pull/33522#discussion_r741566717 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PullOutJoinCondition.scala ## @@ -0,0 +1,76 @@ +/* + * Licensed to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958589512 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49334/

[GitHub] [spark] SparkQA commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958589503 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49334/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958589512 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49334/ --

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958589188 **[Test build #144866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144866/testReport)** for PR 34451 at commit

[GitHub] [spark] wangyum commented on a change in pull request #33522: [SPARK-36290][SQL] Pull out join condition

2021-11-02 Thread GitBox
wangyum commented on a change in pull request #33522: URL: https://github.com/apache/spark/pull/33522#discussion_r741566717 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PullOutJoinCondition.scala ## @@ -0,0 +1,76 @@ +/* + * Licensed to the

[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-958584621 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49335/ -- This is an automated message from the Apache

[GitHub] [spark] venkata91 commented on a change in pull request #33896: [SPARK-33701][SHUFFLE] Adaptive shuffle merge finalization for push-based shuffle

2021-11-02 Thread GitBox
venkata91 commented on a change in pull request #33896: URL: https://github.com/apache/spark/pull/33896#discussion_r741556426 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1716,7 +1739,31 @@ private[spark] class DAGScheduler(

[GitHub] [spark] ekoifman commented on a change in pull request #34464: [SPARK-37193][SQL] DynamicJoinSelection.shouldDemoteBroadcastHashJoin should not apply to outer joins

2021-11-02 Thread GitBox
ekoifman commented on a change in pull request #34464: URL: https://github.com/apache/spark/pull/34464#discussion_r741555797 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/DynamicJoinSelection.scala ## @@ -50,10 +51,16 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958557735 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144861/

[GitHub] [spark] AmplabJenkins commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958557735 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144861/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958302148 **[Test build #144861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144861/testReport)** for PR 34471 at commit

[GitHub] [spark] SparkQA commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958554880 **[Test build #144861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144861/testReport)** for PR 34471 at commit

[GitHub] [spark] SparkQA commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958547677 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49334/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
SparkQA commented on pull request #34469: URL: https://github.com/apache/spark/pull/34469#issuecomment-958537848 **[Test build #144865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144865/testReport)** for PR 34469 at commit

[GitHub] [spark] venkata91 commented on a change in pull request #33896: [SPARK-33701][SHUFFLE] Adaptive shuffle merge finalization for push-based shuffle

2021-11-02 Thread GitBox
venkata91 commented on a change in pull request #33896: URL: https://github.com/apache/spark/pull/33896#discussion_r741551702 ## File path: core/src/main/scala/org/apache/spark/Dependency.scala ## @@ -131,7 +135,7 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34374: [SPARK-37104][PYTHON] Make RDD and DStream covariant

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34374: URL: https://github.com/apache/spark/pull/34374#issuecomment-958531676 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49333/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958531673 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49331/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958531680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49330/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins removed a comment on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958531677 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49332/

[GitHub] [spark] AmplabJenkins commented on pull request #34374: [SPARK-37104][PYTHON] Make RDD and DStream covariant

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34374: URL: https://github.com/apache/spark/pull/34374#issuecomment-958531676 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49333/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958531673 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49331/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958531677 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49332/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
AmplabJenkins commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958531680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49330/ --

[GitHub] [spark] SparkQA commented on pull request #34462: [SPARK-37191][SQL] Allow merging DecimalTypes with different precision values

2021-11-02 Thread GitBox
SparkQA commented on pull request #34462: URL: https://github.com/apache/spark/pull/34462#issuecomment-958516706 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49331/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34471: [SPARK-36879][SQL]Support Parquet v2 data page encoding (DELTA_BINARY_PACKED) for the vectorized path

2021-11-02 Thread GitBox
SparkQA commented on pull request #34471: URL: https://github.com/apache/spark/pull/34471#issuecomment-958490904 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49330/ -- This is an automated message from the

[GitHub] [spark] viirya commented on a change in pull request #34469: [SPARK-37200][SQL] Support drop index for Data Source V2

2021-11-02 Thread GitBox
viirya commented on a change in pull request #34469: URL: https://github.com/apache/spark/pull/34469#discussion_r741544276 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2300,6 +2300,11 @@ class DDLParserSuite

[GitHub] [spark] github-actions[bot] commented on pull request #33491: [WIP][SPARK-34851][CORE][SQL] Add tag for each configuration

2021-11-02 Thread GitBox
github-actions[bot] commented on pull request #33491: URL: https://github.com/apache/spark/pull/33491#issuecomment-958485252 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] SparkQA commented on pull request #34451: [SPARK-37038][SQL] DSV2 Sample Push Down

2021-11-02 Thread GitBox
SparkQA commented on pull request #34451: URL: https://github.com/apache/spark/pull/34451#issuecomment-958479130 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49332/ -- This is an automated message from the

  1   2   3   4   5   6   7   8   9   >